From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03CDFC433E6 for ; Fri, 28 Aug 2020 10:10:46 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7AA962078A for ; Fri, 28 Aug 2020 10:10:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="DNkUP5hd"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="YDvbZll7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7AA962078A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id D5F681894; Fri, 28 Aug 2020 12:09:53 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz D5F681894 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1598609443; bh=5jQnPaJ15b3lgrTqEccYq7TYJVSW+QMza4rGFIuayPw=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=DNkUP5hdqB8OfkS2cLShMHiuWJGMLaxPOfu7pAv+AsvvKwlXEKkDcveFA6sg7KgvD CjShhdMJqV+Srh+sMxxJZiciQENeGBJHCzFrztv11VxTPJMlAIcgXMB7D0sPw5QqGz D71cPMr0tEchMIEozlyARw4amFCjtycPokzWcpSc= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 74557F801D9; Fri, 28 Aug 2020 12:09:53 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id F3484F801F2; Fri, 28 Aug 2020 12:09:51 +0200 (CEST) Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id A8C6FF80105 for ; Fri, 28 Aug 2020 12:09:41 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz A8C6FF80105 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="YDvbZll7" Received: by mail-wm1-x343.google.com with SMTP id c19so519514wmd.1 for ; Fri, 28 Aug 2020 03:09:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=m1YLyJUJCn3oBul9/khpe2532Xp6POTXvt7taeRkGPU=; b=YDvbZll7Ma7sTT+UPVORezULJlnx2tLfQ5IeE3Ehw57Kq2kkU/64SeqXuWw20swHB3 DRSP1n7jHPr8urmDdaKZSWN+tS6LcvCpPSGokVwqyHBZ5IvOprC+08jw+ruC99ayLMuG 8atji1mzhlt/j6cS1lgrOfyGuwEcNpksJ0etGBqElxC6aXiAhR+hQzrS0PzcfF7Qd6Ux oXeBNlOxbPHK4b0Zo0A84nlF+KGFkhzVo040o6iK1myBSFcKSWVru5dkp0z4tzSwLfK7 LP9lNSlKR5ZaMMfDdYgCsNu4oLwPZAVk2SssF2ZcRVPK5CD3bjwFQU1KXK3W6xzh8aEN yqmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=m1YLyJUJCn3oBul9/khpe2532Xp6POTXvt7taeRkGPU=; b=fxgXmqrOxFDs2S2ZAqOgO3s9i/Giq4d8Je9yAtbOLSoWaxXcAz5FgA6FJKqYmMbWOa d1yRVfHshBUnfonZ/bPHyqAAGyghEYmGTVslnasHn55U9kyFSMjStCsvh0vFscpmEMC8 vLiEU3xmUdDYIRUPe8nmC7P4Vi6Coomgum8IweMDu3lZfbQBT9JGRX0fFojTz+iK/j21 acHYo7V76RfvvJf6SDNSR/W34xC8pg+zrzctCQY/4JzwhPILQ+TIyl+shX0+OfQ35Rnc oS2Ghc6oSh6tYu3DB01dTXAw6ws6XG0TiBBjO/2iijMGzEPOJluF1MWH+BBD2fmd5RGk ip0w== X-Gm-Message-State: AOAM532FWF5MU/vzZF8YHTvCp898iLrUEv74+PL7vQV3EvYpTGBqlkO5 2HD7frUSATwZ6SMIXPYseVgRaw== X-Google-Smtp-Source: ABdhPJxgckZPiiORSGh1t7YPnXLaoCx7sqGLxWs0rDpMahar5tKh4ddv01PRLYLdrPq+EKDyrsXwZg== X-Received: by 2002:a1c:541b:: with SMTP id i27mr837248wmb.179.1598609380973; Fri, 28 Aug 2020 03:09:40 -0700 (PDT) Received: from dell ([91.110.221.141]) by smtp.gmail.com with ESMTPSA id c206sm1419164wmf.47.2020.08.28.03.09.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Aug 2020 03:09:40 -0700 (PDT) Date: Fri, 28 Aug 2020 11:09:38 +0100 From: Lee Jones To: Krzysztof Kozlowski Subject: Re: [PATCH 1/3] mfd: madera: Simplify with dev_err_probe() Message-ID: <20200828100938.GH1826686@dell> References: <20200826144935.10067-1-krzk@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200826144935.10067-1-krzk@kernel.org> Cc: alsa-devel@alsa-project.org, Charles Keepax , Alexandre Torgue , patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, Richard Fitzgerald , Maxime Coquelin , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, 26 Aug 2020, Krzysztof Kozlowski wrote: > Common pattern of handling deferred probe can be simplified with > dev_err_probe(). Less code and also it prints the error value. > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/mfd/madera-core.c | 11 +++-------- > 1 file changed, 3 insertions(+), 8 deletions(-) Applied, thanks. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC3FFC433E6 for ; Fri, 28 Aug 2020 10:11:07 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7BD492078A for ; Fri, 28 Aug 2020 10:11:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XdKdkSom"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="YDvbZll7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7BD492078A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=j3FQTy9kicF9osseDRlzbd0xjYZGFYimCiPuqGK1W4Q=; b=XdKdkSomnZ0+/Q6Ip0Lv3Hshw pFTGWDdZ06QmPbgITkU4UNtt1gvdO46w/iXy/XF92Q6JMomadi+DnPerhyf9G64ov9sQEtw0ZfPex FdSqlNHr263pM4/RVRWGKDedA+fo7LeNowwZO2OOvdtLLa9p7GHZHNpjOESWJZSjQZoPlDZO57hKY NSjKG675+Ae65VYSl2fEy9ETpDcHTN0oLKoUzgwicDieRJyBAakX3w6p1XaLWis1x0aBb4gymt8s2 5rP/VsDwhKud3RdM5et7HZzN2Tz1BEjq8F1f7oD/QbYW7IUtBEgpkGGb97uoSEAPIrvZj9Rqab2MC m7ZrsWpaA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kBbKJ-0003QC-Uz; Fri, 28 Aug 2020 10:09:43 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kBbKH-0003Pe-Qo for linux-arm-kernel@lists.infradead.org; Fri, 28 Aug 2020 10:09:42 +0000 Received: by mail-wm1-x343.google.com with SMTP id y8so518724wma.0 for ; Fri, 28 Aug 2020 03:09:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=m1YLyJUJCn3oBul9/khpe2532Xp6POTXvt7taeRkGPU=; b=YDvbZll7Ma7sTT+UPVORezULJlnx2tLfQ5IeE3Ehw57Kq2kkU/64SeqXuWw20swHB3 DRSP1n7jHPr8urmDdaKZSWN+tS6LcvCpPSGokVwqyHBZ5IvOprC+08jw+ruC99ayLMuG 8atji1mzhlt/j6cS1lgrOfyGuwEcNpksJ0etGBqElxC6aXiAhR+hQzrS0PzcfF7Qd6Ux oXeBNlOxbPHK4b0Zo0A84nlF+KGFkhzVo040o6iK1myBSFcKSWVru5dkp0z4tzSwLfK7 LP9lNSlKR5ZaMMfDdYgCsNu4oLwPZAVk2SssF2ZcRVPK5CD3bjwFQU1KXK3W6xzh8aEN yqmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=m1YLyJUJCn3oBul9/khpe2532Xp6POTXvt7taeRkGPU=; b=PJ8+rEB4FhoqXOJT/kitj5G2CjjC2zPPlT8JiBfdKkGVQ1V4mGR4JMSSecCURG+pg6 W7AeO13zObPUbmT08iRJA7xmyv+uauMabGpp8tvQjGjq8ZRVVh4HEsvWcx+Uq3Dff1Kq gHg8IvJtofvgpHzbEoe1acDHxIz91HfRlgUVblRfWtcGvng29Z75PnIFw+HipjbFSlR8 yQIVO7H4u5eOWATqLrir0DGqDtR1oNU+4isfWle4sR50Y0qlxQIdJicPEmt088oXFXIE voIGxWhEzWpb8dHFy1EbseVXT0MMwAtO9w49GVh90INOrnrCcHra90/O7YZfOlgi6bkL VlTQ== X-Gm-Message-State: AOAM530VkYJMffJ9KBgWnDFq6FYrHOk3cAa6m/1RWjWra0bsPeSFd9WA mfBXUX2qitWlU1no3I5cyqDmfg== X-Google-Smtp-Source: ABdhPJxgckZPiiORSGh1t7YPnXLaoCx7sqGLxWs0rDpMahar5tKh4ddv01PRLYLdrPq+EKDyrsXwZg== X-Received: by 2002:a1c:541b:: with SMTP id i27mr837248wmb.179.1598609380973; Fri, 28 Aug 2020 03:09:40 -0700 (PDT) Received: from dell ([91.110.221.141]) by smtp.gmail.com with ESMTPSA id c206sm1419164wmf.47.2020.08.28.03.09.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Aug 2020 03:09:40 -0700 (PDT) Date: Fri, 28 Aug 2020 11:09:38 +0100 From: Lee Jones To: Krzysztof Kozlowski Subject: Re: [PATCH 1/3] mfd: madera: Simplify with dev_err_probe() Message-ID: <20200828100938.GH1826686@dell> References: <20200826144935.10067-1-krzk@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200826144935.10067-1-krzk@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200828_060941_879748_53B9BAB5 X-CRM114-Status: GOOD ( 12.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, Charles Keepax , Alexandre Torgue , patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, Richard Fitzgerald , Maxime Coquelin , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCAyNiBBdWcgMjAyMCwgS3J6eXN6dG9mIEtvemxvd3NraSB3cm90ZToKCj4gQ29tbW9u IHBhdHRlcm4gb2YgaGFuZGxpbmcgZGVmZXJyZWQgcHJvYmUgY2FuIGJlIHNpbXBsaWZpZWQgd2l0 aAo+IGRldl9lcnJfcHJvYmUoKS4gIExlc3MgY29kZSBhbmQgYWxzbyBpdCBwcmludHMgdGhlIGVy cm9yIHZhbHVlLgo+IAo+IFNpZ25lZC1vZmYtYnk6IEtyenlzenRvZiBLb3psb3dza2kgPGtyemtA a2VybmVsLm9yZz4KPiAtLS0KPiAgZHJpdmVycy9tZmQvbWFkZXJhLWNvcmUuYyB8IDExICsrKy0t LS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKyksIDggZGVsZXRpb25zKC0p CgpBcHBsaWVkLCB0aGFua3MuCgotLSAKTGVlIEpvbmVzIFvmnY7nkLzmlq9dClNlbmlvciBUZWNo bmljYWwgTGVhZCAtIERldmVsb3BlciBTZXJ2aWNlcwpMaW5hcm8ub3JnIOKUgiBPcGVuIHNvdXJj ZSBzb2Z0d2FyZSBmb3IgQXJtIFNvQ3MKRm9sbG93IExpbmFybzogRmFjZWJvb2sgfCBUd2l0dGVy IHwgQmxvZwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K bGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZy YWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGlu dXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 251A6C433E6 for ; Fri, 28 Aug 2020 10:09:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EF7CD2078A for ; Fri, 28 Aug 2020 10:09:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="YDvbZll7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729103AbgH1KJo (ORCPT ); Fri, 28 Aug 2020 06:09:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43724 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728532AbgH1KJm (ORCPT ); Fri, 28 Aug 2020 06:09:42 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46A79C061264 for ; Fri, 28 Aug 2020 03:09:42 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id z9so398774wmk.1 for ; Fri, 28 Aug 2020 03:09:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=m1YLyJUJCn3oBul9/khpe2532Xp6POTXvt7taeRkGPU=; b=YDvbZll7Ma7sTT+UPVORezULJlnx2tLfQ5IeE3Ehw57Kq2kkU/64SeqXuWw20swHB3 DRSP1n7jHPr8urmDdaKZSWN+tS6LcvCpPSGokVwqyHBZ5IvOprC+08jw+ruC99ayLMuG 8atji1mzhlt/j6cS1lgrOfyGuwEcNpksJ0etGBqElxC6aXiAhR+hQzrS0PzcfF7Qd6Ux oXeBNlOxbPHK4b0Zo0A84nlF+KGFkhzVo040o6iK1myBSFcKSWVru5dkp0z4tzSwLfK7 LP9lNSlKR5ZaMMfDdYgCsNu4oLwPZAVk2SssF2ZcRVPK5CD3bjwFQU1KXK3W6xzh8aEN yqmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=m1YLyJUJCn3oBul9/khpe2532Xp6POTXvt7taeRkGPU=; b=cAeRxEprVFGsHli0gCihvOOGJEL2P5BqWezDmTGt6ohTGfSMDf3sc0wBhBIfs5Nrbr FQzKULfUJAWCcSF5NUYtd6cBZ9LC/SAxuMxKtLP58H/MQ6zt5xzo/kWki4RjaQVzaQVc qcoqgjISpgvAYE0pL2p0ukQK/SztiUScdPko2eaFzFjV0fu3r7JF5LjW2MZTt2IZdIPQ 4s5N/oOt3ar1fAQzxIUv81ucDUehdNeE4Bh3BAjtoRVXkOEZeghK4ZXi3dakKm0wbfxt Jq5ntp+ilHZknTqpQLSBWq7jQbKAhhfp6e8RDmbMaPLS41D0XnaoOXaf5bJjR0/4jSAH 1cQg== X-Gm-Message-State: AOAM5335xctTHLC+wYmkco03faXlZ5z+5a4NCSXX2+VL7q1DQiclPjvC dHpFnPlQFzy9D6JSTlr3uZMY+w== X-Google-Smtp-Source: ABdhPJxgckZPiiORSGh1t7YPnXLaoCx7sqGLxWs0rDpMahar5tKh4ddv01PRLYLdrPq+EKDyrsXwZg== X-Received: by 2002:a1c:541b:: with SMTP id i27mr837248wmb.179.1598609380973; Fri, 28 Aug 2020 03:09:40 -0700 (PDT) Received: from dell ([91.110.221.141]) by smtp.gmail.com with ESMTPSA id c206sm1419164wmf.47.2020.08.28.03.09.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Aug 2020 03:09:40 -0700 (PDT) Date: Fri, 28 Aug 2020 11:09:38 +0100 From: Lee Jones To: Krzysztof Kozlowski Cc: Charles Keepax , Richard Fitzgerald , Maxime Coquelin , Alexandre Torgue , alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/3] mfd: madera: Simplify with dev_err_probe() Message-ID: <20200828100938.GH1826686@dell> References: <20200826144935.10067-1-krzk@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200826144935.10067-1-krzk@kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 26 Aug 2020, Krzysztof Kozlowski wrote: > Common pattern of handling deferred probe can be simplified with > dev_err_probe(). Less code and also it prints the error value. > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/mfd/madera-core.c | 11 +++-------- > 1 file changed, 3 insertions(+), 8 deletions(-) Applied, thanks. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog