From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] tst_af_alg: fix build error when ALG_SET_AEAD_ASSOCLEN undefined
Date: Fri, 28 Aug 2020 12:33:51 +0200 [thread overview]
Message-ID: <20200828103351.GA12046@dell5510> (raw)
In-Reply-To: <373798f7-d1e4-330a-0911-efcd6f1d1480@cn.fujitsu.com>
Hi Xu,
> Hi Petr
> > Hi,
> > ...
> > > --- a/configure.ac
> > > +++ b/configure.ac
> > > @@ -193,6 +193,12 @@ AC_CHECK_TYPES([struct xt_entry_match, struct xt_entry_target],,,[
> > > #include <linux/netfilter_ipv4/ip_tables.h>
> > > ])
> > > +AC_CHECK_TYPES([struct sockaddr_alg, struct af_alg_iv],,,[
> > > +#ifdef HAVE_LINUX_IF_ALG_H
> > > +# include <linux/if_alg.h>
> > > +#endif
> > IMHO <linux/if_alg.h> does not need to be guarded.
> > (as the definitions are in it it either fail because missing or fail because not
> > loaded)
> > > +])
> Yes. Do you merge this patch with deleting this ifdef? Or I sent a v2 patch
> for this.
> Also, I think you can remove" #ifdef HAVE_LINUX_IF_PACKET_H" pair in
> configure.ac
> AC_CHECK_TYPES([struct tpacket_req3],,,[
> #ifdef HAVE_LINUX_IF_PACKET_H
> # include <linux/if_packet.h>
> #endif
> ])
I'll fix it and merge.
Kind regards,
Petr
> Best Regards
> Yang Xu
next prev parent reply other threads:[~2020-08-28 10:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-21 10:18 [LTP] [PATCH] tst_af_alg: fix build error when ALG_SET_AEAD_ASSOCLEN undefined Yang Xu
2020-08-28 8:43 ` Petr Vorel
2020-08-28 9:27 ` Yang Xu
2020-08-28 8:48 ` Petr Vorel
2020-08-28 9:34 ` Yang Xu
2020-08-28 10:33 ` Petr Vorel [this message]
2020-08-28 10:40 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200828103351.GA12046@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.