From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Tong Zhang <ztong0001@gmail.com>
Cc: kadlec@netfilter.org, fw@strlen.de, davem@davemloft.net,
kuba@kernel.org, netfilter-devel@vger.kernel.org,
coreteam@netfilter.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] netfilter: nf_conntrack_sip: fix parsing error
Date: Fri, 28 Aug 2020 20:07:42 +0200 [thread overview]
Message-ID: <20200828180742.GA20488@salvia> (raw)
In-Reply-To: <20200815165030.5849-1-ztong0001@gmail.com>
On Sat, Aug 15, 2020 at 12:50:30PM -0400, Tong Zhang wrote:
> ct_sip_parse_numerical_param can only return 0 or 1, but the caller is
> checking parsing error using < 0
Is this are real issue in your setup or probably some static analysis
tool is reporting?
You are right that ct_sip_parse_numerical_param() never returns < 0,
however, looking at:
https://tools.ietf.org/html/rfc3261 see Page 161
expires is optional, my understanding is that your patch is making
this option mandatory.
next prev parent reply other threads:[~2020-08-28 18:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-15 16:50 [PATCH] netfilter: nf_conntrack_sip: fix parsing error Tong Zhang
2020-08-15 22:50 ` Florian Westphal
2020-08-28 18:07 ` Pablo Neira Ayuso [this message]
2020-08-28 18:14 ` Tong Zhang
2020-08-28 18:19 ` Pablo Neira Ayuso
2020-08-28 18:30 ` Tong Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200828180742.GA20488@salvia \
--to=pablo@netfilter.org \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=ztong0001@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.