From: Jean Delvare <jdelvare@suse.de>
To: Wolfram Sang <wsa@kernel.org>
Cc: Linux I2C <linux-i2c@vger.kernel.org>
Subject: Re: [PATCH 2/2] decode-vaio: Add support for the at24 driver
Date: Sat, 29 Aug 2020 10:18:35 +0200 [thread overview]
Message-ID: <20200829101835.3aeb4d6a@endymion> (raw)
In-Reply-To: <20200828084703.GG1343@ninjato>
On Fri, 28 Aug 2020 10:47:03 +0200, Wolfram Sang wrote:
> > -for (my $i = 0, $found=0; $i <= 4 && !$found; $i++)
> > +for (my $i = 0, $found=0; $i <= 31 && !$found; $i++)
>
> Isn't this an unrelated change, scanning more busses? Should be at least
> mentioned in the commit message, if so.
You're right, it should be a separate commit. I had to do this to be
able to test my changes with i2c-stub instead of using the actual old
Sony laptop. Then I forgot the change was there. I'll push that change
anyway as it can't hurt and everything that makes testing easier is
welcome.
Thanks,
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2020-08-29 8:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-27 13:25 [PATCH 1/2] There are several eeprom drivers Jean Delvare
2020-08-27 13:28 ` [PATCH 2/2] decode-vaio: Add support for the at24 driver Jean Delvare
2020-08-28 8:47 ` Wolfram Sang
2020-08-29 8:18 ` Jean Delvare [this message]
2020-08-28 8:43 ` [PATCH 1/2] There are several eeprom drivers Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200829101835.3aeb4d6a@endymion \
--to=jdelvare@suse.de \
--cc=linux-i2c@vger.kernel.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.