From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4 1/7] package/go: implement go modules integration
Date: Sat, 29 Aug 2020 15:04:12 +0200 [thread overview]
Message-ID: <20200829150412.43fd3c14@windsurf.home> (raw)
In-Reply-To: <20200813213220.260112-1-christian@paral.in>
On Thu, 13 Aug 2020 14:32:14 -0700
Christian Stewart <christian@paral.in> wrote:
> +HOST_GO_GOPATH = $(HOST_DIR)/usr/share/go-path
[...]
> + GOPATH="$(HOST_GO_GOPATH)" \
Are you sure this GOPATH is needed ? We're supposed to move away from
GOPATH, but you're adding a new GOPATH location here, and in a build
that has all our Go packages enabled, this
$(HOST_DIR)/usr/share/go-path location doesn't even exist.
Could you clarify ?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2020-08-29 13:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-13 21:32 [Buildroot] [PATCH v4 1/7] package/go: implement go modules integration Christian Stewart
2020-08-13 21:32 ` [Buildroot] [PATCH v4 2/7] package/runc: remove unnecessary workspace identifier Christian Stewart
2020-08-13 21:32 ` [Buildroot] [PATCH v4 3/7] package/docker-containerd: fix go-module package identifier/targets Christian Stewart
2020-08-29 13:01 ` [Buildroot] [PATCH v4 3/7] package/docker-containerd: fix go-module package identifier/target Thomas Petazzoni
2020-08-13 21:32 ` [Buildroot] [PATCH v4 4/7] package/docker-engine: fix go-module package identifier Christian Stewart
2020-08-13 21:32 ` [Buildroot] [PATCH v4 5/7] package/docker-cli: " Christian Stewart
2020-08-13 21:32 ` [Buildroot] [PATCH v4 6/7] package/docker-proxy: " Christian Stewart
2020-08-13 21:32 ` [Buildroot] [PATCH v4 7/7] package/mender-artifact: fix go-module package build target Christian Stewart
2020-08-13 21:45 ` [Buildroot] [PATCH v4 1/7] package/go: implement go modules integration Thomas Petazzoni
2020-08-13 21:52 ` Christian Stewart
2020-08-28 18:30 ` Christian Stewart
2020-08-29 8:57 ` Arnout Vandecappelle
2020-08-29 12:59 ` Thomas Petazzoni
2020-08-29 17:32 ` Christian Stewart
2020-08-29 18:40 ` Thomas Petazzoni
2020-08-29 13:04 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200829150412.43fd3c14@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.