From: Jonathan Cameron <jic23@kernel.org>
To: Nishant Malpani <nish.malpani25@gmail.com>
Cc: dragos.bogdan@analog.com, darius.berghe@analog.com,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org
Subject: Re: [PATCH 1/1] iio: gyro: adxrs290: Insert missing mutex initialization call
Date: Sat, 29 Aug 2020 17:25:54 +0100 [thread overview]
Message-ID: <20200829172554.288e314d@archlinux> (raw)
In-Reply-To: <20200825124552.11155-1-nish.malpani25@gmail.com>
On Tue, 25 Aug 2020 18:15:52 +0530
Nishant Malpani <nish.malpani25@gmail.com> wrote:
> Insert a missing mutex_init() call during the probe that initializes
> the driver's local lock to unlocked state.
>
> Fixes: 2c8920fff145 ("iio: gyro: Add driver support for ADXRS290")
> Signed-off-by: Nishant Malpani <nish.malpani25@gmail.com>
Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to play with it
Thanks,
Jonathan
> ---
> drivers/iio/gyro/adxrs290.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/iio/gyro/adxrs290.c b/drivers/iio/gyro/adxrs290.c
> index 38bab4e3eee9..ff989536d2fb 100644
> --- a/drivers/iio/gyro/adxrs290.c
> +++ b/drivers/iio/gyro/adxrs290.c
> @@ -385,6 +385,8 @@ static int adxrs290_probe(struct spi_device *spi)
> indio_dev->num_channels = ARRAY_SIZE(adxrs290_channels);
> indio_dev->info = &adxrs290_info;
>
> + mutex_init(&st->lock);
> +
> val = spi_w8r8(spi, ADXRS290_READ_REG(ADXRS290_REG_ADI_ID));
> if (val != ADXRS290_ADI_ID) {
> dev_err(&spi->dev, "Wrong ADI ID 0x%02x\n", val);
prev parent reply other threads:[~2020-08-29 16:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-25 12:45 [PATCH 1/1] iio: gyro: adxrs290: Insert missing mutex initialization call Nishant Malpani
2020-08-29 16:25 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200829172554.288e314d@archlinux \
--to=jic23@kernel.org \
--cc=darius.berghe@analog.com \
--cc=dragos.bogdan@analog.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nish.malpani25@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.