From: Martin Bukatovic <martin.bukatovic@gmail.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: fio@vger.kernel.org
Subject: Re: [PATCH] Add fill_quota option
Date: Sat, 29 Aug 2020 22:34:17 +0200 [thread overview]
Message-ID: <20200829203417.GA18208@dione.lan> (raw)
In-Reply-To: <3e8f33c3-6d57-8932-b84e-374c0afd4779@kernel.dk>
On Sat, Aug 29, 2020 at 01:44:07PM -0600, Jens Axboe wrote:
> On 8/29/20 1:01 PM, Martin Bukatovic wrote:
> > On Fri, Aug 28, 2020 at 05:53:34PM -0600, Jens Axboe wrote:
> >> Might be easier and saner to just accept EDQUOT by default, instead of
> >> adding an option for it?
> >
> > I proposed a new option to avoid changing behaviour of fill_device
> > option. But if that is not necessary, I agree that making fill_device to
> > stop on both ENOSPC and EDQUOT makes more sense.
>
> I don't think that's necessary, the option is really "stop writing when
> we're full", and there's no way to reach ENOSPC before EDQUOT vs
> the other way around.
>
> Hence I think it's totally fine to just include EDQUOT in the "stop
> successfully" part of the fill_device behavior.
Ok, I'm sending new version of the patch "Make fill_device to stop
writing on EDQUOT".
--
Martin Bukatovič
prev parent reply other threads:[~2020-08-29 20:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-11 19:44 [PATCH] Add fill_quota option Martin Bukatovic
2020-08-21 22:15 ` Sitsofe Wheeler
2020-08-28 23:53 ` Jens Axboe
[not found] ` <20200829190131.GA8262@dione.lan>
[not found] ` <3e8f33c3-6d57-8932-b84e-374c0afd4779@kernel.dk>
2020-08-29 20:34 ` Martin Bukatovic [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200829203417.GA18208@dione.lan \
--to=martin.bukatovic@gmail.com \
--cc=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.