From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] infra/kconfig-package: quote HOSTCC_NOCCACHE
Date: Sat, 29 Aug 2020 23:00:54 +0200 [thread overview]
Message-ID: <20200829210054.GJ14354@scaer> (raw)
In-Reply-To: <20200829225407.0c804cdd@windsurf.home>
Thomas, All,
On 2020-08-29 22:54 +0200, Thomas Petazzoni spake thusly:
> On Sat, 29 Aug 2020 22:42:52 +0200
> "Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> > HOSTCC may contain spaces, so needs to be quoted.
> HOSTCC yes, but HOSTCC_NOCCACHE ?
Yes, why not?
$ make HOSTCC="distcc gcc-4.1"
which would yield a HOSTCC_MOCCACHE with a space in it.
Note also that HOSTCC_NOCCACHE is already quoted in most places it is
used.
Regards,
Yann E. MORIN.
> > Most of the places hwere it is already quoted use double-quotes, so we
> > use that.
> >
> > Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> > Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
>
> Minor nit: the commit title prefix should be package/pkg-kconfig.mk.
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
prev parent reply other threads:[~2020-08-29 21:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-29 20:42 [Buildroot] [PATCH] infra/kconfig-package: quote HOSTCC_NOCCACHE Yann E. MORIN
2020-08-29 20:54 ` Thomas Petazzoni
2020-08-29 21:00 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200829210054.GJ14354@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.