From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/rtty: fix build with mbedtls but without zlib
Date: Sun, 30 Aug 2020 22:55:56 +0200 [thread overview]
Message-ID: <20200830225556.12a131e1@windsurf.home> (raw)
In-Reply-To: <CAPi7W80P=KyKJm0REocozCv8mgDrEsrED0OtwqPdrOc_FEqygg@mail.gmail.com>
On Sun, 30 Aug 2020 22:39:43 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> The suggested patch is only fixing a build failure when zlib is not found.
> We're already linking needlessly with zlib since the bump to version
> 7.1.4 with commit 0c80245ddbe78c8e443f98b9bbccac56331cdb26.
> So would you advise that I revert
> https://github.com/zhaojh329/rtty/commit/7b8efe11dbafce97971dc130bf6cc1756f34ce07
> and manually link with -lz in rtty.mk if
> BR2_PACKAGE_MBEDTLS_COMPRESSION is set?
The only sane way to fix this is to use pkg-config, but as you said
mbedtls apparently doesn't provide any .pc file.
So I'd say, leave it as it is, but it's better to have the full
explanation on the benefits/drawbacks in the commit log rather than
having to second guess it.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2020-08-30 20:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-30 19:20 [Buildroot] [PATCH 1/1] package/rtty: fix build with mbedtls but without zlib Fabrice Fontaine
2020-08-30 20:02 ` Thomas Petazzoni
2020-08-30 20:11 ` Fabrice Fontaine
2020-08-30 20:31 ` Thomas Petazzoni
2020-08-30 20:39 ` Fabrice Fontaine
2020-08-30 20:55 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200830225556.12a131e1@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.