Re: [oe] [meta-oe][PATCH] nss: fix postinst in do_rootfs for target

["Mikko Rapeli" <mikko.rapeli@bmw.de>]

Hi,

On Fri, Aug 28, 2020 at 09:01:34PM +0200, Martin Jansa wrote:
> Partially revert "nss: fix postinst script for nativesdk build"
> 
> This reverts commit 31552510b15c1c97aa6cbe180c2bb53d139efbcc.
> 
> When running in do_rootfs we need to run shlibsign provided
> by nss-native, otherwise it fails when /usr/bin/shlibsign
> doesn't exist on host builder:
> 
> do_rootfs: Postinstall scriptlets of ['nss'] have failed. If the intention is to defer them to first boot,
> then please place them into pkg_postinst_ontarget_${PN} ().
> Deferring to first boot via 'exit 1' is no longer supported.

Thanks for this, it fixes all issues.

I didn't properly test my patch. Sorry!

-Mikko

> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> ---
>  meta-oe/recipes-support/nss/nss_3.54.bb | 26 ++++++++++++-------------
>  1 file changed, 13 insertions(+), 13 deletions(-)
> 
> diff --git a/meta-oe/recipes-support/nss/nss_3.54.bb b/meta-oe/recipes-support/nss/nss_3.54.bb
> index 882145c1ef..81b2538813 100644
> --- a/meta-oe/recipes-support/nss/nss_3.54.bb
> +++ b/meta-oe/recipes-support/nss/nss_3.54.bb
> @@ -240,19 +240,19 @@ do_install_append_class-target() {
>
>  PACKAGE_WRITE_DEPS += "nss-native"
>  pkg_postinst_${PN} () {
> -    if [ -n "$D" ]; then
> -        for I in $D${libdir}/lib*.chk; do
> -            DN=`dirname $I`
> -            BN=`basename $I .chk`
> -            FN=$DN/$BN.so
> -            ${bindir}/shlibsign -i $FN
> -            if [ $? -ne 0 ]; then
> -                exit 1
> -            fi
> -        done
> -    else
> -        ${bindir}/signlibs.sh
> -    fi
> +    for I in $D${libdir}/lib*.chk; do
> +        DN=`dirname $I`
> +        BN=`basename $I .chk`
> +        FN=$DN/$BN.so
> +        shlibsign -i $FN
> +        if [ $? -ne 0 ]; then
> +            echo "shlibsign -i $FN failed"
> +        fi
> +    done
> +}
> +
> +pkg_postinst_ontarget_${PN} () {
> +    ${bindir}/signlibs.sh
>  }
>
>  PACKAGES =+ "${PN}-smime"
> -- 
> 2.25.1
> 

>