From: Stephen Hemminger <stephen@networkplumber.org>
To: Andrew Rybchenko <arybchenko@solarflare.com>
Cc: Slava Ovsiienko <viacheslavo@mellanox.com>,
"dev@dpdk.org" <dev@dpdk.org>, Matan Azrad <matan@mellanox.com>,
Raslan Darawsheh <rasland@mellanox.com>,
Thomas Monjalon <thomas@monjalon.net>,
"ferruh.yigit@intel.com" <ferruh.yigit@intel.com>,
"jerinjacobk@gmail.com" <jerinjacobk@gmail.com>,
"ajit.khaparde@broadcom.com" <ajit.khaparde@broadcom.com>,
"maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>,
"olivier.matz@6wind.com" <olivier.matz@6wind.com>,
"david.marchand@redhat.com" <david.marchand@redhat.com>
Subject: Re: [dpdk-dev] [PATCH] doc: announce changes to ethdev rxconf structure
Date: Mon, 31 Aug 2020 09:59:18 -0700 [thread overview]
Message-ID: <20200831095918.6d357675@hermes.lan> (raw)
In-Reply-To: <beed7bdd-7a6a-73da-d9f3-3dc0befb7899@solarflare.com>
On Mon, 31 Aug 2020 09:35:18 +0300
Andrew Rybchenko <arybchenko@solarflare.com> wrote:
> >>>>> multisegment packets.
> >>>>
> >>>> I hope it will be mentioned in the feature documentation in the future, but
> >>>> I'm not 100% sure that it is required. See below.
> >>> I suppose there is the hierarchy:
> >>> - applications configures DEV_RX_OFFLOAD_SCATTER on the port and tells in this way:
> >>> "Hey, driver, I'm ready to handle multi-segment packets". Readiness in general.
> >>> - application configures BUFFER_SPLIT and tells PMD _HOW_ it wants to split, in particular way:
> >>> "Hey, driver, please, drop ten bytes here, here and here, and the rest - over there"
> >>
> >> My idea is to keep SCATTER and BUFFER_SPLIT independent.
> >> SCATTER is a possibility to make multi-segment packets getting
> >> mbufs from main rxq mempool as many as required.
> >> BUFFER_SPLIT is support of many mempools and splitting
> >> received packets as specified.
> >
> > No.
> > Once again, drivers should take anything from application and rely on using
> > logic to choose best path. Modern CPU's have good branch predictors, and making
> > the developer do that work is counter productive.
>
> Please, add a bit more details. I simply can see relationship.
> So, right now for me it looks like just misunderstanding.
>
> Thanks,
> Andrew.
Ok, documenting the existing behaviour is good. I was just concerned that this was
going to lead to more per-queue flags.
next prev parent reply other threads:[~2020-08-31 16:59 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-03 15:18 [dpdk-dev] [PATCH] doc: announce changes to ethdev rxconf structure Slava Ovsiienko
2020-08-03 15:31 ` Andrew Rybchenko
2020-08-03 16:51 ` Slava Ovsiienko
2020-08-30 12:58 ` Andrew Rybchenko
2020-08-30 18:26 ` Stephen Hemminger
2020-08-31 6:35 ` Andrew Rybchenko
2020-08-31 16:59 ` Stephen Hemminger [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-08-03 10:58 Viacheslav Ovsiienko
2020-08-03 11:56 ` Jerin Jacob
2020-08-03 13:06 ` Slava Ovsiienko
2020-08-04 13:32 ` Jerin Jacob
2020-08-05 6:35 ` Slava Ovsiienko
2020-08-06 15:58 ` Ferruh Yigit
2020-08-06 16:25 ` Stephen Hemminger
2020-08-06 16:41 ` Jerin Jacob
2020-08-06 17:03 ` Slava Ovsiienko
2020-08-06 18:10 ` Stephen Hemminger
2020-08-07 11:23 ` Slava Ovsiienko
2020-08-03 14:31 ` [dpdk-dev] ***Spam*** " Andrew Rybchenko
2020-08-06 16:15 ` [dpdk-dev] " Ferruh Yigit
2020-08-06 16:29 ` Slava Ovsiienko
2020-08-06 16:37 ` Ferruh Yigit
2020-08-06 16:39 ` Slava Ovsiienko
2020-08-06 16:43 ` Ferruh Yigit
2020-08-06 16:48 ` Slava Ovsiienko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200831095918.6d357675@hermes.lan \
--to=stephen@networkplumber.org \
--cc=ajit.khaparde@broadcom.com \
--cc=arybchenko@solarflare.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jerinjacobk@gmail.com \
--cc=matan@mellanox.com \
--cc=maxime.coquelin@redhat.com \
--cc=olivier.matz@6wind.com \
--cc=rasland@mellanox.com \
--cc=thomas@monjalon.net \
--cc=viacheslavo@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.