All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: linus.walleij@linaro.org
Cc: dri-devel@lists.freedesktop.org
Subject: [bug report] drm/mcde: Add new driver for ST-Ericsson MCDE
Date: Mon, 31 Aug 2020 14:39:07 +0300	[thread overview]
Message-ID: <20200831113907.GA514373@mwanda> (raw)

Hello Linus Walleij,

The patch 5fc537bfd000: "drm/mcde: Add new driver for ST-Ericsson
MCDE" from May 24, 2019, leads to the following static checker
warning:

	drivers/gpu/drm/mcde/mcde_display.c:570 mcde_configure_channel()
	error: uninitialized symbol 'val'.

drivers/gpu/drm/mcde/mcde_display.c
   552          case MCDE_VIDEO_TE_FLOW:
   553                  val = MCDE_CHNLXSYNCHMOD_SRC_SYNCH_HARDWARE
   554                          << MCDE_CHNLXSYNCHMOD_SRC_SYNCH_SHIFT;
   555                  val |= MCDE_CHNLXSYNCHMOD_OUT_SYNCH_SRC_TE0
   556                          << MCDE_CHNLXSYNCHMOD_OUT_SYNCH_SRC_SHIFT;
   557                  break;
   558          case MCDE_VIDEO_FORMATTER_FLOW:
   559                  val = MCDE_CHNLXSYNCHMOD_SRC_SYNCH_HARDWARE
   560                          << MCDE_CHNLXSYNCHMOD_SRC_SYNCH_SHIFT;
   561                  val |= MCDE_CHNLXSYNCHMOD_OUT_SYNCH_SRC_FORMATTER
   562                          << MCDE_CHNLXSYNCHMOD_OUT_SYNCH_SRC_SHIFT;
   563                  break;
   564          default:
   565                  dev_err(mcde->dev, "unknown flow mode %d\n",
   566                          mcde->flow_mode);

"val" not initialized on this path.

   567                  break;
   568          }
   569  
   570          writel(val, mcde->regs + sync);
   571  
   572          /* Set up pixels per line and lines per frame */

regards,
dan carpenter
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

             reply	other threads:[~2020-08-31 11:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-31 11:39 Dan Carpenter [this message]
2020-09-12 10:29 ` [bug report] drm/mcde: Add new driver for ST-Ericsson MCDE Linus Walleij
  -- strict thread matches above, loose matches on Subject: below --
2019-05-29 11:35 Dan Carpenter
2019-05-29 11:32 Dan Carpenter
2019-05-29 14:05 ` Linus Walleij
2019-05-29 11:06 Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200831113907.GA514373@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linus.walleij@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.