Re: [igt-dev] [PATCH] [i-g-t] tests/i915_pm_lpsp: remove screens-disabled subtest

From: Anshuman Gupta <anshuman.gupta@intel.com>
To: Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH] [i-g-t] tests/i915_pm_lpsp: remove screens-disabled subtest
Date: Mon, 31 Aug 2020 17:25:17 +0530	[thread overview]
Message-ID: <20200831115514.GL25390@intel.com> (raw)
In-Reply-To: <20200831115515.16531-1-tejaskumarx.surendrakumar.upadhyay@intel.com>

On 2020-08-31 at 17:25:15 +0530, Tejas Upadhyay wrote:
> screens-disabled subtest is not required to run when
> DMC firmware is loaded. Thus this test code becomes
> redundant and increases needless SKIP counts.
> 
> Cc: Anshuman Gupta <Anshuman.Gupta@intel.com>
> Signed-off-by: Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com>
> ---
>  tests/i915/i915_pm_lpsp.c | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/tests/i915/i915_pm_lpsp.c b/tests/i915/i915_pm_lpsp.c
> index 4a187810..d1efd9e0 100644
> --- a/tests/i915/i915_pm_lpsp.c
> +++ b/tests/i915/i915_pm_lpsp.c
> @@ -185,13 +185,6 @@ igt_main
>  		igt_require(igt_pm_dmc_loaded(data.debugfs_fd));
>  	}
>  
> -	igt_describe("This test validates lpsp while all crtc are disabled");
> -	igt_subtest("screens-disabled") {
> -		igt_require_f(!dmc_supported(data.debugfs_fd),
> -			      "DC states supported platform don't have ROI for this subtest\n");
> -		screens_disabled_subtest(&data);
> -	}
> -
Platfrom like HASWELL still need this test, you can't simply remove the test, this is a valid skip
for platform above skl+.
Thanks,
Anshuman Gupta.  
>  	igt_describe("This test validates lpsp on all connected outputs on low power PIPE_A");
>  	igt_subtest_with_dynamic_f("kms-lpsp") {
>  		igt_display_t *display = &data.display;
> -- 
> 2.25.1
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev