From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH v2 00/76] target/microblaze improvements
Date: Mon, 31 Aug 2020 16:14:35 +0200 [thread overview]
Message-ID: <20200831141435.GD14249@toto> (raw)
In-Reply-To: <20200828141929.77854-1-richard.henderson@linaro.org>
On Fri, Aug 28, 2020 at 07:18:13AM -0700, Richard Henderson wrote:
> Thanks for all the testing and review, Edgar.
>
> Changes in v2:
> * Restored opcode_0_illegal handling.
> * Dropped problematic imm/delay slot tb extension.
> * Dropped tcg_gen_lookup_and_goto_ptr for now.
> * Added fix for mb_cpu_transaction_failed.
> * Removed microblaze-decode.h with old decoder.
> * Removed abort_at_next_insn with old decoder.
> * Fixed mbar.
> * Fixed put.
>
>
> r~
I had one more comment on patch #27 but the rest of the series looks good to
me and it also passes my tests.
So once you fix #27 feel free to add my RB & TB tags on the entire series.
It's probably easiest if you send a pull-req via one of your trees.
Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
Tested-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
Thanks again for working on this!
Cheers,
Edgar
>
>
> Richard Henderson (76):
> tests/tcg: Add microblaze to arches filter
> tests/tcg: Do not require FE_TOWARDZERO
> tests/tcg: Do not require FE_* exception bits
> target/microblaze: Tidy gdbstub
> target/microblaze: Split out PC from env->sregs
> target/microblaze: Split out MSR from env->sregs
> target/microblaze: Split out EAR from env->sregs
> target/microblaze: Split out ESR from env->sregs
> target/microblaze: Split out FSR from env->sregs
> target/microblaze: Split out BTR from env->sregs
> target/microblaze: Split out EDR from env->sregs
> target/microblaze: Split the cpu_SR array
> target/microblaze: Fix width of PC and BTARGET
> target/microblaze: Fix width of MSR
> target/microblaze: Fix width of ESR
> target/microblaze: Fix width of FSR
> target/microblaze: Fix width of BTR
> target/microblaze: Fix width of EDR
> target/microblaze: Remove cpu_ear
> target/microblaze: Tidy raising of exceptions
> target/microblaze: Mark raise_exception as noreturn
> target/microblaze: Remove helper_debug and env->debug
> target/microblaze: Rename env_* tcg variables to cpu_*
> target/microblaze: Tidy mb_tcg_init
> target/microblaze: Split out MSR[C] to its own variable
> target/microblaze: Use DISAS_NORETURN
> target/microblaze: Check singlestep_enabled in gen_goto_tb
> target/microblaze: Convert to DisasContextBase
> target/microblaze: Convert to translator_loop
> target/microblaze: Remove SIM_COMPAT
> target/microblaze: Remove DISAS_GNU
> target/microblaze: Remove empty D macros
> target/microblaze: Remove LOG_DIS
> target/microblaze: Ensure imm constant is always available
> target/microblaze: Add decodetree infrastructure
> target/microblaze: Convert dec_add to decodetree
> target/microblaze: Convert dec_sub to decodetree
> target/microblaze: Implement cmp and cmpu inline
> target/microblaze: Convert dec_pattern to decodetree
> target/microblaze: Convert dec_and, dec_or, dec_xor to decodetree
> target/microblaze: Convert dec_mul to decodetree
> target/microblaze: Convert dec_div to decodetree
> target/microblaze: Unwind properly when raising divide-by-zero
> target/microblaze: Convert dec_bit to decodetree
> target/microblaze: Convert dec_barrel to decodetree
> target/microblaze: Convert dec_imm to decodetree
> target/microblaze: Convert dec_fpu to decodetree
> target/microblaze: Fix cpu unwind for fpu exceptions
> target/microblaze: Mark fpu helpers TCG_CALL_NO_WG
> target/microblaze: Replace MSR_EE_FLAG with MSR_EE
> target/microblaze: Cache mem_index in DisasContext
> target/microblaze: Fix cpu unwind for stackprot
> target/microblaze: Convert dec_load and dec_store to decodetree
> target/microblaze: Assert no overlap in flags making up tb_flags
> target/microblaze: Move bimm to BIMM_FLAG
> target/microblaze: Fix no-op mb_cpu_transaction_failed
> target/microblaze: Store "current" iflags in insn_start
> tcg: Add tcg_get_insn_start_param
> target/microblaze: Use cc->do_unaligned_access
> target/microblaze: Replace clear_imm with tb_flags_to_set
> target/microblaze: Replace delayed_branch with tb_flags_to_set
> target/microblaze: Tidy mb_cpu_dump_state
> target/microblaze: Convert brk and brki to decodetree
> target/microblaze: Convert mbar to decodetree
> target/microblaze: Reorganize branching
> target/microblaze: Convert dec_br to decodetree
> target/microblaze: Convert dec_bcc to decodetree
> target/microblaze: Convert dec_rts to decodetree
> target/microblaze: Tidy do_rti, do_rtb, do_rte
> target/microblaze: Convert msrclr, msrset to decodetree
> target/microblaze: Convert dec_msr to decodetree
> target/microblaze: Convert dec_stream to decodetree
> target/microblaze: Remove last of old decoder
> target/microblaze: Remove cpu_R[0]
> target/microblaze: Add flags markup to some helpers
> target/microblaze: Reduce linux-user address space to 32-bit
>
> include/tcg/tcg.h | 15 +
> target/microblaze/cpu-param.h | 15 +
> target/microblaze/cpu.h | 67 +-
> target/microblaze/helper.h | 49 +-
> target/microblaze/microblaze-decode.h | 59 -
> tests/tcg/multiarch/float_helpers.h | 17 +
> target/microblaze/insns.decode | 256 ++
> linux-user/elfload.c | 9 +-
> linux-user/microblaze/cpu_loop.c | 26 +-
> linux-user/microblaze/signal.c | 8 +-
> target/microblaze/cpu.c | 9 +-
> target/microblaze/gdbstub.c | 193 +-
> target/microblaze/helper.c | 164 +-
> target/microblaze/mmu.c | 4 +-
> target/microblaze/op_helper.c | 194 +-
> target/microblaze/translate.c | 3223 +++++++++++++------------
> tests/tcg/multiarch/float_convs.c | 2 +
> tests/tcg/multiarch/float_madds.c | 2 +
> target/microblaze/meson.build | 3 +
> tests/tcg/configure.sh | 2 +-
> 20 files changed, 2292 insertions(+), 2025 deletions(-)
> delete mode 100644 target/microblaze/microblaze-decode.h
> create mode 100644 target/microblaze/insns.decode
>
> --
> 2.25.1
>
prev parent reply other threads:[~2020-08-31 14:15 UTC|newest]
Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-28 14:18 [PATCH v2 00/76] target/microblaze improvements Richard Henderson
2020-08-28 14:18 ` [PATCH v2 01/76] tests/tcg: Add microblaze to arches filter Richard Henderson
2020-08-31 17:32 ` Philippe Mathieu-Daudé
2020-08-28 14:18 ` [PATCH v2 02/76] tests/tcg: Do not require FE_TOWARDZERO Richard Henderson
2020-08-31 17:31 ` Philippe Mathieu-Daudé
2020-08-28 14:18 ` [PATCH v2 03/76] tests/tcg: Do not require FE_* exception bits Richard Henderson
2020-08-31 17:30 ` Philippe Mathieu-Daudé
2020-08-28 14:18 ` [PATCH v2 04/76] target/microblaze: Tidy gdbstub Richard Henderson
2020-08-28 14:18 ` [PATCH v2 05/76] target/microblaze: Split out PC from env->sregs Richard Henderson
2020-08-28 14:18 ` [PATCH v2 06/76] target/microblaze: Split out MSR " Richard Henderson
2020-08-28 14:18 ` [PATCH v2 07/76] target/microblaze: Split out EAR " Richard Henderson
2020-08-31 20:50 ` Philippe Mathieu-Daudé
2020-08-28 14:18 ` [PATCH v2 08/76] target/microblaze: Split out ESR " Richard Henderson
2020-08-28 14:18 ` [PATCH v2 09/76] target/microblaze: Split out FSR " Richard Henderson
2020-08-31 20:51 ` Philippe Mathieu-Daudé
2020-08-28 14:18 ` [PATCH v2 10/76] target/microblaze: Split out BTR " Richard Henderson
2020-08-31 20:53 ` Philippe Mathieu-Daudé
2020-08-28 14:18 ` [PATCH v2 11/76] target/microblaze: Split out EDR " Richard Henderson
2020-08-28 14:18 ` [PATCH v2 12/76] target/microblaze: Split the cpu_SR array Richard Henderson
2020-08-28 14:18 ` [PATCH v2 13/76] target/microblaze: Fix width of PC and BTARGET Richard Henderson
2020-08-28 14:18 ` [PATCH v2 14/76] target/microblaze: Fix width of MSR Richard Henderson
2020-08-28 14:18 ` [PATCH v2 15/76] target/microblaze: Fix width of ESR Richard Henderson
2020-08-28 14:18 ` [PATCH v2 16/76] target/microblaze: Fix width of FSR Richard Henderson
2020-08-28 14:18 ` [PATCH v2 17/76] target/microblaze: Fix width of BTR Richard Henderson
2020-08-28 14:18 ` [PATCH v2 18/76] target/microblaze: Fix width of EDR Richard Henderson
2020-08-28 14:18 ` [PATCH v2 19/76] target/microblaze: Remove cpu_ear Richard Henderson
2020-08-28 14:18 ` [PATCH v2 20/76] target/microblaze: Tidy raising of exceptions Richard Henderson
2020-08-28 14:18 ` [PATCH v2 21/76] target/microblaze: Mark raise_exception as noreturn Richard Henderson
2020-08-28 14:18 ` [PATCH v2 22/76] target/microblaze: Remove helper_debug and env->debug Richard Henderson
2020-08-28 14:18 ` [PATCH v2 23/76] target/microblaze: Rename env_* tcg variables to cpu_* Richard Henderson
2020-08-31 21:11 ` Philippe Mathieu-Daudé
2020-08-28 14:18 ` [PATCH v2 24/76] target/microblaze: Tidy mb_tcg_init Richard Henderson
2020-08-28 14:18 ` [PATCH v2 25/76] target/microblaze: Split out MSR[C] to its own variable Richard Henderson
2020-08-28 14:18 ` [PATCH v2 26/76] target/microblaze: Use DISAS_NORETURN Richard Henderson
2020-08-28 14:18 ` [PATCH v2 27/76] target/microblaze: Check singlestep_enabled in gen_goto_tb Richard Henderson
2020-08-31 13:54 ` Edgar E. Iglesias
2020-08-31 14:55 ` Richard Henderson
2020-08-28 14:18 ` [PATCH v2 28/76] target/microblaze: Convert to DisasContextBase Richard Henderson
2020-08-28 14:18 ` [PATCH v2 29/76] target/microblaze: Convert to translator_loop Richard Henderson
2020-08-28 14:18 ` [PATCH v2 30/76] target/microblaze: Remove SIM_COMPAT Richard Henderson
2020-08-28 14:18 ` [PATCH v2 31/76] target/microblaze: Remove DISAS_GNU Richard Henderson
2020-08-28 14:18 ` [PATCH v2 32/76] target/microblaze: Remove empty D macros Richard Henderson
2020-08-31 21:14 ` Philippe Mathieu-Daudé
2020-08-28 14:18 ` [PATCH v2 33/76] target/microblaze: Remove LOG_DIS Richard Henderson
2020-08-28 14:18 ` [PATCH v2 34/76] target/microblaze: Ensure imm constant is always available Richard Henderson
2020-08-28 14:18 ` [PATCH v2 35/76] target/microblaze: Add decodetree infrastructure Richard Henderson
2020-08-28 14:18 ` [PATCH v2 36/76] target/microblaze: Convert dec_add to decodetree Richard Henderson
2020-08-28 14:18 ` [PATCH v2 37/76] target/microblaze: Convert dec_sub " Richard Henderson
2020-08-28 14:18 ` [PATCH v2 38/76] target/microblaze: Implement cmp and cmpu inline Richard Henderson
2020-08-28 14:18 ` [PATCH v2 39/76] target/microblaze: Convert dec_pattern to decodetree Richard Henderson
2020-08-28 14:18 ` [PATCH v2 40/76] target/microblaze: Convert dec_and, dec_or, dec_xor " Richard Henderson
2020-08-28 14:18 ` [PATCH v2 41/76] target/microblaze: Convert dec_mul " Richard Henderson
2020-08-28 14:18 ` [PATCH v2 42/76] target/microblaze: Convert dec_div " Richard Henderson
2020-08-28 14:18 ` [PATCH v2 43/76] target/microblaze: Unwind properly when raising divide-by-zero Richard Henderson
2020-08-28 14:18 ` [PATCH v2 44/76] target/microblaze: Convert dec_bit to decodetree Richard Henderson
2020-08-28 14:18 ` [PATCH v2 45/76] target/microblaze: Convert dec_barrel " Richard Henderson
2020-08-28 14:18 ` [PATCH v2 46/76] target/microblaze: Convert dec_imm " Richard Henderson
2020-08-28 14:19 ` [PATCH v2 47/76] target/microblaze: Convert dec_fpu " Richard Henderson
2020-08-28 14:19 ` [PATCH v2 48/76] target/microblaze: Fix cpu unwind for fpu exceptions Richard Henderson
2020-08-28 14:19 ` [PATCH v2 49/76] target/microblaze: Mark fpu helpers TCG_CALL_NO_WG Richard Henderson
2020-08-28 14:19 ` [PATCH v2 50/76] target/microblaze: Replace MSR_EE_FLAG with MSR_EE Richard Henderson
2020-08-31 21:09 ` Philippe Mathieu-Daudé
2020-08-28 14:19 ` [PATCH v2 51/76] target/microblaze: Cache mem_index in DisasContext Richard Henderson
2020-08-28 14:19 ` [PATCH v2 52/76] target/microblaze: Fix cpu unwind for stackprot Richard Henderson
2020-08-28 14:19 ` [PATCH v2 53/76] target/microblaze: Convert dec_load and dec_store to decodetree Richard Henderson
2020-08-28 14:19 ` [PATCH v2 54/76] target/microblaze: Assert no overlap in flags making up tb_flags Richard Henderson
2020-08-28 14:19 ` [PATCH v2 55/76] target/microblaze: Move bimm to BIMM_FLAG Richard Henderson
2020-08-28 14:19 ` [PATCH v2 56/76] target/microblaze: Fix no-op mb_cpu_transaction_failed Richard Henderson
2020-08-28 14:19 ` [PATCH v2 57/76] target/microblaze: Store "current" iflags in insn_start Richard Henderson
2020-08-28 14:19 ` [PATCH v2 58/76] tcg: Add tcg_get_insn_start_param Richard Henderson
2020-08-28 14:19 ` [PATCH v2 59/76] target/microblaze: Use cc->do_unaligned_access Richard Henderson
2020-08-28 14:19 ` [PATCH v2 60/76] target/microblaze: Replace clear_imm with tb_flags_to_set Richard Henderson
2020-08-28 14:19 ` [PATCH v2 61/76] target/microblaze: Replace delayed_branch " Richard Henderson
2020-08-28 14:19 ` [PATCH v2 62/76] target/microblaze: Tidy mb_cpu_dump_state Richard Henderson
2020-08-31 21:08 ` Philippe Mathieu-Daudé
2020-08-31 22:16 ` Richard Henderson
2020-08-31 22:25 ` Philippe Mathieu-Daudé
2020-08-28 14:19 ` [PATCH v2 63/76] target/microblaze: Convert brk and brki to decodetree Richard Henderson
2020-08-28 14:19 ` [PATCH v2 64/76] target/microblaze: Convert mbar " Richard Henderson
2020-08-28 14:19 ` [PATCH v2 65/76] target/microblaze: Reorganize branching Richard Henderson
2020-08-28 14:19 ` [PATCH v2 66/76] target/microblaze: Convert dec_br to decodetree Richard Henderson
2020-08-28 14:19 ` [PATCH v2 67/76] target/microblaze: Convert dec_bcc " Richard Henderson
2020-08-28 14:19 ` [PATCH v2 68/76] target/microblaze: Convert dec_rts " Richard Henderson
2020-08-28 14:19 ` [PATCH v2 69/76] target/microblaze: Tidy do_rti, do_rtb, do_rte Richard Henderson
2020-08-28 14:19 ` [PATCH v2 70/76] target/microblaze: Convert msrclr, msrset to decodetree Richard Henderson
2020-08-28 14:19 ` [PATCH v2 71/76] target/microblaze: Convert dec_msr " Richard Henderson
2020-08-28 14:19 ` [PATCH v2 72/76] target/microblaze: Convert dec_stream " Richard Henderson
2020-08-28 14:19 ` [PATCH v2 73/76] target/microblaze: Remove last of old decoder Richard Henderson
2020-08-28 14:19 ` [PATCH v2 74/76] target/microblaze: Remove cpu_R[0] Richard Henderson
2020-08-28 14:19 ` [PATCH v2 75/76] target/microblaze: Add flags markup to some helpers Richard Henderson
2020-08-28 14:19 ` [PATCH v2 76/76] target/microblaze: Reduce linux-user address space to 32-bit Richard Henderson
2020-08-31 14:14 ` Edgar E. Iglesias [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200831141435.GD14249@toto \
--to=edgar.iglesias@xilinx.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.