From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F5C5C433E6 for ; Tue, 1 Sep 2020 07:59:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 472D920684 for ; Tue, 1 Sep 2020 07:59:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598947194; bh=xhIPGE3tId+2W3nS2hkbzS1Y2OIa+afFS63GDam/VRE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=PkNJUOJ9O6rp/nKTHEP8ecPgpUgyDg/eMRKzzKeTI84jwLMTnljp8vqRoObpzJWo6 7AurqViID9a9eFaIqtFeTG1/kBWEgIhSCgrpP+uv0wW6ErnXYjMlqpcUmu8ADTKvDN sPJvQNw70jlYC4oJJ53ZjQnNvKHIIoRUCQ1W25Xw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726124AbgIAH7n (ORCPT ); Tue, 1 Sep 2020 03:59:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41032 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726044AbgIAH7m (ORCPT ); Tue, 1 Sep 2020 03:59:42 -0400 Received: from mail-ed1-x543.google.com (mail-ed1-x543.google.com [IPv6:2a00:1450:4864:20::543]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6CF33C061244; Tue, 1 Sep 2020 00:59:42 -0700 (PDT) Received: by mail-ed1-x543.google.com with SMTP id q21so538352edv.1; Tue, 01 Sep 2020 00:59:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=1tUkMsxqX+EmvRrvz0z84bC2IgPMV2uqRkretCUGwiQ=; b=qkxZLlPRV+HvJ1qB5AZTMRDPW93Z/gzTs0x18/F1NW5XRe5b7fQSGM/dUk5AQ+7TY+ L+3oJiEQCjjswVwRkAz8MEGaDpWxIlfKhvbV9ByS3B9z0US62lCR1AXO9dN33RXqYtLI sWaSYa87lhOHVY3YpM/I8IWuhM1Wp+v18UI7NVByfcIETSsKma+jN6GunmH5vZMiq8xb 2XkoSC7T3ntj3r1ELFyVnvnThVv9kyg/H59v0XtjkvUao8wRKWBr/KZBYUpQ0UJHgbKJ pY1xbx9gralqUwLbXi1wyERRawpucmFuYlfp/6cgHsg2xDKgiOwg9X3rzhbVckmAIHcR 8Z2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=1tUkMsxqX+EmvRrvz0z84bC2IgPMV2uqRkretCUGwiQ=; b=BaSg72Ke5DnTW6obA0cNTSMX/z3a/m/p92s952Q2h2yFIed/ALKXxIMa9pXTpYmZGY 7jMd6A4GuWBTIHaRzW0lBbARHxxsy7C9pPVqhy9meAh1cWQtcQPRPLmoQR3QkK2a9Chh 1mIxEsQXf8p9woCdhpxLTcvpO72yc0IAFcN7Bteq9lYSN82KhRYZzGCknfdPL4O0LPTS WCgvAfKT+criMdPx9sNjxtj6e46hNiujQ+DqIPAuyxZNDa/rYU/n4QbBpn6GvSp3sJ/3 x1AeHpLhZbMv6pIYEd2Xb5LqaGIB7wzxA1bKzxxbRPg8epHNHxYKcWNRln+tnYLgxqiz YCtg== X-Gm-Message-State: AOAM530ty+EMbS8NMrPyvFqAlOLgw5gZ+vA/BbWVoNpvfTgJcKLbjJRE lmeKbyQ3PrOaE2n+PadyhBY= X-Google-Smtp-Source: ABdhPJzeDWymrCPJVQGGseKzqQGGkA79Su6T6BnnuBxUsnIU8yb3Ft7Lc0UMjmZqTp7y2AROzPerXQ== X-Received: by 2002:a50:8881:: with SMTP id d1mr689496edd.306.1598947180775; Tue, 01 Sep 2020 00:59:40 -0700 (PDT) Received: from gmail.com (54033286.catv.pool.telekom.hu. [84.3.50.134]) by smtp.gmail.com with ESMTPSA id qu11sm511021ejb.15.2020.09.01.00.59.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Sep 2020 00:59:40 -0700 (PDT) Date: Tue, 1 Sep 2020 09:59:37 +0200 From: Ingo Molnar To: Kees Cook Cc: Borislav Petkov , Catalin Marinas , Mark Rutland , Ard Biesheuvel , Peter Collingbourne , James Morse , Ingo Molnar , Russell King , Masahiro Yamada , Arvind Sankar , Nick Desaulniers , Nathan Chancellor , Arnd Bergmann , x86@kernel.org, clang-built-linux@googlegroups.com, linux-arch@vger.kernel.org, linux-efi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 00/29] Warn on orphan section placement Message-ID: <20200901075937.GA3602433@gmail.com> References: <20200821194310.3089815-1-keescook@chromium.org> <202008311240.9F94A39@keescook> <20200901071133.GA3577996@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200901071133.GA3577996@gmail.com> Sender: linux-arch-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arch@vger.kernel.org * Ingo Molnar wrote: > > * Kees Cook wrote: > > > On Fri, Aug 21, 2020 at 12:42:41PM -0700, Kees Cook wrote: > > > Hi Ingo, > > > > > > Based on my testing, this is ready to go. I've reviewed the feedback on > > > v5 and made a few small changes, noted below. > > > > If no one objects, I'll pop this into my tree for -next. I'd prefer it > > go via -tip though! :) > > > > Thanks! > > I'll pick it up today, it all looks very good now! One thing I found in testing is that it doesn't handler older LD versions well enough: ld: unrecognized option '--orphan-handling=warn' Could we just detect the availability of this flag, and emit a warning if it doesn't exist but otherwise not abort the build? This is with: GNU ld version 2.25-17.fc23 Thanks, Ingo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,FSL_HELO_FAKE,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98637C433E6 for ; Tue, 1 Sep 2020 08:01:32 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1CE542065F for ; Tue, 1 Sep 2020 08:01:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="hm5SMCdi"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qkxZLlPR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1CE542065F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=L+n0KWi4RB0GOBQVfBauAd7VGoMR6hGiihaIbpz/lqA=; b=hm5SMCdiJEFhqg5qv4aT0Z+8i EV8rFjEu9vniOUdC6x4NZ/6WRcPDaITIGrRq4ervcz4U3dugG3FRt2fdd3YjG/44pJyloytaMH7vm 2bb1Ydvh02VVYWdYxpZDFn3KFhlFIgFaJ4ijtI2y0zxr6yx1vosulW8cq1YQuqYMXlqLPvxQHX6mh YLky0Iho9xhTsJwxhBNKlPzvFGWTE7AgYpY3CLtaoOBKabQOfG6/wY1tZIptZsHIPlTV0vUl2gne9 iC3z/6J3/VMij0HQKIPT+/GneVJ56rX6xGDPFUUZQXOC9Km0qPVZHXVd+UKqXQalzzDh+L1KV0ZA5 gCalUuUAA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kD1Cl-0001B1-Ng; Tue, 01 Sep 2020 07:59:47 +0000 Received: from mail-ed1-x542.google.com ([2a00:1450:4864:20::542]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kD1Cg-00018l-6v for linux-arm-kernel@lists.infradead.org; Tue, 01 Sep 2020 07:59:43 +0000 Received: by mail-ed1-x542.google.com with SMTP id n13so517877edo.10 for ; Tue, 01 Sep 2020 00:59:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=1tUkMsxqX+EmvRrvz0z84bC2IgPMV2uqRkretCUGwiQ=; b=qkxZLlPRV+HvJ1qB5AZTMRDPW93Z/gzTs0x18/F1NW5XRe5b7fQSGM/dUk5AQ+7TY+ L+3oJiEQCjjswVwRkAz8MEGaDpWxIlfKhvbV9ByS3B9z0US62lCR1AXO9dN33RXqYtLI sWaSYa87lhOHVY3YpM/I8IWuhM1Wp+v18UI7NVByfcIETSsKma+jN6GunmH5vZMiq8xb 2XkoSC7T3ntj3r1ELFyVnvnThVv9kyg/H59v0XtjkvUao8wRKWBr/KZBYUpQ0UJHgbKJ pY1xbx9gralqUwLbXi1wyERRawpucmFuYlfp/6cgHsg2xDKgiOwg9X3rzhbVckmAIHcR 8Z2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=1tUkMsxqX+EmvRrvz0z84bC2IgPMV2uqRkretCUGwiQ=; b=O7COihQ235HePlGNPPvFMavT+YJ72wwDPTEGGKA7DMm5SWNCg2GEK6+KCFmsMqmUoI zsmcB3jXjxF8PCyQCJvlPQrSWJkNM5OdgziRqF6cuqrvP9ruhR6PEGaIckJN2uNKS061 NTa3AWj1hoj/P+4i0BS22QTiRg9pbsJVaEUlB9oL02SY6k730uttR3LSilklWdizJYqi 8S4pz5sju14pk10BK4IsvI1f/V8/Sl/P2h7a6KNcXUuQodKwAOED9rMZ+ljntW/yDL4i 38rniEl77VUc829peWroQKFbxtINqNxYMv/+jte+mYMnRUFv1W4yngUHc5JxNlWHsBzy 4kig== X-Gm-Message-State: AOAM533zyaA8wx3zlxh8rLZgTiyR66FRX4zEDwomzFifbabYlkWr/4u3 ADsVAi382PgKOp/paWcJyRk= X-Google-Smtp-Source: ABdhPJzeDWymrCPJVQGGseKzqQGGkA79Su6T6BnnuBxUsnIU8yb3Ft7Lc0UMjmZqTp7y2AROzPerXQ== X-Received: by 2002:a50:8881:: with SMTP id d1mr689496edd.306.1598947180775; Tue, 01 Sep 2020 00:59:40 -0700 (PDT) Received: from gmail.com (54033286.catv.pool.telekom.hu. [84.3.50.134]) by smtp.gmail.com with ESMTPSA id qu11sm511021ejb.15.2020.09.01.00.59.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Sep 2020 00:59:40 -0700 (PDT) Date: Tue, 1 Sep 2020 09:59:37 +0200 From: Ingo Molnar To: Kees Cook Subject: Re: [PATCH v6 00/29] Warn on orphan section placement Message-ID: <20200901075937.GA3602433@gmail.com> References: <20200821194310.3089815-1-keescook@chromium.org> <202008311240.9F94A39@keescook> <20200901071133.GA3577996@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200901071133.GA3577996@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200901_035942_292656_4F0AF7F5 X-CRM114-Status: GOOD ( 17.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , linux-arch@vger.kernel.org, linux-efi@vger.kernel.org, Arnd Bergmann , Catalin Marinas , Masahiro Yamada , x86@kernel.org, Nick Desaulniers , Russell King , linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, Arvind Sankar , Ingo Molnar , James Morse , Nathan Chancellor , Borislav Petkov , Peter Collingbourne , Ard Biesheuvel , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Ingo Molnar wrote: > > * Kees Cook wrote: > > > On Fri, Aug 21, 2020 at 12:42:41PM -0700, Kees Cook wrote: > > > Hi Ingo, > > > > > > Based on my testing, this is ready to go. I've reviewed the feedback on > > > v5 and made a few small changes, noted below. > > > > If no one objects, I'll pop this into my tree for -next. I'd prefer it > > go via -tip though! :) > > > > Thanks! > > I'll pick it up today, it all looks very good now! One thing I found in testing is that it doesn't handler older LD versions well enough: ld: unrecognized option '--orphan-handling=warn' Could we just detect the availability of this flag, and emit a warning if it doesn't exist but otherwise not abort the build? This is with: GNU ld version 2.25-17.fc23 Thanks, Ingo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel