From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============4734695943285567816==" MIME-Version: 1.0 From: kernel test robot Subject: [PATCH] coccinelle: api: fix kobj_to_dev.cocci warnings Date: Tue, 01 Sep 2020 17:46:14 +0800 Message-ID: <20200901094614.GA29678@e18970f1e570> In-Reply-To: <202009011711.D4mNHDQW%lkp@intel.com> List-Id: To: kbuild@lists.01.org --===============4734695943285567816== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable CC: kbuild-all(a)lists.01.org TO: Denis Efremov CC: Julia Lawall CC: Pavel Machek CC: Dan Murphy CC: linux-leds(a)vger.kernel.org CC: linux-kernel(a)vger.kernel.org From: kernel test robot drivers/leds/trigger/ledtrig-pattern.c:336:60-61: WARNING opportunity for k= obj_to_dev() Use kobj_to_dev() instead of container_of() Generated by: scripts/coccinelle/api/kobj_to_dev.cocci Fixes: a2fc3718bc22 ("coccinelle: api: add kobj_to_dev.cocci script") CC: Denis Efremov Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/jlawall/linux.git f= or-5.10 head: ea3047aac79bc12dfda32fd676d6d1b2a6e5475d commit: a2fc3718bc22e85378085568ecc5765fb28cabce [3/4] coccinelle: api: add= kobj_to_dev.cocci script :::::: branch date: 3 days ago :::::: commit date: 11 days ago Please take the patch only if it's a positive warning. Thanks! ledtrig-pattern.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/leds/trigger/ledtrig-pattern.c +++ b/drivers/leds/trigger/ledtrig-pattern.c @@ -333,7 +333,7 @@ static DEVICE_ATTR_RW(hw_pattern); static umode_t pattern_trig_attrs_mode(struct kobject *kobj, struct attribute *attr, int index) { - struct device *dev =3D container_of(kobj, struct device, kobj); + struct device *dev =3D kobj_to_dev(kobj); struct led_classdev *led_cdev =3D dev_get_drvdata(dev); = if (attr =3D=3D &dev_attr_repeat.attr || attr =3D=3D &dev_attr_pattern.at= tr) --===============4734695943285567816==--