From: Borislav Petkov <bp@alien8.de>
To: Dinghao Liu <dinghao.liu@zju.edu.cn>
Cc: kjlu@umn.edu, "Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Tony Luck" <tony.luck@intel.com>,
"James Morse" <james.morse@arm.com>,
"Robert Richter" <rrichter@marvell.com>,
"Niklas Söderlund" <niklas.soderlund@ericsson.com>,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] EDAC: i5100_edac: Fix error handling code in i5100_init_one
Date: Tue, 1 Sep 2020 12:13:45 +0200 [thread overview]
Message-ID: <20200901101345.GA8392@zn.tnic> (raw)
In-Reply-To: <20200826121437.31606-1-dinghao.liu@zju.edu.cn>
On Wed, Aug 26, 2020 at 08:14:37PM +0800, Dinghao Liu wrote:
> When pci_get_device_func() fails, we don't need to execute
> pci_dev_put(). But mci should be freed to prevent memleak.
> When pci_enable_device() fails, we don't need to disable
> einj either.
>
> Fixes: 52608ba205461 ("i5100_edac: probe for device 19 function 0")
> Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
> ---
> drivers/edac/i5100_edac.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
Applied, thanks.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
prev parent reply other threads:[~2020-09-01 10:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-26 12:14 [PATCH] EDAC: i5100_edac: Fix error handling code in i5100_init_one Dinghao Liu
2020-09-01 10:13 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200901101345.GA8392@zn.tnic \
--to=bp@alien8.de \
--cc=dinghao.liu@zju.edu.cn \
--cc=james.morse@arm.com \
--cc=kjlu@umn.edu \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=niklas.soderlund@ericsson.com \
--cc=rrichter@marvell.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.