From: Catalin Marinas <catalin.marinas@arm.com>
To: Marc Zyngier <maz@kernel.org>
Cc: Andre Przywara <andre.przywara@arm.com>,
stable@vger.kernel.org, James Morse <james.morse@arm.com>
Subject: Re: [PATCH stable v5.4 1/3] KVM: arm64: Add kvm_extable for vaxoricism code
Date: Tue, 1 Sep 2020 12:16:42 +0100 [thread overview]
Message-ID: <20200901111642.GI5561@gaia> (raw)
In-Reply-To: <79d6944d383945608b685a2d0f9d9b2c@kernel.org>
On Tue, Sep 01, 2020 at 12:12:57PM +0100, Marc Zyngier wrote:
> On 2020-09-01 10:49, Andre Przywara wrote:
> > From: James Morse <james.morse@arm.com>
> >
> > commit e9ee186bb735bfc17fa81dbc9aebf268aee5b41e upstream.
> >
> > KVM has a one instruction window where it will allow an SError exception
> > to be consumed by the hypervisor without treating it as a hypervisor
> > bug.
> > This is used to consume asynchronous external abort that were caused by
> > the guest.
> >
> > As we are about to add another location that survives unexpected
> > exceptions,
> > generalise this code to make it behave like the host's extable.
> >
> > KVM's version has to be mapped to EL2 to be accessible on nVHE systems.
> >
> > The SError vaxorcism code is a one instruction window, so has two
> > entries
> > in the extable. Because the KVM code is copied for VHE and nVHE, we end
> > up
> > with four entries, half of which correspond with code that isn't mapped.
> >
> > Cc: <stable@vger.kernel.org> # 5.4.x
> > Cc: Marc Zyngier <maz@kernel.org>
> > Signed-off-by: James Morse <james.morse@arm.com>
> > Signed-off-by: Andre Przywara <andre.przywara@arm.com>
>
> Can you make sure these patches do carry the sign-off chain as we have
> in mainline? In particular, this is missing:
>
> Reviewed-by: Marc Zyngier <maz@kernel.org>
> Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
>
> You can add your own SoB after this.
Good point. James prepared the backports before we merged the patches
into mainline.
BTW, I also corrected a subject typo: s/vaxoricism/vaxorcism/ (not that
this is a real word ;)).
--
Catalin
next prev parent reply other threads:[~2020-09-01 11:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 9:49 [PATCH stable v5.4 0/3] KVM: arm64: Fix AT instruction handling Andre Przywara
2020-09-01 9:49 ` [PATCH stable v5.4 1/3] KVM: arm64: Add kvm_extable for vaxoricism code Andre Przywara
2020-09-01 11:12 ` Marc Zyngier
2020-09-01 11:16 ` Catalin Marinas [this message]
2020-09-01 11:17 ` André Przywara
2020-09-01 11:54 ` Marc Zyngier
2020-09-01 15:03 ` Greg KH
2020-09-01 9:49 ` [PATCH stable v5.4 2/3] KVM: arm64: Survive synchronous exceptions caused by AT instructions Andre Przywara
2020-09-01 9:49 ` [PATCH stable v5.4 3/3] KVM: arm64: Set HCR_EL2.PTW to prevent AT taking synchronous exception Andre Przywara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200901111642.GI5561@gaia \
--to=catalin.marinas@arm.com \
--cc=andre.przywara@arm.com \
--cc=james.morse@arm.com \
--cc=maz@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.