From: Gary Bisson <gary.bisson@boundarydevices.com>
To: u-boot@lists.denx.de
Subject: [PATCH v2] fastboot: getvar: fix partition-size return value
Date: Tue, 1 Sep 2020 14:51:45 +0200 [thread overview]
Message-ID: <20200901125145.GA76077@p1g2> (raw)
In-Reply-To: <CAPLW+4=KTYAaTbXEkuc0gTTsumBGaiCvog+W-6yjcaRsaniBhg@mail.gmail.com>
Hi Sam,
On Tue, Sep 01, 2020 at 01:31:46PM +0300, Sam Protsenko wrote:
> Hi Gary,
>
> On Thu, 27 Aug 2020 at 11:51, Gary Bisson
> <gary.bisson@boundarydevices.com> wrote:
> >
> > The size returned by 'getvar partition-size' should be in bytes, not in
> > blocks as fastboot uses that value to generate empty partition when
> > running format [1].
> >
> > Note that the function was already returning the proper size in bytes
> > for NAND devices (see struct part_info details).
> >
> > [1]
> > https://android.googlesource.com/platform/system/core/+/refs/heads/android10-release/fastboot/fastboot.cpp#1500
> >
> > Signed-off-by: Gary Bisson <gary.bisson@boundarydevices.com>
> > ---
>
> Thank you for the patch, all look good! As I understand from the
> changelog, v2 fixes sunxi build error found by Lukasz?
Indeed it does. The part_info struct for NAND devices was already
returning a size in bytes instead of blocks.
> Other than that:
>
> Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>
Thanks,
Gary
prev parent reply other threads:[~2020-09-01 12:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-27 8:51 [PATCH v2] fastboot: getvar: fix partition-size return value Gary Bisson
2020-09-01 10:31 ` Sam Protsenko
2020-09-01 12:51 ` Gary Bisson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200901125145.GA76077@p1g2 \
--to=gary.bisson@boundarydevices.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.