From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Al Grant <al.grant@foss.arm.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>,
Andi Kleen <ak@linux.intel.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf: correct SNOOPX field offset
Date: Tue, 1 Sep 2020 12:02:25 -0300 [thread overview]
Message-ID: <20200901150225.GA1424523@kernel.org> (raw)
In-Reply-To: <d68e68f5-a7c3-c276-6134-a68f068a2b80@foss.arm.com>
Em Wed, Aug 26, 2020 at 03:33:35PM +0100, Al Grant escreveu:
> On 26/08/2020 15:26, Arnaldo Carvalho de Melo wrote:
> > Em Tue, Aug 25, 2020 at 10:40:43AM -0700, Andi Kleen escreveu:
> > > On Mon, Aug 24, 2020 at 10:28:34AM +0100, Al Grant wrote:
> > > > perf_event.h has macros that define the field offsets in the
> > > > data_src bitmask in perf records. The SNOOPX and REMOTE offsets
> > > > were both 37. These are distinct fields, and the bitfield layout
> > > > in perf_mem_data_src confirms that SNOOPX should be at offset 38.
> > >
> > > Looks good.
> > >
> > > Reviewed-by: Andi Kleen <ak@linux.intel.com>
> > >
> > > Probably should have a Fixes: header
> >
> > Please do so, find the patch that introduced the error, add the Fixes
> > tag, will help me not having to do it myself :-)
>
> Fixes: 52839e653b562 ("perf tools: Add support for printing new mem_info
> encodings")
Ok, I'll add that, thanks.
But you forgot to add your Signed-off-by:, can you please provide it?
There was also a minor problem in the patch, there was no separation of
--- from the patch comment section to the patch itself, I'll fix that as
well.
- Arnaldo
next prev parent reply other threads:[~2020-09-01 15:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-24 9:28 [PATCH] perf: correct SNOOPX field offset Al Grant
2020-08-25 17:40 ` Andi Kleen
2020-08-26 14:26 ` Arnaldo Carvalho de Melo
2020-08-26 14:33 ` Al Grant
2020-09-01 15:02 ` Arnaldo Carvalho de Melo [this message]
2020-09-01 15:05 ` Al Grant
2020-09-01 15:06 ` Arnaldo Carvalho de Melo
2020-09-01 15:12 ` peterz
2020-09-01 15:58 ` Arnaldo Carvalho de Melo
2020-09-01 17:34 ` Peter Zijlstra
2020-08-26 11:24 ` Mark Rutland
-- strict thread matches above, loose matches on Subject: below --
2020-09-21 20:46 Al Grant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200901150225.GA1424523@kernel.org \
--to=acme@kernel.org \
--cc=acme@redhat.com \
--cc=ak@linux.intel.com \
--cc=al.grant@foss.arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.