From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FAAAC433E7 for ; Tue, 1 Sep 2020 15:51:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1EAC52078B for ; Tue, 1 Sep 2020 15:51:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="3NjA7NmE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728988AbgIAPvC (ORCPT ); Tue, 1 Sep 2020 11:51:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57324 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727114AbgIAPu1 (ORCPT ); Tue, 1 Sep 2020 11:50:27 -0400 Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D6356C061247; Tue, 1 Sep 2020 08:50:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=tHPi+SjkOF6w9APKcpbiTQrV0DyQaBz6SgJbSF6lXMk=; b=3NjA7NmECoivZ7oLm1KxCRgUdI gcm8mw9F1Z8G3GoMzLr1uhEe84sAtLIki46X+4JpIaR7wmlZB8eyeWkPscMyUauxVt2QhcldUDJhu N7Bv7E8wgOmUSrXr561FZuMQhOw6QWKNQRgQtDqbWInsG1Pe2tUPw5tDx3n7GugRm7rfQNcN70TkM bMaZ5J4hqMKSrjKSjP7eJgvWSnmHBM2IETGWnLmyF/pgz6fBOjDKT9BJJw4oP3lgyzK8THMYh6bTX svOA2UkXDiIopjcIIfQ1h1rvsR74sGInfUraA3hmPzVvFT2nqTYtD+EDxH6ZUswkP5IYdTAr02s8E hmIvzZCQ==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1kD8Y4-0001I2-Tt; Tue, 01 Sep 2020 15:50:17 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 2A878307936; Tue, 1 Sep 2020 17:50:15 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 03B3220D7C0E3; Tue, 1 Sep 2020 17:50:14 +0200 (CEST) Date: Tue, 1 Sep 2020 17:50:14 +0200 From: peterz@infradead.org To: Lina Iyer Cc: Ulf Hansson , Naresh Kamboju , paulmck@kernel.org, "Rafael J. Wysocki" , Saravana Kannan , open list , linux-mmc , lkft-triage@lists.linaro.org, rcu@vger.kernel.org, Linux PM , Anders Roxell , Arnd Bergmann , Rajendra Nayak , John Stultz , Stephen Boyd , Lars Povlsen , madhuparnabhowmik10@gmail.com, Viresh Kumar , Vincent Guittot , Thomas Gleixner Subject: Re: WARNING: suspicious RCU usage - sdhci-pltfm: SDHCI platform and OF driver helper Message-ID: <20200901155014.GF2674@hirez.programming.kicks-ass.net> References: <20200831194402.GD2855@paulmck-ThinkPad-P72> <20200901104206.GU1362448@hirez.programming.kicks-ass.net> <20200901154417.GD20303@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200901154417.GD20303@codeaurora.org> Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org On Tue, Sep 01, 2020 at 09:44:17AM -0600, Lina Iyer wrote: > > > > > > I could add RCU_NONIDLE for the calls to pm_runtime_put_sync_suspend() > > > > > > and pm_runtime_get_sync() in psci_enter_domain_idle_state(). Perhaps > > > > > > that's the easiest approach, at least to start with. > I think this would be nice. This should also cover the case, where PM domain > power off notification callbacks call trace function internally. Right? That's just more crap for me to clean up later :-( trace_*_rcuidle() and RCU_NONIDLE() need to die, not proliferate.