All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: [omap-audio:peter/linux-next-wip 24/71] sound/soc/codecs/tas2555.c:641:6: warning: Variable 'ret' is reassigned a value before the old one has been used.
Date: Tue, 01 Sep 2020 17:05:36 +0800	[thread overview]
Message-ID: <202009011732.d75Lf5PG%lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 4111 bytes --]

CC: kbuild-all(a)lists.01.org
TO: Peter Ujfalusi <peter.ujfalusi@ti.com>

tree:   https://github.com/omap-audio/linux-audio peter/linux-next-wip
head:   5dbbfd0560518c2de57856803de7b00c5d87b374
commit: a919ef20b36c709f706bf530c5a0afe8eada1304 [24/71] ASoC: Initial driver for TAS2555 Smart Amplifier
:::::: branch date: 3 hours ago
:::::: commit date: 3 hours ago
config: mips-randconfig-p002-20200901 (attached as .config)
compiler: mips-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout a919ef20b36c709f706bf530c5a0afe8eada1304
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   mips-linux-ld: drivers/mmc/host/mtk-sd.o: in function `msdc_set_mclk':
>> drivers/mmc/host/mtk-sd.c:(.text.msdc_set_mclk+0x338): undefined reference to `clk_get_parent'
>> mips-linux-ld: drivers/mmc/host/mtk-sd.c:(.text.msdc_set_mclk+0x448): undefined reference to `clk_get_parent'

cppcheck warnings: (new ones prefixed by >>)

>> sound/soc/codecs/tas2555.c:641:6: warning: Variable 'ret' is reassigned a value before the old one has been used. [redundantAssignment]
    ret = regmap_read(tas2555->regmap, TAS2555_BOOKCTL_REG,
        ^
   sound/soc/codecs/tas2555.c:636:6: note: Variable 'ret' is reassigned a value before the old one has been used.
    ret = regulator_bulk_enable(ARRAY_SIZE(tas2555->supplies),
        ^
   sound/soc/codecs/tas2555.c:641:6: note: Variable 'ret' is reassigned a value before the old one has been used.
    ret = regmap_read(tas2555->regmap, TAS2555_BOOKCTL_REG,
        ^

# https://github.com/omap-audio/linux-audio/commit/a919ef20b36c709f706bf530c5a0afe8eada1304
git remote add omap-audio https://github.com/omap-audio/linux-audio
git fetch --no-tags omap-audio peter/linux-next-wip
git checkout a919ef20b36c709f706bf530c5a0afe8eada1304
vim +/ret +641 sound/soc/codecs/tas2555.c

a919ef20b36c70 Peter Ujfalusi 2015-05-08  628  
a919ef20b36c70 Peter Ujfalusi 2015-05-08  629  static int tas2555_codec_probe(struct snd_soc_component *component)
a919ef20b36c70 Peter Ujfalusi 2015-05-08  630  {
a919ef20b36c70 Peter Ujfalusi 2015-05-08  631  	struct tas2555_priv *tas2555 = snd_soc_component_get_drvdata(component);
a919ef20b36c70 Peter Ujfalusi 2015-05-08  632  	int ret;
a919ef20b36c70 Peter Ujfalusi 2015-05-08  633  
a919ef20b36c70 Peter Ujfalusi 2015-05-08  634  	tas2555->component = component;
a919ef20b36c70 Peter Ujfalusi 2015-05-08  635  
a919ef20b36c70 Peter Ujfalusi 2015-05-08  636  	ret = regulator_bulk_enable(ARRAY_SIZE(tas2555->supplies),
a919ef20b36c70 Peter Ujfalusi 2015-05-08  637  				    tas2555->supplies);
a919ef20b36c70 Peter Ujfalusi 2015-05-08  638  
a919ef20b36c70 Peter Ujfalusi 2015-05-08  639  	gpiod_set_value(tas2555->nreset, 1);
a919ef20b36c70 Peter Ujfalusi 2015-05-08  640  
a919ef20b36c70 Peter Ujfalusi 2015-05-08 @641  	ret = regmap_read(tas2555->regmap, TAS2555_BOOKCTL_REG,
a919ef20b36c70 Peter Ujfalusi 2015-05-08  642  			  &tas2555->current_book);
a919ef20b36c70 Peter Ujfalusi 2015-05-08  643  	if (ret < 0)
a919ef20b36c70 Peter Ujfalusi 2015-05-08  644  		tas2555->current_book = 0;
a919ef20b36c70 Peter Ujfalusi 2015-05-08  645  
a919ef20b36c70 Peter Ujfalusi 2015-05-08  646  	dev_info(component->dev, "TAS2555 PGID: 0x%02x\n",
a919ef20b36c70 Peter Ujfalusi 2015-05-08  647  		 tas2555_read(component, TAS2555_REV_PGID_REG));
a919ef20b36c70 Peter Ujfalusi 2015-05-08  648  
a919ef20b36c70 Peter Ujfalusi 2015-05-08  649  	return tas2555_init(component);
a919ef20b36c70 Peter Ujfalusi 2015-05-08  650  }
a919ef20b36c70 Peter Ujfalusi 2015-05-08  651  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 27715 bytes --]

             reply	other threads:[~2020-09-01  9:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-01  9:05 kernel test robot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2020-09-01  9:42 [omap-audio:peter/linux-next-wip 24/71] sound/soc/codecs/tas2555.c:641:6: warning: Variable 'ret' is reassigned a value before the old one has been used Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202009011732.d75Lf5PG%lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.