From: Peter Zijlstra <peterz@infradead.org>
To: "Paul E. McKenney" <paulmck@kernel.org>
Cc: Lina Iyer <ilina@codeaurora.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Naresh Kamboju <naresh.kamboju@linaro.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Saravana Kannan <saravanak@google.com>,
open list <linux-kernel@vger.kernel.org>,
linux-mmc <linux-mmc@vger.kernel.org>,
lkft-triage@lists.linaro.org, rcu@vger.kernel.org,
Linux PM <linux-pm@vger.kernel.org>,
Anders Roxell <anders.roxell@linaro.org>,
Arnd Bergmann <arnd@arndb.de>,
Rajendra Nayak <rnayak@codeaurora.org>,
John Stultz <john.stultz@linaro.org>,
Stephen Boyd <sboyd@kernel.org>,
Lars Povlsen <lars.povlsen@microchip.com>,
madhuparnabhowmik10@gmail.com,
Viresh Kumar <viresh.kumar@linaro.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: WARNING: suspicious RCU usage - sdhci-pltfm: SDHCI platform and OF driver helper
Date: Tue, 1 Sep 2020 19:42:16 +0200 [thread overview]
Message-ID: <20200901174216.GJ29142@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <20200901161340.GC29330@paulmck-ThinkPad-P72>
On Tue, Sep 01, 2020 at 09:13:40AM -0700, Paul E. McKenney wrote:
> On Tue, Sep 01, 2020 at 05:50:14PM +0200, peterz@infradead.org wrote:
> > On Tue, Sep 01, 2020 at 09:44:17AM -0600, Lina Iyer wrote:
> > > > > > > > I could add RCU_NONIDLE for the calls to pm_runtime_put_sync_suspend()
> > > > > > > > and pm_runtime_get_sync() in psci_enter_domain_idle_state(). Perhaps
> > > > > > > > that's the easiest approach, at least to start with.
> >
> > > I think this would be nice. This should also cover the case, where PM domain
> > > power off notification callbacks call trace function internally. Right?
> >
> > That's just more crap for me to clean up later :-(
> >
> > trace_*_rcuidle() and RCU_NONIDLE() need to die, not proliferate.
>
> Moving the idle-entry boundary further in is good in any number of ways.
> But experience indicates that no matter how far you move it, there will
> be something complex further in. Unless you are pushing it all the way
> into all the arch-specific code down as far as it can possibly go?
Not all; the simple cpuidle drivers should be good already. The more
complicated ones need some help.
The patch provided earlier:
https://lkml.kernel.org/r/20200901104206.GU1362448@hirez.programming.kicks-ass.net
should allow the complicated drivers to take over and DTRT.
next prev parent reply other threads:[~2020-09-01 17:42 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-31 6:32 WARNING: suspicious RCU usage - sdhci-pltfm: SDHCI platform and OF driver helper Naresh Kamboju
2020-08-31 19:44 ` Paul E. McKenney
2020-09-01 6:46 ` Ulf Hansson
2020-09-01 6:50 ` Ulf Hansson
2020-09-01 10:42 ` peterz
2020-09-01 12:35 ` Ulf Hansson
2020-09-01 12:40 ` Ulf Hansson
2020-09-01 15:44 ` Lina Iyer
2020-09-01 15:50 ` peterz
2020-09-01 16:13 ` Paul E. McKenney
2020-09-01 17:42 ` Peter Zijlstra [this message]
2020-09-02 7:03 ` Ulf Hansson
2020-09-02 12:13 ` peterz
2020-09-02 15:58 ` Ulf Hansson
2020-09-03 13:53 ` [RFC][PATCH] cpu_pm: Remove RCU abuse peterz
2020-09-03 14:36 ` Ulf Hansson
2020-09-03 15:08 ` peterz
2020-09-03 15:35 ` Paul E. McKenney
2020-09-04 6:08 ` Ulf Hansson
2020-09-01 15:00 ` WARNING: suspicious RCU usage - sdhci-pltfm: SDHCI platform and OF driver helper peterz
2020-09-01 15:00 ` Paul E. McKenney
2020-09-02 6:49 ` Ulf Hansson
2020-09-02 13:52 ` Paul E. McKenney
2020-09-02 16:07 ` Ulf Hansson
2020-09-02 17:01 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200901174216.GJ29142@worktop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=anders.roxell@linaro.org \
--cc=arnd@arndb.de \
--cc=ilina@codeaurora.org \
--cc=john.stultz@linaro.org \
--cc=lars.povlsen@microchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lkft-triage@lists.linaro.org \
--cc=madhuparnabhowmik10@gmail.com \
--cc=naresh.kamboju@linaro.org \
--cc=paulmck@kernel.org \
--cc=rcu@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=rnayak@codeaurora.org \
--cc=saravanak@google.com \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
--cc=ulf.hansson@linaro.org \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.