From: Stephen Hemminger <stephen@networkplumber.org>
To: David Marchand <david.marchand@redhat.com>
Cc: Ray Kinsella <mdr@ashroe.eu>, Neil Horman <nhorman@tuxdriver.com>,
John McNamara <john.mcnamara@intel.com>,
Marko Kovacevic <marko.kovacevic@intel.com>, dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] rte_log: make rte_logs private
Date: Wed, 2 Sep 2020 07:49:10 -0700 [thread overview]
Message-ID: <20200902074910.04c68631@hermes.lan> (raw)
In-Reply-To: <CAJFAV8xXf7fXcKA4ba6dScu=2K5uuGxZebYQWA53LboTTgUmMQ@mail.gmail.com>
On Wed, 2 Sep 2020 10:40:19 +0200
David Marchand <david.marchand@redhat.com> wrote:
> On Fri, Aug 28, 2020 at 12:54 AM Stephen Hemminger
> <stephen@networkplumber.org> wrote:
> >
> > As announced in earlier releases, rte_logs can now be made
> > internal to eal_common_log.
>
> I had prepared this cleanup before my PTO and was about to send it.
> Just to avoid duplicate work, do you intend to work on other cleanups ?
>
>
> Hiding this symbol is fine, but we must remove the experimental tag on
> rte_log_get_stream since it becomes the only way to access the log
> stream.
>
> More comments below.
> Thanks.
No intention on doing other cleanups, just saw this while implementing
a log stream provider.
Agree, the rte_log_get_stream() can be permanent API now.
next prev parent reply other threads:[~2020-09-02 14:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-27 22:54 [dpdk-dev] [PATCH] rte_log: make rte_logs private Stephen Hemminger
2020-08-29 12:41 ` Andrew Rybchenko
2020-09-02 8:40 ` David Marchand
2020-09-02 14:49 ` Stephen Hemminger [this message]
2020-09-03 23:04 ` [dpdk-dev] [PATCH v2 0/2] rte_log: make internal structures private Stephen Hemminger
2020-09-03 23:04 ` [dpdk-dev] [PATCH v2 1/2] rte_log: take experimental tag off of rte_log_get_stream Stephen Hemminger
2020-09-14 8:12 ` David Marchand
2020-09-03 23:04 ` [dpdk-dev] [PATCH v2 2/2] rte_log: make rte_logs private Stephen Hemminger
2020-09-14 8:13 ` David Marchand
2020-09-14 16:37 ` Stephen Hemminger
2020-09-16 16:36 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200902074910.04c68631@hermes.lan \
--to=stephen@networkplumber.org \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=marko.kovacevic@intel.com \
--cc=mdr@ashroe.eu \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.