From: Kalle Valo <kvalo@codeaurora.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org,
bryan.odonoghue@linaro.org, shawn.guo@linaro.org,
loic.poulain@linaro.org
Subject: Re: [PATCH v2 01/12] wcn36xx: Add VHT fields to parameter data structures
Date: Wed, 2 Sep 2020 08:59:42 +0000 (UTC) [thread overview]
Message-ID: <20200902085942.0D94BC433CB@smtp.codeaurora.org> (raw)
In-Reply-To: <20200829033908.2167689-2-bryan.odonoghue@linaro.org>
Bryan O'Donoghue <bryan.odonoghue@linaro.org> wrote:
> In order to pass VHT parameters to wcn3680 we need to use a super-set of
> the V1 data-structures with additional VHT parameters tacked on.
>
> This patch adds the additional fields to the STA and BSS parameter
> structures with some utility macros to make calculation of the structure
> size easier.
>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
New warnings:
drivers/net/wireless/ath/wcn36xx/smd.c:1257:1: warning: 'wcn36xx_smd_set_sta_params_v1' defined but not used [-Wunused-function]
1257 | wcn36xx_smd_set_sta_params_v1(struct wcn36xx *wcn,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/wireless/ath/wcn36xx/smd.c:150:1: warning: 'wcn36xx_smd_set_bss_vht_params' defined but not used [-Wunused-function]
150 | wcn36xx_smd_set_bss_vht_params(struct ieee80211_vif *vif,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
12 patches set to Changes Requested.
11743937 [v2,01/12] wcn36xx: Add VHT fields to parameter data structures
11743997 [v2,02/12] wcn36xx: Use V1 data structure to store supported rates
11743939 [v2,03/12] wcn36xx: Add wcn36xx_set_default_rates_v1
11743977 [v2,04/12] wcn36xx: Add VHT rates to wcn36xx_update_allowed_rates()
11743963 [v2,05/12] wcn36xx: Add wcn36xx_smd_set_sta_default_vht_params()
11743943 [v2,06/12] wcn36xx: Add wcn36xx_smd_set_sta_default_ht_ldpc_params()
11743945 [v2,07/12] wcn36xx: Add wcn36xx_smd_set_sta_vht_params()
11743951 [v2,08/12] wcn36xx: Add wcn36xx_smd_set_sta_ht_ldpc_params()
11743949 [v2,09/12] wcn36xx: Add wcn36xx_smd_set_bss_vht_params()
11743947 [v2,10/12] wcn36xx: Add wrapper function wcn36xx_smd_set_sta_params_v1()
11743961 [v2,11/12] wcn36xx: Define INIT_HAL_MSG_V1()
11743953 [v2,12/12] wcn36xx: Convert to VHT parameter structure on wcn3680
--
https://patchwork.kernel.org/patch/11743937/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2020-09-02 9:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-29 3:38 [PATCH v2 00/12] wcn36xx: Add support for extended V1 SMD parameter passing Bryan O'Donoghue
2020-08-29 3:38 ` [PATCH v2 01/12] wcn36xx: Add VHT fields to parameter data structures Bryan O'Donoghue
2020-09-02 8:59 ` Kalle Valo [this message]
[not found] ` <20200902085942.05A42C433C6@smtp.codeaurora.org>
2020-09-02 9:39 ` Bryan O'Donoghue
2020-09-02 12:19 ` Kalle Valo
2020-08-29 3:38 ` [PATCH v2 02/12] wcn36xx: Use V1 data structure to store supported rates Bryan O'Donoghue
2020-08-29 3:38 ` [PATCH v2 03/12] wcn36xx: Add wcn36xx_set_default_rates_v1 Bryan O'Donoghue
2020-08-29 3:39 ` [PATCH v2 04/12] wcn36xx: Add VHT rates to wcn36xx_update_allowed_rates() Bryan O'Donoghue
2020-08-29 3:39 ` [PATCH v2 05/12] wcn36xx: Add wcn36xx_smd_set_sta_default_vht_params() Bryan O'Donoghue
2020-08-29 3:39 ` [PATCH v2 06/12] wcn36xx: Add wcn36xx_smd_set_sta_default_ht_ldpc_params() Bryan O'Donoghue
2020-08-29 3:39 ` [PATCH v2 07/12] wcn36xx: Add wcn36xx_smd_set_sta_vht_params() Bryan O'Donoghue
2020-08-29 3:39 ` [PATCH v2 08/12] wcn36xx: Add wcn36xx_smd_set_sta_ht_ldpc_params() Bryan O'Donoghue
2020-08-29 3:39 ` [PATCH v2 09/12] wcn36xx: Add wcn36xx_smd_set_bss_vht_params() Bryan O'Donoghue
2020-08-29 3:39 ` [PATCH v2 10/12] wcn36xx: Add wrapper function wcn36xx_smd_set_sta_params_v1() Bryan O'Donoghue
2020-08-29 3:39 ` [PATCH v2 11/12] wcn36xx: Define INIT_HAL_MSG_V1() Bryan O'Donoghue
2020-08-29 3:39 ` [PATCH v2 12/12] wcn36xx: Convert to VHT parameter structure on wcn3680 Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200902085942.0D94BC433CB@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=bryan.odonoghue@linaro.org \
--cc=linux-wireless@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=shawn.guo@linaro.org \
--cc=wcn36xx@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.