From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1kDQGl-00027a-BC for mharc-qemu-riscv@gnu.org; Wed, 02 Sep 2020 06:45:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57910) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kDQGj-000271-Oz; Wed, 02 Sep 2020 06:45:33 -0400 Received: from mail-lf1-x141.google.com ([2a00:1450:4864:20::141]:35620) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kDQGi-0006fD-7T; Wed, 02 Sep 2020 06:45:33 -0400 Received: by mail-lf1-x141.google.com with SMTP id w11so2555723lfn.2; Wed, 02 Sep 2020 03:45:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=DTAs/kcJaltCNKBEfHuYmku6va+chymOmOLA/aDpIZc=; b=P38Nz/odx1rJfgTbSS4rnVAfFCVJCp9qONK0G4tuadWJwv5jYgh9/yW7ekU+3XEHGV kYRdC40SBzKrG7YyyQ/06p9Z+WxSu37Uuo1/zLdpUPHz16yflr4UQisj1wx03QjjY7fJ R/oIa5WUYjB5ZGbODdghSU/PWUHyMlGJwWVq8y0lV6PojUiD7yj4QcNeWAO1n2Wc9m5d DZamsfY2wZCQ/UeTRmQYUSGopouCz53lRwWgDM/CXvpYSYBM9OurgKST11jVJ+70zBju efyljvNmsUbaDHq6S2rQ0nBxFVox62dJgMLbpj/4CpyKsFeQyCTW/71HvCmMr6XcjDZR qDxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=DTAs/kcJaltCNKBEfHuYmku6va+chymOmOLA/aDpIZc=; b=MdIHokEAQjIo9f4/i48t2zXvQHTX0SB6olxJ8tdm9NXpm3g5WWaGkZkNi12U4WU6LI F+uJ7WdoyGiZATd8dGYrmNQ/gnUjiDyiVdbW+NN0hd5pfXHPDMoIM9EoDQBeOTUx3nSf 889zSflaOoU8EGziMocd5Mh3an5vCi5aj2xWXJ8ljkag7rZRZfYPnik1jcb5QnoqNmpB N8MiGYrcag/zqXMIAeqgJq89B7Iva0DhOzZLWqedPfsH4Ibs6sQW55XxwLTGQFfnclCZ 1spxqGC44TMYegyXDbbLhsFXGaksEZgswi5H2UhRrSkmQFuAlXv9dn8svbi4RN6+3DPk Oshg== X-Gm-Message-State: AOAM532iIgGWISJEN9p5Pni7JOI9SAxuiJrpJiL5QnAolJ/bU2ecDfdD xJxlLoETuJMHraaNBPiWRx0= X-Google-Smtp-Source: ABdhPJzf7IlpapGd/caRnXmj9xy+QNRTb1BfC+0shOG4/h3CAWigaymLxsop4BaosRMzjGAUPTESpg== X-Received: by 2002:ac2:5597:: with SMTP id v23mr95661lfg.5.1599043529823; Wed, 02 Sep 2020 03:45:29 -0700 (PDT) Received: from gmail.com (81-231-232-130-no39.tbcn.telia.com. [81.231.232.130]) by smtp.gmail.com with ESMTPSA id s3sm889096ljd.44.2020.09.02.03.45.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Sep 2020 03:45:28 -0700 (PDT) Date: Wed, 2 Sep 2020 12:45:28 +0200 From: "Edgar E. Iglesias" To: Bin Meng Cc: Alistair Francis , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Palmer Dabbelt , qemu-devel@nongnu.org, qemu-riscv@nongnu.org, Bin Meng , Alistair Francis , Jason Wang , Peter Maydell , qemu-arm@nongnu.org Subject: Re: [PATCH v3 11/16] hw/net: cadence_gem: Add a new 'phy-addr' property Message-ID: <20200902104528.GW2954729@toto> References: <1598924352-89526-1-git-send-email-bmeng.cn@gmail.com> <1598924352-89526-12-git-send-email-bmeng.cn@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1598924352-89526-12-git-send-email-bmeng.cn@gmail.com> Received-SPF: pass client-ip=2a00:1450:4864:20::141; envelope-from=edgar.iglesias@gmail.com; helo=mail-lf1-x141.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: 2 X-Spam_score: 0.2 X-Spam_bar: / X-Spam_report: (0.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FSL_HELO_FAKE=2.346, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Sep 2020 10:45:34 -0000 On Tue, Sep 01, 2020 at 09:39:06AM +0800, Bin Meng wrote: > From: Bin Meng > > At present the PHY address of the PHY connected to GEM is hard-coded > to either 23 (BOARD_PHY_ADDRESS) or 0. This might not be the case for > all boards. Add a new 'phy-addr' property so that board can specify > the PHY address for each GEM instance. > > Signed-off-by: Bin Meng Hi Bin, It looks like there's a change here compared to v2 to keep addr 0 as broadcast? Perhaps it would be useful to add a comment in the code about it. Anyway: Reviewed-by: Edgar E. Iglesias > > --- > > (no changes since v2) > > Changes in v2: > - change "phy-addr" default value to BOARD_PHY_ADDRESS > > include/hw/net/cadence_gem.h | 2 ++ > hw/net/cadence_gem.c | 5 +++-- > 2 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/include/hw/net/cadence_gem.h b/include/hw/net/cadence_gem.h > index 54e646f..01c6189 100644 > --- a/include/hw/net/cadence_gem.h > +++ b/include/hw/net/cadence_gem.h > @@ -73,6 +73,8 @@ typedef struct CadenceGEMState { > /* Mask of register bits which are write 1 to clear */ > uint32_t regs_w1c[CADENCE_GEM_MAXREG]; > > + /* PHY address */ > + uint8_t phy_addr; > /* PHY registers backing store */ > uint16_t phy_regs[32]; > > diff --git a/hw/net/cadence_gem.c b/hw/net/cadence_gem.c > index a93b5c0..d80096b 100644 > --- a/hw/net/cadence_gem.c > +++ b/hw/net/cadence_gem.c > @@ -1446,7 +1446,7 @@ static uint64_t gem_read(void *opaque, hwaddr offset, unsigned size) > uint32_t phy_addr, reg_num; > > phy_addr = (retval & GEM_PHYMNTNC_ADDR) >> GEM_PHYMNTNC_ADDR_SHFT; > - if (phy_addr == BOARD_PHY_ADDRESS || phy_addr == 0) { > + if (phy_addr == s->phy_addr || phy_addr == 0) { > reg_num = (retval & GEM_PHYMNTNC_REG) >> GEM_PHYMNTNC_REG_SHIFT; > retval &= 0xFFFF0000; > retval |= gem_phy_read(s, reg_num); > @@ -1569,7 +1569,7 @@ static void gem_write(void *opaque, hwaddr offset, uint64_t val, > uint32_t phy_addr, reg_num; > > phy_addr = (val & GEM_PHYMNTNC_ADDR) >> GEM_PHYMNTNC_ADDR_SHFT; > - if (phy_addr == BOARD_PHY_ADDRESS || phy_addr == 0) { > + if (phy_addr == s->phy_addr || phy_addr == 0) { > reg_num = (val & GEM_PHYMNTNC_REG) >> GEM_PHYMNTNC_REG_SHIFT; > gem_phy_write(s, reg_num, val); > } > @@ -1682,6 +1682,7 @@ static Property gem_properties[] = { > DEFINE_NIC_PROPERTIES(CadenceGEMState, conf), > DEFINE_PROP_UINT32("revision", CadenceGEMState, revision, > GEM_MODID_VALUE), > + DEFINE_PROP_UINT8("phy-addr", CadenceGEMState, phy_addr, BOARD_PHY_ADDRESS), > DEFINE_PROP_UINT8("num-priority-queues", CadenceGEMState, > num_priority_queues, 1), > DEFINE_PROP_UINT8("num-type1-screeners", CadenceGEMState, > -- > 2.7.4 > From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a19:ad09:0:0:0:0:0 with SMTP id t9csp417133lfc; Wed, 2 Sep 2020 03:45:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxGWnxIobb7QvSJDCfKtGDbqsWFfYB+WBZAz7jjARgNUxbvWSwvPvdBhd1erdxyCwTXlxAU X-Received: by 2002:a25:ef44:: with SMTP id w4mr8355831ybm.188.1599043548500; Wed, 02 Sep 2020 03:45:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599043548; cv=none; d=google.com; s=arc-20160816; b=bkpcpmw6MJbNongnlrVI1rpnDhbAviySKOBAOA9uxVcIYtaRZkk/TXiS6L0aG7bLBz DnZiexgjMjieQ6gSrSFYtw/j372YkqV+vJ5kuocMRokOWatxnK76qivJQxWOw/8mutVl F7zojTw1jHSYGOFhFfXAMl2QotCklNf3SmmPQ80gAPcc1j/+VQfVwVWdSm18UVuucVvN hChMS9PwKuARslHb0ceLrBo/dp4DuMdxVqxjR+8hmV/CVstASDYxjPFNWR9Jb9GiMcnJ +NLXbU6Uz++23Wdf+jX8v9eOqkaFx6vEMFQPKmsJppKzeXMNN+c82zzqwiKYahV1s5FN ngWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:in-reply-to:content-disposition :mime-version:references:message-id:subject:to:from:date :dkim-signature; bh=DTAs/kcJaltCNKBEfHuYmku6va+chymOmOLA/aDpIZc=; b=kaAxCVE8e3M684UfeZGZ9PyjPmDkdgKfWO1N+jvDwOU1CdjejhQXd42S6IQ5gXoxzA cgQpQc2ligCgP0fZMv2/kDgJD5U1E7dBTCSIgwsrQmkwo4Fedt1fIQdfHoP6Eq/bUHVq ndaIOiJz+O6EIXD1bV2w7p94I5vD2fx+B91Y/FPl8RkIMD2PP8ElKElcCuTAHvYC+KqX LVdtvmrKxHSCYwPzmjUKXPaE5GTVrtAjO7VIV/CtUEQi8cC5+RmmE44gIxDcjXsXDYdi 6rjDgb+lZE9Mx9QOgWUrKMt894FPkvCPizCM/M1SIWrNbI+46eKtkQDL54NIH9xD0qAQ D4QQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b="P38Nz/od"; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id c6si3829686ybk.112.2020.09.02.03.45.48 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 02 Sep 2020 03:45:48 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b="P38Nz/od"; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from localhost ([::1]:47142 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kDQGx-00027Y-Rl for alex.bennee@linaro.org; Wed, 02 Sep 2020 06:45:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57910) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kDQGj-000271-Oz; Wed, 02 Sep 2020 06:45:33 -0400 Received: from mail-lf1-x141.google.com ([2a00:1450:4864:20::141]:35620) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kDQGi-0006fD-7T; Wed, 02 Sep 2020 06:45:33 -0400 Received: by mail-lf1-x141.google.com with SMTP id w11so2555723lfn.2; Wed, 02 Sep 2020 03:45:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=DTAs/kcJaltCNKBEfHuYmku6va+chymOmOLA/aDpIZc=; b=P38Nz/odx1rJfgTbSS4rnVAfFCVJCp9qONK0G4tuadWJwv5jYgh9/yW7ekU+3XEHGV kYRdC40SBzKrG7YyyQ/06p9Z+WxSu37Uuo1/zLdpUPHz16yflr4UQisj1wx03QjjY7fJ R/oIa5WUYjB5ZGbODdghSU/PWUHyMlGJwWVq8y0lV6PojUiD7yj4QcNeWAO1n2Wc9m5d DZamsfY2wZCQ/UeTRmQYUSGopouCz53lRwWgDM/CXvpYSYBM9OurgKST11jVJ+70zBju efyljvNmsUbaDHq6S2rQ0nBxFVox62dJgMLbpj/4CpyKsFeQyCTW/71HvCmMr6XcjDZR qDxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=DTAs/kcJaltCNKBEfHuYmku6va+chymOmOLA/aDpIZc=; b=MdIHokEAQjIo9f4/i48t2zXvQHTX0SB6olxJ8tdm9NXpm3g5WWaGkZkNi12U4WU6LI F+uJ7WdoyGiZATd8dGYrmNQ/gnUjiDyiVdbW+NN0hd5pfXHPDMoIM9EoDQBeOTUx3nSf 889zSflaOoU8EGziMocd5Mh3an5vCi5aj2xWXJ8ljkag7rZRZfYPnik1jcb5QnoqNmpB N8MiGYrcag/zqXMIAeqgJq89B7Iva0DhOzZLWqedPfsH4Ibs6sQW55XxwLTGQFfnclCZ 1spxqGC44TMYegyXDbbLhsFXGaksEZgswi5H2UhRrSkmQFuAlXv9dn8svbi4RN6+3DPk Oshg== X-Gm-Message-State: AOAM532iIgGWISJEN9p5Pni7JOI9SAxuiJrpJiL5QnAolJ/bU2ecDfdD xJxlLoETuJMHraaNBPiWRx0= X-Received: by 2002:ac2:5597:: with SMTP id v23mr95661lfg.5.1599043529823; Wed, 02 Sep 2020 03:45:29 -0700 (PDT) Received: from gmail.com (81-231-232-130-no39.tbcn.telia.com. [81.231.232.130]) by smtp.gmail.com with ESMTPSA id s3sm889096ljd.44.2020.09.02.03.45.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Sep 2020 03:45:28 -0700 (PDT) Date: Wed, 2 Sep 2020 12:45:28 +0200 From: "Edgar E. Iglesias" To: Bin Meng Subject: Re: [PATCH v3 11/16] hw/net: cadence_gem: Add a new 'phy-addr' property Message-ID: <20200902104528.GW2954729@toto> References: <1598924352-89526-1-git-send-email-bmeng.cn@gmail.com> <1598924352-89526-12-git-send-email-bmeng.cn@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1598924352-89526-12-git-send-email-bmeng.cn@gmail.com> Received-SPF: pass client-ip=2a00:1450:4864:20::141; envelope-from=edgar.iglesias@gmail.com; helo=mail-lf1-x141.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: 2 X-Spam_score: 0.2 X-Spam_bar: / X-Spam_report: (0.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FSL_HELO_FAKE=2.346, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Palmer Dabbelt , qemu-riscv@nongnu.org, Jason Wang , Bin Meng , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , qemu-devel@nongnu.org, qemu-arm@nongnu.org, Alistair Francis , Alistair Francis Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: hdbG7BYV2pma On Tue, Sep 01, 2020 at 09:39:06AM +0800, Bin Meng wrote: > From: Bin Meng > > At present the PHY address of the PHY connected to GEM is hard-coded > to either 23 (BOARD_PHY_ADDRESS) or 0. This might not be the case for > all boards. Add a new 'phy-addr' property so that board can specify > the PHY address for each GEM instance. > > Signed-off-by: Bin Meng Hi Bin, It looks like there's a change here compared to v2 to keep addr 0 as broadcast? Perhaps it would be useful to add a comment in the code about it. Anyway: Reviewed-by: Edgar E. Iglesias > > --- > > (no changes since v2) > > Changes in v2: > - change "phy-addr" default value to BOARD_PHY_ADDRESS > > include/hw/net/cadence_gem.h | 2 ++ > hw/net/cadence_gem.c | 5 +++-- > 2 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/include/hw/net/cadence_gem.h b/include/hw/net/cadence_gem.h > index 54e646f..01c6189 100644 > --- a/include/hw/net/cadence_gem.h > +++ b/include/hw/net/cadence_gem.h > @@ -73,6 +73,8 @@ typedef struct CadenceGEMState { > /* Mask of register bits which are write 1 to clear */ > uint32_t regs_w1c[CADENCE_GEM_MAXREG]; > > + /* PHY address */ > + uint8_t phy_addr; > /* PHY registers backing store */ > uint16_t phy_regs[32]; > > diff --git a/hw/net/cadence_gem.c b/hw/net/cadence_gem.c > index a93b5c0..d80096b 100644 > --- a/hw/net/cadence_gem.c > +++ b/hw/net/cadence_gem.c > @@ -1446,7 +1446,7 @@ static uint64_t gem_read(void *opaque, hwaddr offset, unsigned size) > uint32_t phy_addr, reg_num; > > phy_addr = (retval & GEM_PHYMNTNC_ADDR) >> GEM_PHYMNTNC_ADDR_SHFT; > - if (phy_addr == BOARD_PHY_ADDRESS || phy_addr == 0) { > + if (phy_addr == s->phy_addr || phy_addr == 0) { > reg_num = (retval & GEM_PHYMNTNC_REG) >> GEM_PHYMNTNC_REG_SHIFT; > retval &= 0xFFFF0000; > retval |= gem_phy_read(s, reg_num); > @@ -1569,7 +1569,7 @@ static void gem_write(void *opaque, hwaddr offset, uint64_t val, > uint32_t phy_addr, reg_num; > > phy_addr = (val & GEM_PHYMNTNC_ADDR) >> GEM_PHYMNTNC_ADDR_SHFT; > - if (phy_addr == BOARD_PHY_ADDRESS || phy_addr == 0) { > + if (phy_addr == s->phy_addr || phy_addr == 0) { > reg_num = (val & GEM_PHYMNTNC_REG) >> GEM_PHYMNTNC_REG_SHIFT; > gem_phy_write(s, reg_num, val); > } > @@ -1682,6 +1682,7 @@ static Property gem_properties[] = { > DEFINE_NIC_PROPERTIES(CadenceGEMState, conf), > DEFINE_PROP_UINT32("revision", CadenceGEMState, revision, > GEM_MODID_VALUE), > + DEFINE_PROP_UINT8("phy-addr", CadenceGEMState, phy_addr, BOARD_PHY_ADDRESS), > DEFINE_PROP_UINT8("num-priority-queues", CadenceGEMState, > num_priority_queues, 1), > DEFINE_PROP_UINT8("num-type1-screeners", CadenceGEMState, > -- > 2.7.4 >