From: Chris Down <chris@chrisdown.name>
To: Byron Stanoszek <gandalf@winds.org>
Cc: Hugh Dickins <hughd@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tmpfs: Restore functionality of nr_inodes=0
Date: Wed, 2 Sep 2020 11:48:59 +0100 [thread overview]
Message-ID: <20200902104859.GA79629@chrisdown.name> (raw)
In-Reply-To: <20200902035715.16414-1-gandalf@winds.org>
Byron Stanoszek writes:
>Commit e809d5f0b5c9 ("tmpfs: per-superblock i_ino support") made changes to
>shmem_reserve_inode() in mm/shmem.c, however the original test for
>(sbinfo->max_inodes) got dropped. This causes mounting tmpfs with option
>nr_inodes=0 to fail:
>
> # mount -ttmpfs -onr_inodes=0 none /ext0
> mount: /ext0: mount(2) system call failed: Cannot allocate memory.
>
>This patch restores the nr_inodes=0 functionality.
>
>Fixes: e809d5f0b5c9 ("tmpfs: per-superblock i_ino support")
>Cc: Chris Down <chris@chrisdown.name>
>Signed-off-by: Byron Stanoszek <gandalf@winds.org>
Acked-by: Chris Down <chris@chrisdown.name>
Thanks, good catch.
prev parent reply other threads:[~2020-09-02 10:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 3:57 [PATCH] tmpfs: Restore functionality of nr_inodes=0 Byron Stanoszek
2020-09-02 4:22 ` Hugh Dickins
2020-09-02 10:48 ` Chris Down [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200902104859.GA79629@chrisdown.name \
--to=chris@chrisdown.name \
--cc=akpm@linux-foundation.org \
--cc=gandalf@winds.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.