From: Krzysztof Kozlowski <krzk@kernel.org>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Jonathan Hunter <jonathanh@nvidia.com>,
Dmitry Osipenko <digetx@gmail.com>,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
Matias Zuniga <matias.nicolas.zc@gmail.com>
Subject: Re: [PATCH] memory: tegra: Remove GPU from DRM IOMMU group
Date: Wed, 2 Sep 2020 17:24:55 +0200 [thread overview]
Message-ID: <20200902152455.GC19659@kozik-lap> (raw)
In-Reply-To: <20200901153248.1831263-1-thierry.reding@gmail.com>
On Tue, Sep 01, 2020 at 05:32:48PM +0200, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> Commit 63a613fdb16c ("memory: tegra: Add gr2d and gr3d to DRM IOMMU
> group") added the GPU to the DRM IOMMU group, which doesn't make any
> sense. This causes problems when Nouveau tries to attach to the SMMU
> and causes it to fall back to using the DMA API.
>
> Remove the GPU from the DRM groups to restore the old behaviour. The
> GPU should always have its own IOMMU domain to make sure it can map
> buffers into contiguous chunks (for big page support) without getting
> in the way of mappings from the DRM group.
>
> Fixes: 63a613fdb16c ("memory: tegra: Add gr2d and gr3d to DRM IOMMU group")
> Reported-by: Matias Zuniga <matias.nicolas.zc@gmail.com>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> drivers/memory/tegra/tegra124.c | 1 -
Thanks, applied.
Best regards,
Krzysztof
prev parent reply other threads:[~2020-09-02 15:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 15:32 [PATCH] memory: tegra: Remove GPU from DRM IOMMU group Thierry Reding
2020-09-01 16:57 ` Dmitry Osipenko
2020-09-02 15:24 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200902152455.GC19659@kozik-lap \
--to=krzk@kernel.org \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=matias.nicolas.zc@gmail.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.