From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Phil Sutter <phil@nwl.cc>,
netfilter-devel@vger.kernel.org, eric@garver.life
Subject: Re: [PATCH nf,v2] netfilter: nf_tables: coalesce multiple notifications into one skbuff
Date: Wed, 2 Sep 2020 18:27:18 +0200 [thread overview]
Message-ID: <20200902162718.GA17031@salvia> (raw)
In-Reply-To: <20200902150443.GE23632@orbyte.nwl.cc>
On Wed, Sep 02, 2020 at 05:04:43PM +0200, Phil Sutter wrote:
> On Wed, Sep 02, 2020 at 04:52:02PM +0200, Pablo Neira Ayuso wrote:
> [...]
> > +static void nft_commit_notify(struct net *net, u32 portid)
> > +{
> > + struct sk_buff *batch_skb = NULL, *nskb, *skb;
> > + unsigned char *data;
> > + int len;
> > +
> > + list_for_each_entry_safe(skb, nskb, &net->nft.notify_list, list) {
> > + if (!batch_skb) {
> > +new_batch:
> > + batch_skb = skb;
> > + NFT_CB(batch_skb).report = NFT_CB(skb).report;
>
> Is this assignment needed? NFT_CB() merely dereferences skb->cb, so
> after assigning 'batch_skb = skb', NFT_CB(batch_skb) == NFT_CB(skb), no?
That's right, thanks for reviewing.
prev parent reply other threads:[~2020-09-02 16:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 14:52 [PATCH nf,v2] netfilter: nf_tables: coalesce multiple notifications into one skbuff Pablo Neira Ayuso
2020-09-02 15:04 ` Phil Sutter
2020-09-02 16:27 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200902162718.GA17031@salvia \
--to=pablo@netfilter.org \
--cc=eric@garver.life \
--cc=netfilter-devel@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.