From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Snitzer Subject: Re: flood of "dm-X: error: dax access failed" due to 5.9 commit 231609785cbfb Date: Wed, 2 Sep 2020 12:44:57 -0400 Message-ID: <20200902164456.GA5928@redhat.com> References: <20200902160432.GA5513@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com Content-Disposition: inline To: Coly Li Cc: Pankaj Gupta , linux-nvdimm@lists.01.org, Vishal Verma , dm-devel@redhat.com, Jan Kara , Ira Weiny List-Id: dm-devel.ids On Wed, Sep 02 2020 at 12:40pm -0400, Coly Li wrote: > On 2020/9/3 00:04, Mike Snitzer wrote: > > 5.9 commit 231609785cbfb ("dax: print error message by pr_info() in > > __generic_fsdax_supported()") switched from pr_debug() to pr_info(). > > > > The justification in the commit header is really inadequate. If there > > is a problem that you need to drill in on, repeat the testing after > > enabling the dynamic debugging. > > > > Otherwise, now all DM devices that aren't layered on DAX capable devices > > spew really confusing noise to users when they simply activate their > > non-DAX DM devices: > > > > [66567.129798] dm-6: error: dax access failed (-5) > > [66567.134400] dm-6: error: dax access failed (-5) > > [66567.139152] dm-6: error: dax access failed (-5) > > [66567.314546] dm-2: error: dax access failed (-95) > > [66567.319380] dm-2: error: dax access failed (-95) > > [66567.324254] dm-2: error: dax access failed (-95) > > [66567.479025] dm-2: error: dax access failed (-95) > > [66567.483713] dm-2: error: dax access failed (-95) > > [66567.488722] dm-2: error: dax access failed (-95) > > [66567.494061] dm-2: error: dax access failed (-95) > > [66567.498823] dm-2: error: dax access failed (-95) > > [66567.503693] dm-2: error: dax access failed (-95) > > > > commit 231609785cbfb must be reverted. > > > > Please advise, thanks. > > Adrian Huang from Lenovo posted a patch, which titled: dax: do not print > error message for non-persistent memory block device > > It fixes the issue, but no response for now. Maybe we should take this fix. OK, yes sounds like it. It was merged and is commit c2affe920b0e066 ("dax: do not print error message for non-persistent memory block device") Thanks for the info. Mike From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.5 required=3.0 tests=BAYES_50,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D56AC433E2 for ; Wed, 2 Sep 2020 16:45:09 +0000 (UTC) Received: from ml01.01.org (ml01.01.org [198.145.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6DCB520684 for ; Wed, 2 Sep 2020 16:45:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="DHGIkFws" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6DCB520684 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvdimm-bounces@lists.01.org Received: from ml01.vlan13.01.org (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 4768A13AAF743; Wed, 2 Sep 2020 09:45:09 -0700 (PDT) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=207.211.31.81; helo=us-smtp-delivery-1.mimecast.com; envelope-from=msnitzer@redhat.com; receiver= Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 339B313AA0E4F for ; Wed, 2 Sep 2020 09:45:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1599065105; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rCORYoTptCNctcHmeRURsRJc20YTgKGms7zHw+aGUWY=; b=DHGIkFws+fpFi1KX6ZyecF+rujyp6GPwKgUD5M6HLa2kkqGdW7ue4oIG/wRf48+rVdyOrn EuYBQoxU+DAHM3cCW3n5cP04DRDlL5v8+M/C8BzSsNC9yHCePiwFB3s0YfzDQ6slSwyFiW PQ4pGUkqYDnQJr1W0EAGTf6Otdx+mmc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-497-plyNLgTEO9CPua6cmCO_NA-1; Wed, 02 Sep 2020 12:45:02 -0400 X-MC-Unique: plyNLgTEO9CPua6cmCO_NA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C4631107B765; Wed, 2 Sep 2020 16:45:00 +0000 (UTC) Received: from localhost (unknown [10.18.25.174]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CA4CC5C1C4; Wed, 2 Sep 2020 16:44:57 +0000 (UTC) Date: Wed, 2 Sep 2020 12:44:57 -0400 From: Mike Snitzer To: Coly Li Subject: Re: flood of "dm-X: error: dax access failed" due to 5.9 commit 231609785cbfb Message-ID: <20200902164456.GA5928@redhat.com> References: <20200902160432.GA5513@redhat.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=msnitzer@redhat.com X-Mimecast-Spam-Score: 0.002 X-Mimecast-Originator: redhat.com Content-Disposition: inline Message-ID-Hash: J4JQ4YHAICPZNWMUKUFXLHSG2HDMRM6Y X-Message-ID-Hash: J4JQ4YHAICPZNWMUKUFXLHSG2HDMRM6Y X-MailFrom: msnitzer@redhat.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation CC: Jan Kara , Pankaj Gupta , linux-nvdimm@lists.01.org, dm-devel@redhat.com X-Mailman-Version: 3.1.1 Precedence: list List-Id: "Linux-nvdimm developer list." Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Wed, Sep 02 2020 at 12:40pm -0400, Coly Li wrote: > On 2020/9/3 00:04, Mike Snitzer wrote: > > 5.9 commit 231609785cbfb ("dax: print error message by pr_info() in > > __generic_fsdax_supported()") switched from pr_debug() to pr_info(). > > > > The justification in the commit header is really inadequate. If there > > is a problem that you need to drill in on, repeat the testing after > > enabling the dynamic debugging. > > > > Otherwise, now all DM devices that aren't layered on DAX capable devices > > spew really confusing noise to users when they simply activate their > > non-DAX DM devices: > > > > [66567.129798] dm-6: error: dax access failed (-5) > > [66567.134400] dm-6: error: dax access failed (-5) > > [66567.139152] dm-6: error: dax access failed (-5) > > [66567.314546] dm-2: error: dax access failed (-95) > > [66567.319380] dm-2: error: dax access failed (-95) > > [66567.324254] dm-2: error: dax access failed (-95) > > [66567.479025] dm-2: error: dax access failed (-95) > > [66567.483713] dm-2: error: dax access failed (-95) > > [66567.488722] dm-2: error: dax access failed (-95) > > [66567.494061] dm-2: error: dax access failed (-95) > > [66567.498823] dm-2: error: dax access failed (-95) > > [66567.503693] dm-2: error: dax access failed (-95) > > > > commit 231609785cbfb must be reverted. > > > > Please advise, thanks. > > Adrian Huang from Lenovo posted a patch, which titled: dax: do not print > error message for non-persistent memory block device > > It fixes the issue, but no response for now. Maybe we should take this fix. OK, yes sounds like it. It was merged and is commit c2affe920b0e066 ("dax: do not print error message for non-persistent memory block device") Thanks for the info. Mike _______________________________________________ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-leave@lists.01.org