From: Peter Chen <peter.chen@nxp.com>
To: Roger Quadros <rogerq@ti.com>
Cc: "balbi@kernel.org" <balbi@kernel.org>,
"pawell@cadence.com" <pawell@cadence.com>,
"kurahul@cadence.com" <kurahul@cadence.com>,
"nsekhar@ti.com" <nsekhar@ti.com>,
"vigneshr@ti.com" <vigneshr@ti.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH 2/3] dt-bindings: usb: cdns,usb3: Add cdns,phyrst-a-enable property
Date: Wed, 2 Sep 2020 22:48:49 +0000 [thread overview]
Message-ID: <20200902224829.GA11250@b29397-desktop> (raw)
In-Reply-To: <08a7533f-b09e-f044-64e5-d709ae220599@ti.com>
On 20-09-02 16:28:31, Roger Quadros wrote:
> Peter,
>
> On 27/08/2020 14:14, Peter Chen wrote:
> > On 20-08-25 15:00:58, Roger Quadros wrote:
> > > Controller version 0x0002450D has USB2 PHY RX sensitivity issues
> > > that needs to be worked around by enabling phyrst-a-enable bit
> > > in PHYRST_CFG register.
> > >
> > > There is no way to distinguish between the controller version
> > > before the device controller is started so we need to add this
> > > DT property.
> >
> > Maybe you should say "There is no way to know controller version
> > at host mode, but this workaround needs for both host and device
> > mode, so we have to add this DT property", the same for the comments
> > of your driver code patch.
>
> I will reword it to
>
> "There is no way to know controller version before device controller
> is started and the workaround needs to be applied for both host and
> device modes, so we add this DT property"
>
After apply it, feel free add:
Reviewed-by: Peter Chen <peter.chen@nxp.com>
Please apply above for device party commit log as well.
--
Thanks,
Peter Chen
next prev parent reply other threads:[~2020-09-02 22:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-25 12:00 [PATCH 0/3] usb: cdns,usb3: Convert DT binding to YALM Roger Quadros
2020-08-25 12:00 ` [PATCH 1/3] dt-bindings: usb: Convert cdns-usb3.txt to YAML schema Roger Quadros
2020-08-25 12:00 ` [PATCH 2/3] dt-bindings: usb: cdns,usb3: Add cdns,phyrst-a-enable property Roger Quadros
2020-08-27 11:14 ` Peter Chen
2020-09-02 13:28 ` Roger Quadros
2020-09-02 22:48 ` Peter Chen [this message]
2020-08-25 12:00 ` [PATCH 3/3] usb: cdns3: Enable workaround for USB2.0 PHY Rx compliance test PHY lockup Roger Quadros
2020-08-26 3:21 ` Peter Chen
2020-08-26 4:04 ` Pawel Laszczak
2020-08-26 7:16 ` Peter Chen
2020-08-26 7:44 ` Pawel Laszczak
2020-08-26 8:07 ` Peter Chen
2020-08-26 12:49 ` Roger Quadros
2020-08-27 0:24 ` Peter Chen
2020-08-27 9:36 ` Roger Quadros
2020-08-27 13:02 ` Felipe Balbi
2020-08-27 11:09 ` Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200902224829.GA11250@b29397-desktop \
--to=peter.chen@nxp.com \
--cc=balbi@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kurahul@cadence.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=pawell@cadence.com \
--cc=robh+dt@kernel.org \
--cc=rogerq@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.