From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A717FC433E2 for ; Fri, 4 Sep 2020 16:23:26 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 1FC4F2067C for ; Fri, 4 Sep 2020 16:23:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20150623.gappssmtp.com header.i=@networkplumber-org.20150623.gappssmtp.com header.b="XKzFaR47" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1FC4F2067C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=networkplumber.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0BDEC1C0CE; Fri, 4 Sep 2020 18:23:25 +0200 (CEST) Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) by dpdk.org (Postfix) with ESMTP id 3E1F51C0CD for ; Fri, 4 Sep 2020 18:23:24 +0200 (CEST) Received: by mail-pf1-f194.google.com with SMTP id o20so4861217pfp.11 for ; Fri, 04 Sep 2020 09:23:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=w2FuG7YJ+aPKB5QCW0PorNVS53oCLXCqVDL1UBbiuCg=; b=XKzFaR47tS7mi9YT68IHgZsl2GtE7QG5HH/FCvlswPr1LqhD/+gDHqWOEcPpTpASOl BX/ZtV1pIUtvcfI9FKwU3uJehAY3f2Vu8jh3KRu9UL3d72VljRKkDCUt1lDspjqYAFKT J82RQpZFtHHCj8FkHDkzb9j22OthvTRzyzs9H8eaVhzZpmk/1WBbk3zTxOGtObIDaEdV 7cfaT8sy1G330A51uGOrgg9VejiH/ZeS1D5fI3ihijpDLIO964gfYRUMI51NxXQANxw3 2kQCo0HAF8C0RUMjBK2GqzSHYml2yIBhs8ft38Wr53+dOS/258RYrrE9yts5E5v1+ffE VCzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=w2FuG7YJ+aPKB5QCW0PorNVS53oCLXCqVDL1UBbiuCg=; b=nvtt+dgKGAUInBw6jyYsGS/JbuQt7RP7HBhtOk3i7R9XREoDkR5t3MYBvVrCMV9NTU YDtmYCQj7kI4CfFPyUvTnzpjRcnU9bqRmaFgecgfsFLY/kew/d22lnhM4vkY4M3tXFMx fYYS3x6VHTYUNsXz6mlCfibYseuIt3VzmCnh32pYpUJfaqMbUkcAQntlHb2B+rSHVRMj MbYRZ36ZxMpX0jFsoQQt7VBQN5Miz0TmKjCObxMCmtt4hpR8m9id8evAxuQOVbdtQok3 aEJb87tuLEK9wG/IJmuNzVIr9o5Yh5lVmwzvOSKO6mclJvIpgjoTBMH0iTJ4EXd/r2eu WprA== X-Gm-Message-State: AOAM533XvPRrk0re34/V6c7rcCX7FrRbArkskwJNW4dV76o/r3ZS3nby taim0emzfn83ycXmpppbEE6HYw== X-Google-Smtp-Source: ABdhPJyboNWmQ92otbese9CCJofgup3Lo/oYQiFPShE/8zI1CIoOkNLQlJFDKHQo918dWHBbySB7yQ== X-Received: by 2002:a63:2203:: with SMTP id i3mr7239284pgi.405.1599236603242; Fri, 04 Sep 2020 09:23:23 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id v22sm7180410pfe.75.2020.09.04.09.23.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Sep 2020 09:23:22 -0700 (PDT) Date: Fri, 4 Sep 2020 09:23:20 -0700 From: Stephen Hemminger To: Liang Ma Cc: dev@dpdk.org, david.hunt@intel.com, anatoly.burakov@intel.com Message-ID: <20200904092320.4eacddd1@hermes.lan> In-Reply-To: <1599214740-3927-1-git-send-email-liang.j.ma@intel.com> References: <1597141666-20621-1-git-send-email-liang.j.ma@intel.com> <1599214740-3927-1-git-send-email-liang.j.ma@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 1/6] eal: add power management intrinsics X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 4 Sep 2020 11:18:55 +0100 Liang Ma wrote: > + * > + * @return > + * Architecture-dependent return value. > + */ > +static inline int rte_power_monitor(const volatile void *p, > + const uint64_t expected_value, const uint64_t value_mask, > + const uint32_t state, const uint64_t tsc_timestamp); Since this is generic code, and you are defining the function. You should have it return -ENOTSUPPORTED or -EINVAL.