From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PULL_REQUEST,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 481F3C43461 for ; Fri, 4 Sep 2020 13:23:34 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1E29F206F2 for ; Fri, 4 Sep 2020 13:23:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1E29F206F2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9A3E06E14D; Fri, 4 Sep 2020 13:23:28 +0000 (UTC) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 123896E11F; Fri, 4 Sep 2020 13:23:27 +0000 (UTC) IronPort-SDR: cEFil7QJmpiY3vteO85TWPQJ5WNMOvmaq6fhSzQZErD+/lYrY/YBBsDNKPQKL2ffI6L5718nnB 7uPHU4oWJVLQ== X-IronPort-AV: E=McAfee;i="6000,8403,9733"; a="221948883" X-IronPort-AV: E=Sophos;i="5.76,389,1592895600"; d="scan'208";a="221948883" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Sep 2020 06:23:26 -0700 IronPort-SDR: qQheL7zfJYrOyLT4fdkDSR4R1NIzlOzf30Mg4ODmUT8PMPkE/Kob8WNKskmuDTkCf4gB1Oo7Tk 35MGGaRFq0EA== X-IronPort-AV: E=Sophos;i="5.76,389,1592895600"; d="scan'208";a="502921427" Received: from rdvivi-losangeles.jf.intel.com (HELO intel.com) ([10.165.21.201]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Sep 2020 06:23:25 -0700 Date: Fri, 4 Sep 2020 09:24:34 -0400 From: Rodrigo Vivi To: Lyude Paul Message-ID: <20200904132434.GA586737@intel.com> References: <11e59ebdea7ee4f46803a21fe9b21443d2b9c401.camel@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <11e59ebdea7ee4f46803a21fe9b21443d2b9c401.camel@redhat.com> Subject: Re: [Intel-gfx] [PULL] topic/nouveau-i915-dp-helpers-and-cleanup X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dim-tools@lists.freedesktop.org, Daniel Vetter , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Ben Skeggs Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, Aug 31, 2020 at 07:38:57PM -0400, Lyude Paul wrote: > topic/nouveau-i915-dp-helpers-and-cleanup-2020-08-31-1: > UAPI Changes: > > None > > Cross-subsystem Changes: > > * Moves a bunch of miscellaneous DP code from the i915 driver into a set > of shared DRM DP helpers > > Core Changes: > > * New DRM DP helpers (see above) > > Driver Changes: > > * Implements usage of the aforementioned DP helpers in the nouveau > driver, along with some other various HPD related cleanup for nouveau was this picked-up on the nouveau side already? whenever that happens, please ping me so I can pull this to dinq. But a reminder that it has my ack to go to drm-misc or only to nouveau directly. > The following changes since commit bfacb84993eb173c0ab53ca4dd6180f76f4dc176: > > drm: virtio: fix kconfig dependency warning (2020-08-31 08:55:02 +0200) > > are available in the Git repository at: > > git://anongit.freedesktop.org/drm/drm-misc tags/topic/nouveau-i915-dp-helpers-and-cleanup-2020-08-31-1 > > for you to fetch changes up to 79416e97dda0118b137302575a70a14259a27d7d: > > drm/nouveau/kms: Start using drm_dp_read_dpcd_caps() (2020-08-31 19:10:09 -0400) > > ---------------------------------------------------------------- > UAPI Changes: > > None > > Cross-subsystem Changes: > > * Moves a bunch of miscellaneous DP code from the i915 driver into a set > of shared DRM DP helpers > > Core Changes: > > * New DRM DP helpers (see above) > > Driver Changes: > > * Implements usage of the aforementioned DP helpers in the nouveau > driver, along with some other various HPD related cleanup for nouveau > > ---------------------------------------------------------------- > Lyude Paul (20): > drm/nouveau/kms: Fix some indenting in nouveau_dp_detect() > drm/nouveau/kms/nv50-: Remove open-coded drm_dp_read_desc() > drm/nouveau/kms/nv50-: Just use drm_dp_dpcd_read() in nouveau_dp.c > drm/nouveau/kms/nv50-: Use macros for DP registers in nouveau_dp.c > drm/nouveau/kms: Don't clear DP_MST_CTRL DPCD in nv50_mstm_new() > drm/nouveau/kms: Search for encoders' connectors properly > drm/nouveau/kms/nv50-: Use drm_dp_dpcd_(readb|writeb)() in nv50_sor_disable() > drm/nouveau/kms/nv50-: Refactor and cleanup DP HPD handling > drm/i915/dp: Extract drm_dp_read_mst_cap() > drm/nouveau/kms: Use new drm_dp_read_mst_cap() helper for checking MST caps > drm/nouveau/kms: Move drm_dp_cec_unset_edid() into nouveau_connector_detect() > drm/nouveau/kms: Only use hpd_work for reprobing in HPD paths > drm/i915/dp: Extract drm_dp_read_downstream_info() > drm/nouveau/kms/nv50-: Use downstream DP clock limits for mode validation > drm/i915/dp: Extract drm_dp_read_sink_count_cap() > drm/i915/dp: Extract drm_dp_read_sink_count() > drm/nouveau/kms/nv50-: Add support for DP_SINK_COUNT > drm/nouveau/kms: Don't change EDID when it hasn't actually changed > drm/i915/dp: Extract drm_dp_read_dpcd_caps() > drm/nouveau/kms: Start using drm_dp_read_dpcd_caps() > > drivers/gpu/drm/drm_dp_helper.c | 187 ++++++++++++++++- > drivers/gpu/drm/drm_dp_mst_topology.c | 22 ++ > drivers/gpu/drm/i915/display/intel_dp.c | 124 +++-------- > drivers/gpu/drm/i915/display/intel_dp.h | 1 - > drivers/gpu/drm/i915/display/intel_lspcon.c | 2 +- > drivers/gpu/drm/nouveau/dispnv04/dac.c | 2 +- > drivers/gpu/drm/nouveau/dispnv04/dfp.c | 7 +- > drivers/gpu/drm/nouveau/dispnv04/disp.c | 24 ++- > drivers/gpu/drm/nouveau/dispnv04/disp.h | 4 + > drivers/gpu/drm/nouveau/dispnv04/tvnv04.c | 2 +- > drivers/gpu/drm/nouveau/dispnv04/tvnv17.c | 2 +- > drivers/gpu/drm/nouveau/dispnv50/disp.c | 305 ++++++++++++++++------------ > drivers/gpu/drm/nouveau/nouveau_connector.c | 132 +++++------- > drivers/gpu/drm/nouveau/nouveau_connector.h | 1 + > drivers/gpu/drm/nouveau/nouveau_display.c | 72 ++++++- > drivers/gpu/drm/nouveau/nouveau_display.h | 3 +- > drivers/gpu/drm/nouveau/nouveau_dp.c | 210 +++++++++++++++---- > drivers/gpu/drm/nouveau/nouveau_drm.c | 4 +- > drivers/gpu/drm/nouveau/nouveau_drv.h | 2 + > drivers/gpu/drm/nouveau/nouveau_encoder.h | 48 ++++- > include/drm/drm_dp_helper.h | 15 +- > include/drm/drm_dp_mst_helper.h | 3 +- > 22 files changed, 779 insertions(+), 393 deletions(-) > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PULL_REQUEST,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77C27C433E2 for ; Fri, 4 Sep 2020 13:23:30 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 46D64206F2 for ; Fri, 4 Sep 2020 13:23:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 46D64206F2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 803AD6E11F; Fri, 4 Sep 2020 13:23:28 +0000 (UTC) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 123896E11F; Fri, 4 Sep 2020 13:23:27 +0000 (UTC) IronPort-SDR: cEFil7QJmpiY3vteO85TWPQJ5WNMOvmaq6fhSzQZErD+/lYrY/YBBsDNKPQKL2ffI6L5718nnB 7uPHU4oWJVLQ== X-IronPort-AV: E=McAfee;i="6000,8403,9733"; a="221948883" X-IronPort-AV: E=Sophos;i="5.76,389,1592895600"; d="scan'208";a="221948883" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Sep 2020 06:23:26 -0700 IronPort-SDR: qQheL7zfJYrOyLT4fdkDSR4R1NIzlOzf30Mg4ODmUT8PMPkE/Kob8WNKskmuDTkCf4gB1Oo7Tk 35MGGaRFq0EA== X-IronPort-AV: E=Sophos;i="5.76,389,1592895600"; d="scan'208";a="502921427" Received: from rdvivi-losangeles.jf.intel.com (HELO intel.com) ([10.165.21.201]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Sep 2020 06:23:25 -0700 Date: Fri, 4 Sep 2020 09:24:34 -0400 From: Rodrigo Vivi To: Lyude Paul Subject: Re: [PULL] topic/nouveau-i915-dp-helpers-and-cleanup Message-ID: <20200904132434.GA586737@intel.com> References: <11e59ebdea7ee4f46803a21fe9b21443d2b9c401.camel@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <11e59ebdea7ee4f46803a21fe9b21443d2b9c401.camel@redhat.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dim-tools@lists.freedesktop.org, Daniel Vetter , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Ben Skeggs , Sean Paul Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Aug 31, 2020 at 07:38:57PM -0400, Lyude Paul wrote: > topic/nouveau-i915-dp-helpers-and-cleanup-2020-08-31-1: > UAPI Changes: > > None > > Cross-subsystem Changes: > > * Moves a bunch of miscellaneous DP code from the i915 driver into a set > of shared DRM DP helpers > > Core Changes: > > * New DRM DP helpers (see above) > > Driver Changes: > > * Implements usage of the aforementioned DP helpers in the nouveau > driver, along with some other various HPD related cleanup for nouveau was this picked-up on the nouveau side already? whenever that happens, please ping me so I can pull this to dinq. But a reminder that it has my ack to go to drm-misc or only to nouveau directly. > The following changes since commit bfacb84993eb173c0ab53ca4dd6180f76f4dc176: > > drm: virtio: fix kconfig dependency warning (2020-08-31 08:55:02 +0200) > > are available in the Git repository at: > > git://anongit.freedesktop.org/drm/drm-misc tags/topic/nouveau-i915-dp-helpers-and-cleanup-2020-08-31-1 > > for you to fetch changes up to 79416e97dda0118b137302575a70a14259a27d7d: > > drm/nouveau/kms: Start using drm_dp_read_dpcd_caps() (2020-08-31 19:10:09 -0400) > > ---------------------------------------------------------------- > UAPI Changes: > > None > > Cross-subsystem Changes: > > * Moves a bunch of miscellaneous DP code from the i915 driver into a set > of shared DRM DP helpers > > Core Changes: > > * New DRM DP helpers (see above) > > Driver Changes: > > * Implements usage of the aforementioned DP helpers in the nouveau > driver, along with some other various HPD related cleanup for nouveau > > ---------------------------------------------------------------- > Lyude Paul (20): > drm/nouveau/kms: Fix some indenting in nouveau_dp_detect() > drm/nouveau/kms/nv50-: Remove open-coded drm_dp_read_desc() > drm/nouveau/kms/nv50-: Just use drm_dp_dpcd_read() in nouveau_dp.c > drm/nouveau/kms/nv50-: Use macros for DP registers in nouveau_dp.c > drm/nouveau/kms: Don't clear DP_MST_CTRL DPCD in nv50_mstm_new() > drm/nouveau/kms: Search for encoders' connectors properly > drm/nouveau/kms/nv50-: Use drm_dp_dpcd_(readb|writeb)() in nv50_sor_disable() > drm/nouveau/kms/nv50-: Refactor and cleanup DP HPD handling > drm/i915/dp: Extract drm_dp_read_mst_cap() > drm/nouveau/kms: Use new drm_dp_read_mst_cap() helper for checking MST caps > drm/nouveau/kms: Move drm_dp_cec_unset_edid() into nouveau_connector_detect() > drm/nouveau/kms: Only use hpd_work for reprobing in HPD paths > drm/i915/dp: Extract drm_dp_read_downstream_info() > drm/nouveau/kms/nv50-: Use downstream DP clock limits for mode validation > drm/i915/dp: Extract drm_dp_read_sink_count_cap() > drm/i915/dp: Extract drm_dp_read_sink_count() > drm/nouveau/kms/nv50-: Add support for DP_SINK_COUNT > drm/nouveau/kms: Don't change EDID when it hasn't actually changed > drm/i915/dp: Extract drm_dp_read_dpcd_caps() > drm/nouveau/kms: Start using drm_dp_read_dpcd_caps() > > drivers/gpu/drm/drm_dp_helper.c | 187 ++++++++++++++++- > drivers/gpu/drm/drm_dp_mst_topology.c | 22 ++ > drivers/gpu/drm/i915/display/intel_dp.c | 124 +++-------- > drivers/gpu/drm/i915/display/intel_dp.h | 1 - > drivers/gpu/drm/i915/display/intel_lspcon.c | 2 +- > drivers/gpu/drm/nouveau/dispnv04/dac.c | 2 +- > drivers/gpu/drm/nouveau/dispnv04/dfp.c | 7 +- > drivers/gpu/drm/nouveau/dispnv04/disp.c | 24 ++- > drivers/gpu/drm/nouveau/dispnv04/disp.h | 4 + > drivers/gpu/drm/nouveau/dispnv04/tvnv04.c | 2 +- > drivers/gpu/drm/nouveau/dispnv04/tvnv17.c | 2 +- > drivers/gpu/drm/nouveau/dispnv50/disp.c | 305 ++++++++++++++++------------ > drivers/gpu/drm/nouveau/nouveau_connector.c | 132 +++++------- > drivers/gpu/drm/nouveau/nouveau_connector.h | 1 + > drivers/gpu/drm/nouveau/nouveau_display.c | 72 ++++++- > drivers/gpu/drm/nouveau/nouveau_display.h | 3 +- > drivers/gpu/drm/nouveau/nouveau_dp.c | 210 +++++++++++++++---- > drivers/gpu/drm/nouveau/nouveau_drm.c | 4 +- > drivers/gpu/drm/nouveau/nouveau_drv.h | 2 + > drivers/gpu/drm/nouveau/nouveau_encoder.h | 48 ++++- > include/drm/drm_dp_helper.h | 15 +- > include/drm/drm_dp_mst_helper.h | 3 +- > 22 files changed, 779 insertions(+), 393 deletions(-) > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel