From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90690C433E2 for ; Fri, 4 Sep 2020 14:08:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6D3E0206B7 for ; Fri, 4 Sep 2020 14:08:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730564AbgIDOIH (ORCPT ); Fri, 4 Sep 2020 10:08:07 -0400 Received: from mga17.intel.com ([192.55.52.151]:30211 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730536AbgIDOH5 (ORCPT ); Fri, 4 Sep 2020 10:07:57 -0400 IronPort-SDR: aPcblmrGQ5dxZeIM3K+zru8pcV35UhxO2/SLi+nGCCi383hnXBMxVwyaD6ZYqF4lAn401oUIfU zleeiVprwaKg== X-IronPort-AV: E=McAfee;i="6000,8403,9733"; a="137796985" X-IronPort-AV: E=Sophos;i="5.76,389,1592895600"; d="scan'208";a="137796985" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Sep 2020 07:07:56 -0700 IronPort-SDR: 1/AVSyP6r4/gxXIEUxC/eYKZ2X2J036Wl4njkubWxf3W8k/rXn9Bx4Ln4BH/N2x5o7HOIuvtM6 tTSQLUAVmyCg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,389,1592895600"; d="scan'208";a="342203462" Received: from pipper-mobl1.ger.corp.intel.com (HELO localhost) ([10.252.56.104]) by orsmga007.jf.intel.com with ESMTP; 04 Sep 2020 07:07:54 -0700 Date: Fri, 4 Sep 2020 17:07:53 +0300 From: Jarkko Sakkinen To: Sean Christopherson Cc: Nathaniel McCallum , Cedric Xing , Jethro Beekman , Andy Lutomirski , linux-sgx@vger.kernel.org Subject: Re: [PATCH for_v37 5/6] selftests/sgx: Sanity check the return value of the vDSO call Message-ID: <20200904140753.GN39023@linux.intel.com> References: <20200904104437.29555-1-sean.j.christopherson@intel.com> <20200904104437.29555-6-sean.j.christopherson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200904104437.29555-6-sean.j.christopherson@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-sgx-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sgx@vger.kernel.org On Fri, Sep 04, 2020 at 03:44:36AM -0700, Sean Christopherson wrote: > Assert that the vDSO call returns 0 and that the exit reason is always > due to EEXIT. > > Signed-off-by: Sean Christopherson > --- > tools/testing/selftests/sgx/main.c | 35 +++++++++++++++++++++--------- > 1 file changed, 25 insertions(+), 10 deletions(-) > > diff --git a/tools/testing/selftests/sgx/main.c b/tools/testing/selftests/sgx/main.c > index 17f36e590fbd2..158ea9e2b6d3a 100644 > --- a/tools/testing/selftests/sgx/main.c > +++ b/tools/testing/selftests/sgx/main.c > @@ -123,6 +123,24 @@ static Elf64_Sym *vdso_symtab_get(struct vdso_symtab *symtab, const char *name) > return NULL; > } > > +int check_result(struct sgx_enclave_run *run, int ret, uint64_t result, > + const char *test) > +{ > + if (ret) { > + printf("FAIL: %s() returned: %d\n", test, ret); > + return ret; > + } else if (run->exit_reason != SGX_SYNCHRONOUS_EXIT) { > + printf("FAIL: %s() exit reason, expected: %u, got: %u\n", > + test, SGX_SYNCHRONOUS_EXIT, run->exit_reason); > + return -EIO; > + } else if (result != MAGIC) { > + printf("FAIL: %s(), expected: 0x%lx, got: 0x%lx\n", > + test, MAGIC, result); > + return -EIO; > + } > + return 0; > +} > + > int main(int argc, char *argv[], char *envp[]) > { > struct sgx_enclave_run run; > @@ -132,6 +150,7 @@ int main(int argc, char *argv[], char *envp[]) > struct encl encl; > unsigned int i; > void *addr; > + int ret; > > if (!encl_load("test_encl.elf", &encl)) > goto err; > @@ -172,21 +191,17 @@ int main(int argc, char *argv[], char *envp[]) > > eenter = addr + eenter_sym->st_value; > > - sgx_call_vdso((void *)&MAGIC, &result, 0, EENTER, NULL, NULL, &run); > - if (result != MAGIC) { > - printf("FAIL: sgx_call_vdso(), expected: 0x%lx, got: 0x%lx\n", > - MAGIC, result); > + ret = sgx_call_vdso((void *)&MAGIC, &result, 0, EENTER, NULL, NULL, &run); > + if (check_result(&run, ret, result, "sgx_call_vdso")) > goto err; > - } > + > > /* Invoke the vDSO directly. */ > result = 0; > - eenter((unsigned long)&MAGIC, (unsigned long)&result, 0, EENTER, 0, 0, &run); > - if (result != MAGIC) { > - printf("FAIL: eenter(), expected: 0x%lx, got: 0x%lx\n", > - MAGIC, result); > + ret = eenter((unsigned long)&MAGIC, (unsigned long)&result, 0, EENTER, > + 0, 0, &run); > + if (check_result(&run, ret, result, "eenter")) > goto err; > - } > > printf("SUCCESS\n"); > encl_delete(&encl); > -- > 2.28.0 > Acked-by: Jarkko Sakkinen /Jarkko