All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vadym Kochan <vadym.kochan@plvision.eu>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, Jiri Pirko <jiri@mellanox.com>,
	Ido Schimmel <idosch@mellanox.com>,
	Oleksandr Mazur <oleksandr.mazur@plvision.eu>,
	Serhiy Boiko <serhiy.boiko@plvision.eu>,
	Serhiy Pshyk <serhiy.pshyk@plvision.eu>,
	Volodymyr Mytnyk <volodymyr.mytnyk@plvision.eu>,
	Taras Chornyi <taras.chornyi@plvision.eu>,
	Andrii Savka <andrii.savka@plvision.eu>,
	Network Development <netdev@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	Mickey Rachamim <mickeyr@marvell.com>
Subject: Re: [PATCH net v6 1/6] net: marvell: prestera: Add driver for Prestera family ASIC devices
Date: Fri, 4 Sep 2020 18:54:53 +0300	[thread overview]
Message-ID: <20200904155453.GB28910@plvision.eu> (raw)
In-Reply-To: <20200904133217.GJ3112546@lunn.ch>

Hi Andrew,

On Fri, Sep 04, 2020 at 03:32:17PM +0200, Andrew Lunn wrote:
> > > > +static int prestera_is_valid_mac_addr(struct prestera_port *port, u8 *addr)
> > > > +{
> > > > +       if (!is_valid_ether_addr(addr))
> > > > +               return -EADDRNOTAVAIL;
> > > > +
> > > > +       if (memcmp(port->sw->base_mac, addr, ETH_ALEN - 1))
> > > 
> > > Why ETH_ALEN - 1?
> > > 
> > This is the restriction of the port mac address, it must have base mac
> > address part at first 5 bytes.
> 
> You probably want to put a comment here about that.
> 
> And this is particularly user unfriendly. Is this a hardware issue? Or
> firmware? Is this likely to change in the future?
> 
> 	  Andrew

It is required by the firmware, partially it may have relation to the
hardware.

I am not sure if it will be changed in the future. But I will add
a comment as you suggested.

Thanks,

  reply	other threads:[~2020-09-04 15:55 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-02 15:04 [PATCH net v6 0/6] net: marvell: prestera: Add Switchdev driver for Prestera family ASIC device 98DX3255 (AC3x) Vadym Kochan
2020-09-02 15:04 ` [PATCH net v6 1/6] net: marvell: prestera: Add driver for Prestera family ASIC devices Vadym Kochan
2020-09-03 15:22   ` Willem de Bruijn
2020-09-03 15:35     ` Andy Shevchenko
2020-09-04  9:34       ` Vadym Kochan
2020-09-04  9:32     ` Vadym Kochan
2020-09-04 13:32       ` Andrew Lunn
2020-09-04 15:54         ` Vadym Kochan [this message]
2020-09-02 15:04 ` [PATCH net v6 2/6] net: marvell: prestera: Add PCI interface support Vadym Kochan
2020-09-02 15:04 ` [PATCH net v6 3/6] net: marvell: prestera: Add basic devlink support Vadym Kochan
2020-09-02 15:04 ` [PATCH net v6 4/6] net: marvell: prestera: Add ethtool interface support Vadym Kochan
2020-09-02 15:04 ` [PATCH net v6 5/6] net: marvell: prestera: Add Switchdev driver implementation Vadym Kochan
2020-09-03 17:18   ` Willem de Bruijn
2020-09-04  9:34     ` Vadym Kochan
2020-09-02 15:04 ` [PATCH net v6 6/6] dt-bindings: marvell,prestera: Add description for device-tree bindings Vadym Kochan
2020-09-02 20:57 ` [PATCH net v6 0/6] net: marvell: prestera: Add Switchdev driver for Prestera family ASIC device 98DX3255 (AC3x) Vadym Kochan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200904155453.GB28910@plvision.eu \
    --to=vadym.kochan@plvision.eu \
    --cc=andrew@lunn.ch \
    --cc=andrii.savka@plvision.eu \
    --cc=andy.shevchenko@gmail.com \
    --cc=davem@davemloft.net \
    --cc=idosch@mellanox.com \
    --cc=jiri@mellanox.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mickeyr@marvell.com \
    --cc=netdev@vger.kernel.org \
    --cc=oleksandr.mazur@plvision.eu \
    --cc=serhiy.boiko@plvision.eu \
    --cc=serhiy.pshyk@plvision.eu \
    --cc=taras.chornyi@plvision.eu \
    --cc=volodymyr.mytnyk@plvision.eu \
    --cc=willemdebruijn.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.