From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: kajoljain <kjain@linux.ibm.com>, Jiri Olsa <jolsa@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Namhyung Kim <namhyung@kernel.org>,
Andi Kleen <ak@linux.intel.com>,
Jin Yao <yao.jin@linux.intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Leo Yan <leo.yan@linaro.org>, LKML <linux-kernel@vger.kernel.org>,
Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH v2] perf expr: Force encapsulation on expr_id_data
Date: Fri, 4 Sep 2020 13:29:20 -0300 [thread overview]
Message-ID: <20200904162920.GV3495158@kernel.org> (raw)
In-Reply-To: <CAP-5=fUdK2Zuv9BMpkRw669n_SvQ3kDa0s0RA=Hj1GUtqqw0YQ@mail.gmail.com>
Em Thu, Sep 03, 2020 at 10:53:16PM -0700, Ian Rogers escreveu:
> On Thu, Aug 27, 2020 at 12:00 AM kajoljain <kjain@linux.ibm.com> wrote:
> >
> >
> >
> > On 8/26/20 9:27 PM, Jiri Olsa wrote:
> > > On Wed, Aug 26, 2020 at 08:30:55AM -0700, Ian Rogers wrote:
> > >> This patch resolves some undefined behavior where variables in
> > >> expr_id_data were accessed (for debugging) without being defined. To
> > >> better enforce the tagged union behavior, the struct is moved into
> > >> expr.c and accessors provided. Tag values (kinds) are explicitly
> > >> identified.
> >
> > Reviewed-By: Kajol Jain<kjain@linux.ibm.com>
> >
> > Thanks,
> > Kajol Jain
> > >>
> > >> Signed-off-by: Ian Rogers <irogers@google.com>
> > >
> > > great, thanks for doing this
> > >
> > > Acked-by: Jiri Olsa <jolsa@redhat.com>
> > >
> > > jirka
> > >
>
> Thanks for the reviews! Arnaldo could this get merged? Thanks!
I'll get this and the other outstanding patches into perf/core soon as I
got urgent stuff already merged by Linus,
Thanks!
- Arnaldo
next prev parent reply other threads:[~2020-09-04 16:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-26 15:30 [PATCH v2] perf expr: Force encapsulation on expr_id_data Ian Rogers
2020-08-26 15:57 ` Jiri Olsa
2020-08-27 7:00 ` kajoljain
2020-09-04 5:53 ` Ian Rogers
2020-09-04 16:29 ` Arnaldo Carvalho de Melo [this message]
[not found] ` <CAP-5=fW7bF4PJpNQnDnf--RVtmYQ+nKC-OoU_wYjaR4cuAXZfg@mail.gmail.com>
2020-11-16 17:10 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200904162920.GV3495158@kernel.org \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=jolsa@redhat.com \
--cc=kan.liang@linux.intel.com \
--cc=kjain@linux.ibm.com \
--cc=leo.yan@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.