From: Tejun Heo <tj@kernel.org>
To: Akshat Jain <akshatzen@google.com>
Cc: Vishakha Channapattan <vishakhavc@google.com>,
linux-ide@vger.kernel.org, John Grass <jgrass@google.com>,
Thieu Le <thieule@google.com>,
linux-scsi@vger.kernel.org
Subject: Re: Question on ata_gen_passthru_sense interpretation of fixed format sense buffer
Date: Fri, 4 Sep 2020 13:07:56 -0400 [thread overview]
Message-ID: <20200904170756.GC4295@mtj.thefacebook.com> (raw)
In-Reply-To: <CACqKpR8i=9A6kb05yCyh39HMZ8aEhEGacXTCvQKyUS=nYkqRiQ@mail.gmail.com>
Hello,
On Tue, Aug 18, 2020 at 09:12:13PM -0700, Akshat Jain wrote:
> To answer your question:
> 1. Yes we will start working on a patch and send it for review.
> 2. We found this issue during our code review.
>
> Another information I need to bring to your attention is that many
> user libraries today decode the fixed format sense block based on the
> format today's kernel (ata_gen_passthru_sense) provides. Rather than
> the format specified in the SCSI Primary commands - 4 specification.
> If we were to correct the field offsets for the fixed format sense block.
> It may break such libraries. How do you assess the impact
> of such a change?
So, I don't know. Given that nobody tripped over it till now, I doubt fixing
it would cause a lot of trouble but at the same time it isn't a real
problem, again, given that nobody has tripped over it yet. Maybe just fix it
and see how it goes?
Thanks.
--
tejun
prev parent reply other threads:[~2020-09-04 18:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-03 16:44 Question on ata_gen_passthru_sense interpretation of fixed format sense buffer Akshat Jain
2020-08-17 17:18 ` Akshat Jain
2020-08-17 17:42 ` Tejun Heo
2020-08-19 4:12 ` Akshat Jain
2020-09-04 17:07 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200904170756.GC4295@mtj.thefacebook.com \
--to=tj@kernel.org \
--cc=akshatzen@google.com \
--cc=jgrass@google.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=thieule@google.com \
--cc=vishakhavc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.