From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01167C433E2 for ; Sat, 5 Sep 2020 16:07:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BA1F02086A for ; Sat, 5 Sep 2020 16:07:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="DXiRUtx7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728309AbgIEQHv (ORCPT ); Sat, 5 Sep 2020 12:07:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41604 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726261AbgIEQHt (ORCPT ); Sat, 5 Sep 2020 12:07:49 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80D3DC061244; Sat, 5 Sep 2020 09:07:48 -0700 (PDT) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id B6C3A335; Sat, 5 Sep 2020 18:07:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1599322057; bh=IB7aiNF5Sb4q/FXtKiMOEHFOQFRZ3n8rv9ArPIC44tk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DXiRUtx74nhKWsTE0dT3zhkPyvZLLHKqpS8m2WCGl5PGMiYJQEDpp0by3Ai2QEcw/ ewP2tHRhGjQnr2voRHeinE+hAayuvTUV4JfGTwM618+0kLicpIjgju2gQs4XWNjCxL v5QKfyk7CrN4Ats/cfMYBiHh2lhiwm3sd1/a9gIM= Date: Sat, 5 Sep 2020 19:07:14 +0300 From: Laurent Pinchart To: "Robert Chiras (OSS)" Cc: Rob Herring , Andrzej Hajda , Neil Armstrong , Jonas Karlman , Jernej Skrabec , Sam Ravnborg , Guido =?utf-8?Q?G=C3=BCnther?= , Fabio Estevam , Ondrej Jirman , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-imx@nxp.com Subject: Re: [PATCH 4/5] dt-bindings: display/bridge: nwl-dsi: Document fsl,clock-drop-level property Message-ID: <20200905160714.GA6319@pendragon.ideasonboard.com> References: <1598613212-1113-1-git-send-email-robert.chiras@oss.nxp.com> <1598613212-1113-5-git-send-email-robert.chiras@oss.nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1598613212-1113-5-git-send-email-robert.chiras@oss.nxp.com> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Robert, Thank you for the patch. On Fri, Aug 28, 2020 at 02:13:31PM +0300, Robert Chiras (OSS) wrote: > From: Robert Chiras > > Add documentation for a new property: 'fsl,clock-drop-level'. > > Signed-off-by: Robert Chiras > --- > Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml b/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml > index 8b5741b..b415f4e 100644 > --- a/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml > @@ -143,6 +143,10 @@ properties: > > additionalProperties: false > > + clock-drop-level: > + description: > + Specifies the level at wich the crtc_clock should be dropped > + There's no "crtc_clock" defined in the bindings. As DT bindings shouldn't be tied to a particular driver implementation, could you document this property without referring to concepts specific to the driver ? I think the documentation should also be extended, looking at this patch I have no idea what this does and how to compute the value that should be set. > patternProperties: > "^panel@[0-9]+$": > type: object -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9224BC43461 for ; Sat, 5 Sep 2020 16:07:43 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9869D2078E for ; Sat, 5 Sep 2020 16:07:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="DXiRUtx7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9869D2078E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DFA606E10E; Sat, 5 Sep 2020 16:07:41 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1A6D96E10E for ; Sat, 5 Sep 2020 16:07:40 +0000 (UTC) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id B6C3A335; Sat, 5 Sep 2020 18:07:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1599322057; bh=IB7aiNF5Sb4q/FXtKiMOEHFOQFRZ3n8rv9ArPIC44tk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DXiRUtx74nhKWsTE0dT3zhkPyvZLLHKqpS8m2WCGl5PGMiYJQEDpp0by3Ai2QEcw/ ewP2tHRhGjQnr2voRHeinE+hAayuvTUV4JfGTwM618+0kLicpIjgju2gQs4XWNjCxL v5QKfyk7CrN4Ats/cfMYBiHh2lhiwm3sd1/a9gIM= Date: Sat, 5 Sep 2020 19:07:14 +0300 From: Laurent Pinchart To: "Robert Chiras (OSS)" Subject: Re: [PATCH 4/5] dt-bindings: display/bridge: nwl-dsi: Document fsl,clock-drop-level property Message-ID: <20200905160714.GA6319@pendragon.ideasonboard.com> References: <1598613212-1113-1-git-send-email-robert.chiras@oss.nxp.com> <1598613212-1113-5-git-send-email-robert.chiras@oss.nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1598613212-1113-5-git-send-email-robert.chiras@oss.nxp.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ondrej Jirman , devicetree@vger.kernel.org, Jernej Skrabec , Jonas Karlman , David Airlie , Guido =?utf-8?Q?G=C3=BCnther?= , Neil Armstrong , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Andrzej Hajda , Rob Herring , linux-imx@nxp.com, Sam Ravnborg Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Robert, Thank you for the patch. On Fri, Aug 28, 2020 at 02:13:31PM +0300, Robert Chiras (OSS) wrote: > From: Robert Chiras > > Add documentation for a new property: 'fsl,clock-drop-level'. > > Signed-off-by: Robert Chiras > --- > Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml b/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml > index 8b5741b..b415f4e 100644 > --- a/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml > @@ -143,6 +143,10 @@ properties: > > additionalProperties: false > > + clock-drop-level: > + description: > + Specifies the level at wich the crtc_clock should be dropped > + There's no "crtc_clock" defined in the bindings. As DT bindings shouldn't be tied to a particular driver implementation, could you document this property without referring to concepts specific to the driver ? I think the documentation should also be extended, looking at this patch I have no idea what this does and how to compute the value that should be set. > patternProperties: > "^panel@[0-9]+$": > type: object -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel