From: Kees Cook <keescook@chromium.org>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: Nick Desaulniers <ndesaulniers@google.com>,
clang-built-linux <clang-built-linux@googlegroups.com>,
stable <stable@vger.kernel.org>, Andy Lavr <andy.lavr@gmail.com>,
Arvind Sankar <nivedita@alum.mit.edu>,
Joe Perches <joe@perches.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Sami Tolvanen <samitolvanen@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Alexandru Ardelean <alexandru.ardelean@analog.com>,
Yury Norov <yury.norov@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] lib/string.c: implement stpcpy
Date: Sun, 6 Sep 2020 02:57:27 -0700 [thread overview]
Message-ID: <202009060256.7CE5620A56@keescook> (raw)
In-Reply-To: <CAK7LNAQvQBhjYgSkvm-dVyNz2Jd2C2qAtfyRk-rngEDfjkc38g@mail.gmail.com>
On Thu, Aug 27, 2020 at 12:58:35AM +0900, Masahiro Yamada wrote:
> On Tue, Aug 25, 2020 at 10:58 PM Nick Desaulniers
> <ndesaulniers@google.com> wrote:
> > [...]
> > +/**
> > + * stpcpy - copy a string from src to dest returning a pointer to the new end
> > + * of dest, including src's %NUL-terminator. May overrun dest.
> > + * @dest: pointer to end of string being copied into. Must be large enough
> > + * to receive copy.
> > + * @src: pointer to the beginning of string being copied from. Must not overlap
> > + * dest.
> > + *
> > + * stpcpy differs from strcpy in a key way: the return value is the new
> > + * %NUL-terminated character. (for strcpy, the return value is a pointer to
> > + * src.
>
>
> return a pointer to src?
>
> "man 3 strcpy" says:
>
> The strcpy() and strncpy() functions return
> a pointer to the destination string *dest*.
Agreed; that's a typo.
--
Kees Cook
next prev parent reply other threads:[~2020-09-06 9:57 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-25 13:58 [PATCH v3] lib/string.c: implement stpcpy Nick Desaulniers
2020-08-25 18:51 ` Nathan Chancellor
2020-08-26 15:41 ` Sedat Dilek
2020-08-26 15:58 ` Masahiro Yamada
2020-09-06 9:57 ` Kees Cook [this message]
2020-08-26 16:49 ` Masahiro Yamada
2020-08-26 16:57 ` Joe Perches
2020-08-26 16:58 ` Nick Desaulniers
2020-08-26 22:59 ` Masahiro Yamada
2020-08-26 23:38 ` Kees Cook
2020-08-26 23:57 ` Joe Perches
2020-08-27 2:33 ` Kees Cook
2020-08-27 2:42 ` Joe Perches
2020-08-27 18:26 ` Kees Cook
2020-08-27 8:59 ` Andy Shevchenko
2020-08-27 18:30 ` Kees Cook
2020-08-27 19:37 ` Joe Perches
2020-08-27 19:41 ` Kees Cook
2020-08-27 20:05 ` Andy Shevchenko
2020-08-27 22:26 ` Kees Cook
2020-08-28 8:17 ` Andy Shevchenko
2020-08-31 23:21 ` Nick Desaulniers
2020-09-01 8:51 ` David Laight
-- strict thread matches above, loose matches on Subject: below --
2020-08-25 14:00 Nick Desaulniers
2020-08-26 15:22 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202009060256.7CE5620A56@keescook \
--to=keescook@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=alexandru.ardelean@analog.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.lavr@gmail.com \
--cc=clang-built-linux@googlegroups.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=masahiroy@kernel.org \
--cc=ndesaulniers@google.com \
--cc=nivedita@alum.mit.edu \
--cc=samitolvanen@google.com \
--cc=stable@vger.kernel.org \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.