From: Jonathan Cameron <jic23@kernel.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>, Zhang Rui <rui.zhang@intel.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Amit Kucheria <amitk@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-iio@vger.kernel.org
Subject: Re: [PATCH v2 5/9] iio: adc: qcom-spmi-adc5: fix driver name
Date: Sun, 6 Sep 2020 15:24:52 +0100 [thread overview]
Message-ID: <20200906152452.58f322db@archlinux> (raw)
In-Reply-To: <20200904111402.GC4056@mani>
On Fri, 4 Sep 2020 16:44:02 +0530
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> wrote:
> On 0903, Dmitry Baryshkov wrote:
> > Remove superfluous '.c' from qcom-spmi-adc5 device driver name.
> >
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>
> Please add Fixes tag, with that:
>
> Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Ouch. Technically this is ABI change, but given I'd hope anyone using
the name would have noticed the .c was odd and shouting about it I guess
no one is using it.
Could you pull this to the front of v3 (with fixes tag) so I can pick it up
for stable without having to deal with fuzz etc.
Thanks,
Jonathan
>
> Thanks,
> Mani
>
> > ---
> > drivers/iio/adc/qcom-spmi-adc5.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/iio/adc/qcom-spmi-adc5.c b/drivers/iio/adc/qcom-spmi-adc5.c
> > index 30b8867b31e4..c2da8f068b87 100644
> > --- a/drivers/iio/adc/qcom-spmi-adc5.c
> > +++ b/drivers/iio/adc/qcom-spmi-adc5.c
> > @@ -919,7 +919,7 @@ static int adc5_probe(struct platform_device *pdev)
> >
> > static struct platform_driver adc5_driver = {
> > .driver = {
> > - .name = "qcom-spmi-adc5.c",
> > + .name = "qcom-spmi-adc5",
> > .of_match_table = adc5_match_table,
> > },
> > .probe = adc5_probe,
> > --
> > 2.28.0
> >
next prev parent reply other threads:[~2020-09-06 14:27 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-03 13:21 [PATCH v2 0/0] qcom: pm8150: add support for thermal monitoring Dmitry Baryshkov
2020-09-03 13:21 ` [PATCH v2 1/9] dt-bindings: thermal: qcom: add adc-thermal monitor bindings Dmitry Baryshkov
2020-09-03 16:34 ` Rob Herring
2020-09-06 14:14 ` Jonathan Cameron
2020-09-03 13:21 ` [PATCH v2 2/9] fixp-arith: add a linear interpolation function Dmitry Baryshkov
2020-09-03 13:21 ` [PATCH v2 3/9] iio: adc: qcom-vadc: move several adc5 functions to common file Dmitry Baryshkov
2020-09-06 14:18 ` Jonathan Cameron
2020-09-03 13:21 ` [PATCH v2 4/9] iio: adc: qcom-vadc-common: use fixp_linear_interpolate Dmitry Baryshkov
2020-09-03 19:38 ` Andy Shevchenko
2020-09-06 14:23 ` Jonathan Cameron
2020-09-03 13:21 ` [PATCH v2 5/9] iio: adc: qcom-spmi-adc5: fix driver name Dmitry Baryshkov
2020-09-04 11:14 ` Manivannan Sadhasivam
2020-09-06 14:24 ` Jonathan Cameron [this message]
2020-09-03 13:21 ` [PATCH v2 6/9] iio: adc: qcom-spmi-adc5: use of_device_get_match_data Dmitry Baryshkov
2020-09-04 11:12 ` Manivannan Sadhasivam
2020-09-03 13:21 ` [PATCH v2 7/9] thermal: qcom: add support for adc-tm5 PMIC thermal monitor Dmitry Baryshkov
2020-09-06 14:45 ` Jonathan Cameron
2020-09-03 13:21 ` [PATCH v2 8/9] arm64: dts: qcom: pm8150x: add definitions for adc-tm5 part Dmitry Baryshkov
2020-09-03 13:21 ` [PATCH v2 9/9] arm64: dts: sm8250-mtp: add thermal zones using pmic's adc-tm5 Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200906152452.58f322db@archlinux \
--to=jic23@kernel.org \
--cc=agross@kernel.org \
--cc=amitk@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.