From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3336C43461 for ; Mon, 7 Sep 2020 10:44:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ACACF2166E for ; Mon, 7 Sep 2020 10:44:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728736AbgIGKoZ (ORCPT ); Mon, 7 Sep 2020 06:44:25 -0400 Received: from foss.arm.com ([217.140.110.172]:60618 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728406AbgIGKoX (ORCPT ); Mon, 7 Sep 2020 06:44:23 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 12B48106F; Mon, 7 Sep 2020 03:44:23 -0700 (PDT) Received: from bogus (unknown [10.57.10.112]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 471233F66E; Mon, 7 Sep 2020 03:44:20 -0700 (PDT) Date: Mon, 7 Sep 2020 11:44:18 +0100 From: Sudeep Holla To: Viresh Kumar Cc: Rikard Falkeborn , linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Sudeep Holla , "Rafael J. Wysocki" Subject: Re: [PATCH 1/3] cpufreq: arm_scmi: Constify scmi_perf_ops pointers Message-ID: <20200907104418.GC17330@bogus> References: <20200906230452.33410-1-rikard.falkeborn@gmail.com> <20200906230452.33410-2-rikard.falkeborn@gmail.com> <20200907102200.GB17330@bogus> <20200907102551.3f7zwrmd3uqthaxs@vireshk-i7> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200907102551.3f7zwrmd3uqthaxs@vireshk-i7> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Mon, Sep 07, 2020 at 03:55:51PM +0530, Viresh Kumar wrote: > On 07-09-20, 11:22, Sudeep Holla wrote: > > Hi Viresh, > > > > On Mon, Sep 07, 2020 at 01:04:50AM +0200, Rikard Falkeborn wrote: > > > The perf_ops are not modified through this pointer. Make them const to > > > indicate that. This is in preparation to make the scmi-ops pointers in > > > scmi_handle const. > > > > > > > Your ack needed to take this as series via {arm-,}soc > > Can I just pick the first patch and you do the rest ? Will it result > in any warnings at either end ? > Initially I thought out suggesting the same, but then I realised(not checked though), without this change in arm-soc the scmi-cpufreq driver might produce warnings as the const value gets assigned to non const. No ? -- Regards, Sudeep From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0003C433E2 for ; Mon, 7 Sep 2020 10:45:44 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1EC9220738 for ; Mon, 7 Sep 2020 10:45:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="227RodO0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1EC9220738 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hqikh/cGtAGb4em3mYenskeAPmtEd3977456T+aiCpc=; b=227RodO0Qxxq1IqVHPDyS0o8J r3PsRepztwf4k7tpNyAnm3wfjjXS6DOtTA2aj1KxxU2zEaQ0LVBzTVNkXLpQ7SPDcRnndRGAOl/eN 0nDLUMAsw19dViKM/8zbuWNz3bwdN3RpKDkIyKPKbXfOpyZ8udSuDlMNR86gwlLsgd2eFK+a4WYwZ nDgTG1BKgwoyRVTrGMZKtqCgMErmzCyInPobeG+JCzf3djmkJQy1zZN8YHdXGrv58xCOvK0+j3wNG lBigoxEhXZX7p9iIesSREOwkx8tg3WE958RDZgGXxK3TFXSGsOMBdNNU+c2zbUNDcWeufhEvxmFDy +j/YE4xNg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFEdO-000177-Nd; Mon, 07 Sep 2020 10:44:26 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFEdM-00016l-DY for linux-arm-kernel@lists.infradead.org; Mon, 07 Sep 2020 10:44:25 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 12B48106F; Mon, 7 Sep 2020 03:44:23 -0700 (PDT) Received: from bogus (unknown [10.57.10.112]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 471233F66E; Mon, 7 Sep 2020 03:44:20 -0700 (PDT) Date: Mon, 7 Sep 2020 11:44:18 +0100 From: Sudeep Holla To: Viresh Kumar Subject: Re: [PATCH 1/3] cpufreq: arm_scmi: Constify scmi_perf_ops pointers Message-ID: <20200907104418.GC17330@bogus> References: <20200906230452.33410-1-rikard.falkeborn@gmail.com> <20200906230452.33410-2-rikard.falkeborn@gmail.com> <20200907102200.GB17330@bogus> <20200907102551.3f7zwrmd3uqthaxs@vireshk-i7> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200907102551.3f7zwrmd3uqthaxs@vireshk-i7> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200907_064424_555503_4C885B12 X-CRM114-Status: GOOD ( 16.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pm@vger.kernel.org, "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, Rikard Falkeborn , Sudeep Holla , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 07, 2020 at 03:55:51PM +0530, Viresh Kumar wrote: > On 07-09-20, 11:22, Sudeep Holla wrote: > > Hi Viresh, > > > > On Mon, Sep 07, 2020 at 01:04:50AM +0200, Rikard Falkeborn wrote: > > > The perf_ops are not modified through this pointer. Make them const to > > > indicate that. This is in preparation to make the scmi-ops pointers in > > > scmi_handle const. > > > > > > > Your ack needed to take this as series via {arm-,}soc > > Can I just pick the first patch and you do the rest ? Will it result > in any warnings at either end ? > Initially I thought out suggesting the same, but then I realised(not checked though), without this change in arm-soc the scmi-cpufreq driver might produce warnings as the const value gets assigned to non const. No ? -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel