From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D143BC43461 for ; Mon, 7 Sep 2020 14:11:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9061B2064B for ; Mon, 7 Sep 2020 14:11:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599487899; bh=e1NrzKX/AI7LNPipSNQp264/D1Za/ZcFt4pINAUa0do=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=dEsPNOtE4B1CPPO43vYOvVDSNizr27OQDPEUIqpC6i7WZVYM44uMyqulB6ndAzsfX 58l7Sw4i+7lilZwfNUrzcVqTFNlLEG8T0OD0DDh8ymykzrd+fCx9kFTlFLf7Hon5vm DXHlTrhDbSHAxtjOGakfMCPw1z2Iygp9oi1Dx7DI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729690AbgIGOLB (ORCPT ); Mon, 7 Sep 2020 10:11:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:47874 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729779AbgIGOKt (ORCPT ); Mon, 7 Sep 2020 10:10:49 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5636E2064B; Mon, 7 Sep 2020 14:10:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599487843; bh=e1NrzKX/AI7LNPipSNQp264/D1Za/ZcFt4pINAUa0do=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Udt4MW4UsgJoY7imOEBnwxqYY0gF8VODhcPuSlcjDtAISEexshh/MiVm+5sK3yWdv jNBX6T92ly1GE+eE4yxx1zTZJUW+/oCs8DRD0o58iu2LKbxP6cL2re0vqLcMLlWUAd ghoJdeB1o3mpNRqhdAt30vdbMKoKMRdbJ62s3dFk= Date: Mon, 7 Sep 2020 16:10:58 +0200 From: Greg Kroah-Hartman To: Heikki Krogerus Cc: "Mani, Rajmohan" , linux-acpi@vger.kernel.org, Utkarsh Patel Subject: Re: [PATCH 2/2] usb: typec: intel_pmc_mux: Do not configure SBU and HSL Orientation in Alternate modes Message-ID: <20200907141058.GA3720524@kroah.com> References: <20200907135740.19941-1-heikki.krogerus@linux.intel.com> <20200907135740.19941-3-heikki.krogerus@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200907135740.19941-3-heikki.krogerus@linux.intel.com> Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Mon, Sep 07, 2020 at 04:57:40PM +0300, Heikki Krogerus wrote: > From: Utkarsh Patel > > According to the PMC Type C Subsystem (TCSS) Mux programming guide rev > 0.7, bits 4 and 5 are reserved in Alternate modes. > SBU Orientation and HSL Orientation needs to be configured only during > initial cable detection in USB connect flow based on device property of > "sbu-orientation" and "hsl-orientation". > Configuring these reserved bits in the Alternate modes may result in delay > in display link training or some unexpected behaviour. > So do not configure them while issuing Alternate Mode requests. > > Fixes: ff4a30d5e243 ("usb: typec: mux: intel_pmc_mux: Support for static SBU/HSL orientation") > Signed-off-by: Utkarsh Patel > Signed-off-by: Heikki Krogerus Shouldn't this also need a cc:stable? And why not cc: the linux-usb list on these patches? thanks, greg k-h