From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2124C433E2 for ; Tue, 8 Sep 2020 06:48:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7BCA721D46 for ; Tue, 8 Sep 2020 06:48:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599547712; bh=NO/usNhy16yhSKDVyBRRSAZoxSAHHglvXKFbsXtLhrk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=NDMhArAp+WNhCwKcqDy56VyLY090q/ldL3gXfOoSlYvI6cUH5/7ygtp6mEW761jvN Z8B6airORdIW9UI9BPUrCqVQqpFMUEgt5z9gY3H8i9o4586EZDLBizn2Z6/1VKF361 iGlB9FooG4m0vSQlsaeOcyvcOVy66Go2O7Fi9rPY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728991AbgIHGs3 (ORCPT ); Tue, 8 Sep 2020 02:48:29 -0400 Received: from mail-ej1-f65.google.com ([209.85.218.65]:44654 "EHLO mail-ej1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728759AbgIHGsR (ORCPT ); Tue, 8 Sep 2020 02:48:17 -0400 Received: by mail-ej1-f65.google.com with SMTP id r7so7546601ejs.11; Mon, 07 Sep 2020 23:48:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=VyiVf+Mq59UC5ZzKMYrAjFhEEKe4orUQbv2Dw6ICisQ=; b=Qt2OvcNIVdt78UW4jLDz6nktC9mUQL/abkGCyd41iCFp1dO1iDhVQgQ9KQRsFJIqP/ +cAXGjR8GXm/R8n8bNtHgtid78nlHpKhGzuVnXWukF1nyeyh+YVqzUegEZsPibxnna8y xW4SDv7DnqzXfBVK1RDpg19qGRllqHBskRWEmUsYZNbsFmSLjRqDtNw2IyDhbFw/6vGT roUdrWvMHfSgUc4Jv9/LEie8dJt8SPHrDQJ8bo6ZszAysLFS0cL/2qPDDv7BQRHCKSRc p8U0APQR6BqN0cqC1jphrNDbPejCgFwzVXKk29H97WHEJSEQ0jm9xFwT9ANcaKCMnBtT OCpg== X-Gm-Message-State: AOAM531vjY+lOC8/Xan29LgR+bvW9Qr6t7j52kfPWy/zg9i5PKIygj1X Qg8hInokSXw5h9zxQWLtLDA= X-Google-Smtp-Source: ABdhPJy61y/aCX2qNyKljrz5UJOWH8ADbK1AwDDzicWB2lQYIWTkbWIYURrKncOKjTAbVcUMp5Tlaw== X-Received: by 2002:a17:906:455:: with SMTP id e21mr25591439eja.170.1599547694870; Mon, 07 Sep 2020 23:48:14 -0700 (PDT) Received: from pi3 ([194.230.155.174]) by smtp.googlemail.com with ESMTPSA id j8sm16697525edp.58.2020.09.07.23.48.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Sep 2020 23:48:13 -0700 (PDT) Date: Tue, 8 Sep 2020 08:48:11 +0200 From: Krzysztof Kozlowski To: Jonathan Bakker Cc: Kukjin Kim , Rob Herring , Jonathan Cameron , Lars-Peter Clausen , Peter Meerwald-Stadler , =?utf-8?B?UGF3ZcWC?= Chmiel , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org Subject: Re: [PATCH 03/25] dt-bindings: iio: adc: exynos-adc: do not require syscon on S5Pv210 Message-ID: <20200908064811.GA24227@pi3> References: <20200907161141.31034-1-krzk@kernel.org> <20200907161141.31034-4-krzk@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Mon, Sep 07, 2020 at 02:49:49PM -0700, Jonathan Bakker wrote: > Looking at this again, it appears that there is actually control for > it at offset 0x6818 of pmu_syscon (0xe0108000) [1]. However, it defaults to > enabled so it's not required for proper use of the block. Whether it should > be present in the schema/DTS is up to you. Indeed the driver could turn off the ADC phy via syscon however bindings (before YAML conversion) explicitly were saying that it is not needed. I am not going to add it as I am not able to test the change and also adding such requirement would be a break of ABI (described by first TXT bindings). Best regards, Krzysztof > > Thanks, > Jonathan > > [1] https://android.googlesource.com/kernel/samsung/+/refs/heads/android-samsung-3.0-jb-mr0/arch/arm/mach-s5pv210/include/mach/regs-clock.h#325 > > On 2020-09-07 9:11 a.m., Krzysztof Kozlowski wrote: > > The ADC in S5Pv210 does not have ADC phy registers in separate block for > > which syscon would be needed. Remove this requirement to fix dtbs_check > > warnings like: > > > > arch/arm/boot/dts/s5pv210-fascinate4g.dt.yaml: adc@e1700000: 'samsung,syscon-phandle' is a required property > > > > Signed-off-by: Krzysztof Kozlowski > > --- > > .../devicetree/bindings/iio/adc/samsung,exynos-adc.yaml | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml > > index 89b4f9c252a6..75174af72288 100644 > > --- a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml > > +++ b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml > > @@ -81,7 +81,6 @@ allOf: > > - samsung,exynos-adc-v2 > > - samsung,exynos3250-adc > > - samsung,exynos4212-adc > > - - samsung,s5pv210-adc > > then: > > required: > > - samsung,syscon-phandle > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68E6DC2BBD0 for ; Tue, 8 Sep 2020 06:49:31 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 075D2218AC for ; Tue, 8 Sep 2020 06:49:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Td3DP0wX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 075D2218AC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LfydOogQXJL2h18y6kF4kY7naPGDM7aJwrevDMqBZPE=; b=Td3DP0wXUQ8TbyH+nrDNh1l7r dplFpvMix79eQvxk2XkcJ8OxK/gINLwbUPtq2RLFzCFvPfxTL8DQI3t5X8fIADN6up5rdYjKKTr5y ZrGFJh0ic1Fpx3ScvVJ9sA5nF/OxNknvR+feZer5SFP0GAI9/x5QBO+jS5vYDBVvXiYYEHE7weg5y 15ZkCsmiieuANmDMAtEKg7eKShlQaYgG8HsTnViD/j9uMfVh+97o/91/HoLZuMgfDHlatkiO+Wm2n hgb7HJeedxnyGUCPf0+3TWJlB8xCorMb6kn+siihky2BR6oZeTb2A0i08cXBb6tC7R1yRZWrl7NQk wlKK+a5KQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFXQS-0005GL-OL; Tue, 08 Sep 2020 06:48:20 +0000 Received: from mail-ej1-f68.google.com ([209.85.218.68]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFXQP-0005FH-NY for linux-arm-kernel@lists.infradead.org; Tue, 08 Sep 2020 06:48:18 +0000 Received: by mail-ej1-f68.google.com with SMTP id z22so20880280ejl.7 for ; Mon, 07 Sep 2020 23:48:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=VyiVf+Mq59UC5ZzKMYrAjFhEEKe4orUQbv2Dw6ICisQ=; b=oMFdl+uCH50Fr9/bJkzDww/5CqJHVEenAkh1LGSLDnnu1TXiiu44mYM4/JkZpiKOaw CSecBrAdh/MIZhs483NCUzLcsQ0T3foAFlazNI+AsiKBD6M9EQzZbd4JbEOzL5+9bArG Ol9zFQ54HeVHK7mdXiFo83WmbApPdjUL/hZMSMst4fUjYm62PwbjKIdxom5u1tcS7ZhX zqydjOpuX/6WTz9NBTpixqc2gDxpI5rODXb0V80fEpTiXzvdTe04sE+DBYzsVskXN4Pl RW/UclrhpeJQcFT2EJrpc0T2c6Ex+kCjX5Hze308tTQ7b5q8eHoQDVY3X1nFmDKf9+CM KAUw== X-Gm-Message-State: AOAM533lRhWbwb+AuUa5phhhtT93PZtikhA79wttd+O0+grJm6EyU34U rFnBd8LWHm+TTY9p3rwX/3o= X-Google-Smtp-Source: ABdhPJy61y/aCX2qNyKljrz5UJOWH8ADbK1AwDDzicWB2lQYIWTkbWIYURrKncOKjTAbVcUMp5Tlaw== X-Received: by 2002:a17:906:455:: with SMTP id e21mr25591439eja.170.1599547694870; Mon, 07 Sep 2020 23:48:14 -0700 (PDT) Received: from pi3 ([194.230.155.174]) by smtp.googlemail.com with ESMTPSA id j8sm16697525edp.58.2020.09.07.23.48.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Sep 2020 23:48:13 -0700 (PDT) Date: Tue, 8 Sep 2020 08:48:11 +0200 From: Krzysztof Kozlowski To: Jonathan Bakker Subject: Re: [PATCH 03/25] dt-bindings: iio: adc: exynos-adc: do not require syscon on S5Pv210 Message-ID: <20200908064811.GA24227@pi3> References: <20200907161141.31034-1-krzk@kernel.org> <20200907161141.31034-4-krzk@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200908_024817_787363_02BE194C X-CRM114-Status: GOOD ( 22.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Lars-Peter Clausen , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , linux-samsung-soc@vger.kernel.org, Kukjin Kim , linux-arm-kernel@lists.infradead.org, Peter Meerwald-Stadler , Jonathan Cameron , =?utf-8?B?UGF3ZcWC?= Chmiel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 07, 2020 at 02:49:49PM -0700, Jonathan Bakker wrote: > Looking at this again, it appears that there is actually control for > it at offset 0x6818 of pmu_syscon (0xe0108000) [1]. However, it defaults to > enabled so it's not required for proper use of the block. Whether it should > be present in the schema/DTS is up to you. Indeed the driver could turn off the ADC phy via syscon however bindings (before YAML conversion) explicitly were saying that it is not needed. I am not going to add it as I am not able to test the change and also adding such requirement would be a break of ABI (described by first TXT bindings). Best regards, Krzysztof > > Thanks, > Jonathan > > [1] https://android.googlesource.com/kernel/samsung/+/refs/heads/android-samsung-3.0-jb-mr0/arch/arm/mach-s5pv210/include/mach/regs-clock.h#325 > > On 2020-09-07 9:11 a.m., Krzysztof Kozlowski wrote: > > The ADC in S5Pv210 does not have ADC phy registers in separate block for > > which syscon would be needed. Remove this requirement to fix dtbs_check > > warnings like: > > > > arch/arm/boot/dts/s5pv210-fascinate4g.dt.yaml: adc@e1700000: 'samsung,syscon-phandle' is a required property > > > > Signed-off-by: Krzysztof Kozlowski > > --- > > .../devicetree/bindings/iio/adc/samsung,exynos-adc.yaml | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml > > index 89b4f9c252a6..75174af72288 100644 > > --- a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml > > +++ b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml > > @@ -81,7 +81,6 @@ allOf: > > - samsung,exynos-adc-v2 > > - samsung,exynos3250-adc > > - samsung,exynos4212-adc > > - - samsung,s5pv210-adc > > then: > > required: > > - samsung,syscon-phandle > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel