From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EB8EC43461 for ; Tue, 8 Sep 2020 06:57:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4FFA32068D for ; Tue, 8 Sep 2020 06:57:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599548251; bh=o6mAew2lMKKYAMTkRd6PG3NmJjMJBBmt33Nluw5zleA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=OVQbCHVZ61LXfJhylMn8bvslExAEz6+A4B6NZAypbpNOV3EwDsjkionB7lA1leA2R XVjhT96T8s9FSWXPgn/gL/M3EsotXA/SI+dnSMWb/3jnwITWhxHNKfmgTv+vc6biky 9clhqT45YmG0w+rwtr1MYYSqWR0Q69DyURcUJrGI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729053AbgIHG5a (ORCPT ); Tue, 8 Sep 2020 02:57:30 -0400 Received: from mail-ed1-f47.google.com ([209.85.208.47]:43807 "EHLO mail-ed1-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728501AbgIHG52 (ORCPT ); Tue, 8 Sep 2020 02:57:28 -0400 Received: by mail-ed1-f47.google.com with SMTP id n13so14848751edo.10; Mon, 07 Sep 2020 23:57:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=umGp2mRac5tjGgvL1953FmzEeKMsaUQqM0ZLASNYOdw=; b=N5fqJEZG7B7/XsNoynwNGrDwdYwKYI0k2+m058IJt7fmvML1HP74NBozLoAOSuJK1a QPFpJVVmpyIlvq5Y0cI2TTLsDuegaDqEDlZwjQMCeEgs+4tQnMrxhQL8BKvRCMYTyszE lFBbhusQq3/GjDc+QrmRifs8YIDN1mOAjgyQkPkNt8gkWt9+9O3I7yuzW1g29FiW33nK 9REI+OURjC44wtMREFGCFzB62qT90llzw7ot+twtQfDpBaBip1oDxdp2pSf4GI5LxiH2 MOKW/v7Y5/MRIqXnnGiWqXbbhOvkzZtJZN+G+YZro5cQXTsWexgcSPxyNP47RFaW1px/ xFHg== X-Gm-Message-State: AOAM533WY4OCuvvxLNCeQi+p5tOkd5iX618ycdMOipkav38oIAchdgBC /5hum4UfFtx126vxWkw9SP0= X-Google-Smtp-Source: ABdhPJwQKk7dDYAUqS1F8cS+l02dQ8Fkn0v4UEjEo7y2l4To8N85pyzNNjSurB/LEnao9OgD3/0vtw== X-Received: by 2002:a05:6402:1859:: with SMTP id v25mr16745883edy.118.1599548245356; Mon, 07 Sep 2020 23:57:25 -0700 (PDT) Received: from pi3 ([194.230.155.174]) by smtp.googlemail.com with ESMTPSA id r16sm8407822edc.57.2020.09.07.23.57.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Sep 2020 23:57:24 -0700 (PDT) Date: Tue, 8 Sep 2020 08:57:22 +0200 From: Krzysztof Kozlowski To: Jonathan Bakker Cc: Kukjin Kim , Rob Herring , Jonathan Cameron , Lars-Peter Clausen , Peter Meerwald-Stadler , =?utf-8?B?UGF3ZcWC?= Chmiel , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org Subject: Re: [RFT 25/25] ARM: dts: s5pv210: align DMA channels with dtschema Message-ID: <20200908065722.GD24227@pi3> References: <20200907161141.31034-1-krzk@kernel.org> <20200907161141.31034-26-krzk@kernel.org> <25178674-e4af-ba35-b7f0-42091208e0e8@live.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Mon, Sep 07, 2020 at 05:28:54PM -0700, Jonathan Bakker wrote: > Ah, I figured out why the dma stopped working. In s5pv210-aries.dtsi the dma's for i2s0 > are overriden to use pdma0 instead of pdma1. That also needs changing for this to > work properly. Indeed I missed this, thanks for review and tests. Best regards, Krzysztof > > Thanks, > Jonathan > > On 2020-09-07 5:17 p.m., Jonathan Bakker wrote: > > Initial testing on both an i9000 and an SGH-T959P are showing that the audio has > > stopped working with this. I'm not 100% convinced as I've had DMA issues in the > > past. However trying to play something just results in a hang after 1.5s while > > it works just fine without this patch. > > > > Thanks, > > Jonathan From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC756C2BBD0 for ; Tue, 8 Sep 2020 06:58:39 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 45510218AC for ; Tue, 8 Sep 2020 06:58:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="SW/7/c+R" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 45510218AC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=UUmbnfDhg7+I0P7QUC2dXsjMPClNvAVquwnqjL1YpCI=; b=SW/7/c+RzaHnpggM8bpUdTPjK XEaYMDsf0NjrMfzkVQbE9kOj3+wQIUZ2Yg+OZuxjwKBQLkHQ6l67odAUQo18AH2n74ceXbg9Gb4dy XcNlF/A2UBnJq+WSVx8tMcuzjKcXxE4z7nNB+FBPeE0+y0r1qObTRDxWdzmVnj3+oQFabKMDu6xsj QrCUW1yBt9kWZLHD0nugdQXRdfMJk7Z7Q59IbN8D/qcfh7qbwVvu4peokCMtpeVuoU7cYqRxRRFBg OOSiYtoIZb+1F344zZy92C9LjwQL+EHf8YE+m0GcrYXm2AO5bzhcJf+mYI5BvGtvwAKmv0F+Kz/yA 9dBrcw5MQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFXZI-0006lU-H1; Tue, 08 Sep 2020 06:57:28 +0000 Received: from mail-ed1-f50.google.com ([209.85.208.50]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFXZG-0006kr-IA for linux-arm-kernel@lists.infradead.org; Tue, 08 Sep 2020 06:57:27 +0000 Received: by mail-ed1-f50.google.com with SMTP id b12so14828084edz.11 for ; Mon, 07 Sep 2020 23:57:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=umGp2mRac5tjGgvL1953FmzEeKMsaUQqM0ZLASNYOdw=; b=A/A49ms8LOZvp/ebGd5nV98TTha5mOo9sgUJSGfxmHkNwheIPQRnFU0O8bMJw1ejdt D74JYk+yu/dHnfnl/rALtIZv7pp84A8JnueMwnovBm/VgVm7UDjXs6Yc8/S+vb7bFoXC 0RFDoukaiVIy7mkWbXIKuM08foUh4I+26KyHfs+LHpVMfUHHin3XjNwB3zg0mJ3ikc72 p46OBUs2C8ZS38JbWuUSpMjZE1I50WJ5dA9Dr6BfOkcFXTx0L3hFQxmIGgTG+gmSlIUC fUepYVmYD310cD8nOIEtjZlrDP7rNoT2BTrEkavA0yZ71+nNnu3iyFsrAn405MKEbxCT IagA== X-Gm-Message-State: AOAM533X2jfjwSQbDWTN1f9R8MkPO1a3WGQxqWXk0zEQ3Sh8fIbPmMX5 uIQlHfH0bPeF6qfNNQqZ81Q= X-Google-Smtp-Source: ABdhPJwQKk7dDYAUqS1F8cS+l02dQ8Fkn0v4UEjEo7y2l4To8N85pyzNNjSurB/LEnao9OgD3/0vtw== X-Received: by 2002:a05:6402:1859:: with SMTP id v25mr16745883edy.118.1599548245356; Mon, 07 Sep 2020 23:57:25 -0700 (PDT) Received: from pi3 ([194.230.155.174]) by smtp.googlemail.com with ESMTPSA id r16sm8407822edc.57.2020.09.07.23.57.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Sep 2020 23:57:24 -0700 (PDT) Date: Tue, 8 Sep 2020 08:57:22 +0200 From: Krzysztof Kozlowski To: Jonathan Bakker Subject: Re: [RFT 25/25] ARM: dts: s5pv210: align DMA channels with dtschema Message-ID: <20200908065722.GD24227@pi3> References: <20200907161141.31034-1-krzk@kernel.org> <20200907161141.31034-26-krzk@kernel.org> <25178674-e4af-ba35-b7f0-42091208e0e8@live.ca> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200908_025726_621561_5787AAB9 X-CRM114-Status: GOOD ( 17.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Lars-Peter Clausen , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , linux-samsung-soc@vger.kernel.org, Kukjin Kim , linux-arm-kernel@lists.infradead.org, Peter Meerwald-Stadler , Jonathan Cameron , =?utf-8?B?UGF3ZcWC?= Chmiel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 07, 2020 at 05:28:54PM -0700, Jonathan Bakker wrote: > Ah, I figured out why the dma stopped working. In s5pv210-aries.dtsi the dma's for i2s0 > are overriden to use pdma0 instead of pdma1. That also needs changing for this to > work properly. Indeed I missed this, thanks for review and tests. Best regards, Krzysztof > > Thanks, > Jonathan > > On 2020-09-07 5:17 p.m., Jonathan Bakker wrote: > > Initial testing on both an i9000 and an SGH-T959P are showing that the audio has > > stopped working with this. I'm not 100% convinced as I've had DMA issues in the > > past. However trying to play something just results in a hang after 1.5s while > > it works just fine without this patch. > > > > Thanks, > > Jonathan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel