From: Oscar Salvador <osalvador@suse.de>
To: "HORIGUCHI NAOYA(堀口 直也)" <naoya.horiguchi@nec.com>
Cc: "yaoaili126@163.com" <yaoaili126@163.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"YANGFENG1@kingsoft.com" <YANGFENG1@kingsoft.com>,
Aili Yao <yaoaili@kingsoft.com>,
"willy@infradead.org" <willy@infradead.org>
Subject: Re: [PATCH] Fix incorrect compound page flags store
Date: Tue, 8 Sep 2020 09:26:13 +0200 [thread overview]
Message-ID: <20200908072603.GA11245@linux> (raw)
In-Reply-To: <20200908070210.GA14393@hori.linux.bs1.fc.nec.co.jp>
On Tue, Sep 08, 2020 at 07:02:12AM +0000, HORIGUCHI NAOYA(堀口 直也) wrote:
> On Mon, Sep 07, 2020 at 08:44:42PM -0700, yaoaili126@163.com wrote:
> > From: Aili Yao <yaoaili@kingsoft.com>
> >
> > PageHuge(p) branch will never be true,but for compound page we need to set page_flags to correct value.
> >
> > Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> > Signed-off-by: Yang Feng < yangfeng1@kingsoft.com>
> > Signed-off-by: Aili Yao <yaoaili@kingsoft.com>
>
> I found that this PageHuge() check is removed and no long exists
> in the latest mmotm, so we don't have worry about it.
I might be missing something, so bear with me.
It is true that the PageHuge check is gone, but we are storing the page's
flags in page_flags, even if the page is a tail (e.g: part of a compound page
).
Should not we store heads' flags instead?
AFAICS, hpage contains either the head of the compound page,
or the page itself in case it is a normal page.
--
Oscar Salvador
SUSE L3
next prev parent reply other threads:[~2020-09-08 7:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-08 3:44 [PATCH] Fix incorrect compound page flags store yaoaili126
2020-09-08 7:02 ` HORIGUCHI NAOYA(堀口 直也)
2020-09-08 7:18 ` yaoaili [么爱利]
2020-09-08 7:26 ` Oscar Salvador [this message]
2020-09-08 8:02 ` yaoaili [么爱利]
2020-09-08 8:09 ` Oscar Salvador
2020-09-08 8:36 ` HORIGUCHI NAOYA(堀口 直也)
2020-09-08 8:48 ` yaoaili [么爱利]
2020-09-08 9:00 ` HORIGUCHI NAOYA(堀口 直也)
2020-09-08 9:10 ` yaoaili [么爱利]
2020-09-08 8:51 ` Oscar Salvador
2020-09-08 9:05 ` HORIGUCHI NAOYA(堀口 直也)
2020-09-18 9:35 ` Oscar Salvador
2020-09-25 1:18 ` HORIGUCHI NAOYA(堀口 直也)
2020-09-25 1:55 ` yaoaili [么爱利]
2020-09-25 4:35 ` HORIGUCHI NAOYA(堀口 直也)
2020-09-25 5:52 ` yaoaili [么爱利]
-- strict thread matches above, loose matches on Subject: below --
2020-09-02 11:24 [PATCH] fix " yaoaili [么爱利]
2020-09-02 11:35 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200908072603.GA11245@linux \
--to=osalvador@suse.de \
--cc=YANGFENG1@kingsoft.com \
--cc=linux-mm@kvack.org \
--cc=naoya.horiguchi@nec.com \
--cc=willy@infradead.org \
--cc=yaoaili126@163.com \
--cc=yaoaili@kingsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.