From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
To: unlisted-recipients:; (no To-header on input)
Cc: linuxarm@huawei.com, mauro.chehab@huawei.com,
John Stultz <john.stultz@linaro.org>,
Manivannan Sadhasivam <mani@kernel.org>,
Felipe Balbi <balbi@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 10/11] dwc3-of-simple: add support for Hikey 970
Date: Tue, 8 Sep 2020 08:53:07 +0200 [thread overview]
Message-ID: <20200908085307.2c25657b@coco.lan> (raw)
In-Reply-To: <83393769e4391d038c4ab69a67ac77e2ca34efd4.1599493845.git.mchehab+huawei@kernel.org>
Em Mon, 7 Sep 2020 17:59:34 +0200
Mauro Carvalho Chehab <mchehab+huawei@kernel.org> escreveu:
> diff --git a/drivers/usb/dwc3/dwc3-of-simple.c b/drivers/usb/dwc3/dwc3-of-simple.c
> index 8852fbfdead4..2d497165efe2 100644
> --- a/drivers/usb/dwc3/dwc3-of-simple.c
> +++ b/drivers/usb/dwc3/dwc3-of-simple.c
> @@ -49,7 +49,8 @@ static int dwc3_of_simple_probe(struct platform_device *pdev)
> * Some controllers need to toggle the usb3-otg reset before trying to
> * initialize the PHY, otherwise the PHY times out.
> */
> - if (of_device_is_compatible(np, "rockchip,rk3399-dwc3"))
> + if (of_device_is_compatible(np, "rockchip,rk3399-dwc3") ||
> + of_device_is_compatible(np, "hisilicon,hi3670-dwc3"))
> simple->need_reset = true;
It turns that this hunk caused Serror during my suspend/resume tests.
Without this one, the driver works just fine.
As you already applied this patch, do you prefer a patch dropping it,
or should I send a version 2 without it?
Thanks,
Mauro
next prev parent reply other threads:[~2020-09-08 6:53 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 15:59 [PATCH v2 00/11] Add USB support for Hikey 970 Mauro Carvalho Chehab
2020-09-07 15:59 ` Mauro Carvalho Chehab
2020-09-07 15:59 ` [PATCH v2 01/11] phy: hisilicon: add USB physical layer for Kirin 3670 Mauro Carvalho Chehab
2020-09-07 15:59 ` [PATCH v2 02/11] phy: hisilicon: phy-hi3670-usb3: fix some issues at the init code Mauro Carvalho Chehab
2020-09-07 15:59 ` [PATCH v2 03/11] phy: hisilicon: phy-hi3670-usb3: use a consistent namespace Mauro Carvalho Chehab
2020-09-07 15:59 ` [PATCH v2 04/11] phy: hisilicon: phy-hi3670-usb3: fix coding style Mauro Carvalho Chehab
2020-09-07 15:59 ` [PATCH v2 05/11] phy: hisilicon: phy-hi3670-usb3: change some DT properties Mauro Carvalho Chehab
2020-09-07 15:59 ` [PATCH v2 06/11] dt-bindings: phy: convert phy-kirin970-usb3.txt to yaml Mauro Carvalho Chehab
2020-09-07 15:59 ` [PATCH v2 07/11] MAINTAINERS: add myself as maintainer for Kirin 970 USB PHY Mauro Carvalho Chehab
2020-09-07 15:59 ` [PATCH v2 08/11] misc: hisi_hikey_usb: Driver to support onboard USB gpio hub on Hikey960 Mauro Carvalho Chehab
2020-09-09 8:35 ` Greg Kroah-Hartman
2020-09-09 8:44 ` Mauro Carvalho Chehab
2020-09-09 9:55 ` Mauro Carvalho Chehab
2020-09-09 18:15 ` Greg Kroah-Hartman
2020-09-07 15:59 ` [PATCH v2 09/11] misc: hisi_hikey_usb: add support for Hikey 970 Mauro Carvalho Chehab
2020-09-07 15:59 ` [PATCH v2 10/11] dwc3-of-simple: " Mauro Carvalho Chehab
2020-09-08 6:02 ` Felipe Balbi
2020-09-08 6:53 ` Mauro Carvalho Chehab [this message]
2020-09-08 7:45 ` Felipe Balbi
2020-09-07 15:59 ` [PATCH v2 11/11] dts: hisilicon: add support for USB3 on " Mauro Carvalho Chehab
2020-09-07 15:59 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200908085307.2c25657b@coco.lan \
--to=mchehab+huawei@kernel.org \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=mani@kernel.org \
--cc=mauro.chehab@huawei.com \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.