All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
Cc: "kbusch@kernel.org" <kbusch@kernel.org>,
	"logang@deltatee.com" <logang@deltatee.com>,
	Christoph Hellwig <hch@lst.de>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	"sagi@grimberg.me" <sagi@grimberg.me>
Subject: Re: [PATCH V2 01/12] nvme-core: annotate nvme_alloc_request()
Date: Tue, 8 Sep 2020 10:57:34 +0200	[thread overview]
Message-ID: <20200908085734.GA17982@lst.de> (raw)
In-Reply-To: <BYAPR04MB49658D024946E9510B9C71FD862C0@BYAPR04MB4965.namprd04.prod.outlook.com>

On Thu, Sep 03, 2020 at 07:40:14PM +0000, Chaitanya Kulkarni wrote:
> On 9/3/20 09:17, Christoph Hellwig wrote:
> > Before we start micro-optimzing this stuff I suspect we might want
> > to just split the submit_cmd handlers so that we have a fast path
> > and the rest.  We've grown a few too many arguments by now..
> > 
> 
> Are you referring to any of this :-
> 
> 1. Split nvmet_passthru_execute_cmd() into
>     nvmet_passthru_execute_io_cmd() and
>     nvmet_passthru_execute_admin_cmd() handler just like as bdev-ns and
>     file-ns. (I don't think so that is what you mean).
> 
> OR
> 
> 2. Split the nvme_alloc_request() into nvme_alloc_request_qid_any() and
>     nvme_alloc_request_qid() then call nvme_alloc_request_qid_any() from
>     passthru fast path ? (or variation of the same).
> 
> OR
> 
> Can you please elaborate how you like to have a split ?

I'm not really sure yet, I just noticed that we created a convoluted
mess.  I'll see what I can do.

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

  reply	other threads:[~2020-09-08  8:57 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-31 22:26 [PATCH V2 00/12] nvmet: passthru fixes and improvements Chaitanya Kulkarni
2020-08-31 22:26 ` [PATCH V2 01/12] nvme-core: annotate nvme_alloc_request() Chaitanya Kulkarni
2020-09-01  1:56   ` Baolin Wang
2020-09-01 17:21     ` Sagi Grimberg
2020-09-01 21:16       ` Chaitanya Kulkarni
2020-09-02  3:28       ` Chaitanya Kulkarni
2020-09-02 22:02       ` Chaitanya Kulkarni
2020-09-03 16:17   ` Christoph Hellwig
2020-09-03 19:40     ` Chaitanya Kulkarni
2020-09-08  8:57       ` Christoph Hellwig [this message]
2020-08-31 22:26 ` [PATCH V2 02/12] nvmet: for pt I/O commands use likely for ns check Chaitanya Kulkarni
2020-09-03 16:18   ` Christoph Hellwig
2020-09-03 18:21     ` Chaitanya Kulkarni
2020-08-31 22:26 ` [PATCH V2 03/12] nvmet: use consistent type with id->nlbaf Chaitanya Kulkarni
2020-09-01 15:55   ` Keith Busch
2020-09-01 21:17     ` Chaitanya Kulkarni
2020-09-01 21:31       ` Logan Gunthorpe
2020-09-01 22:03       ` Keith Busch
2020-08-31 22:26 ` [PATCH V2 04/12] nvmet: use consistent type for op_flag Chaitanya Kulkarni
2020-09-03 16:20   ` Christoph Hellwig
2020-09-03 18:35     ` Chaitanya Kulkarni
2020-08-31 22:27 ` [PATCH V2 05/12] nvmet: use unlikely for uncommon commands Chaitanya Kulkarni
2020-09-03 16:20   ` Christoph Hellwig
2020-09-03 18:37     ` Chaitanya Kulkarni
2020-08-31 22:27 ` [PATCH V2 06/12] nvmet: remove op_flags for write commands Chaitanya Kulkarni
2020-08-31 22:27 ` [PATCH V2 07/12] nvmet: decouple nvme_ctrl_get_by_path() Chaitanya Kulkarni
2020-09-01 17:00   ` Logan Gunthorpe
2020-08-31 22:27 ` [PATCH V2 08/12] nvmet: move get/put ctrl into dev open/release Chaitanya Kulkarni
2020-09-01 17:02   ` Logan Gunthorpe
2020-09-01 17:18     ` Sagi Grimberg
2020-09-02  0:31       ` Chaitanya Kulkarni
2020-09-03 16:21       ` Christoph Hellwig
2020-09-03 18:22         ` Chaitanya Kulkarni
2020-08-31 22:27 ` [PATCH V2 09/12] nvmet: fix nvme module ref count Oops Chaitanya Kulkarni
2020-09-01 17:23   ` Logan Gunthorpe
2020-08-31 22:27 ` [PATCH V2 10/12] block: move blk_rq_bio_prep() to linux/blk-mq.h Chaitanya Kulkarni
2020-08-31 22:27 ` [PATCH V2 11/12] nvmet: use minimized version of blk_rq_append_bio Chaitanya Kulkarni
2020-09-03 16:23   ` Christoph Hellwig
2020-09-03 18:23     ` Chaitanya Kulkarni
2020-08-31 22:27 ` [PATCH V2 12/12] nvmet: use inline bio for passthru fast path Chaitanya Kulkarni
2020-09-01 17:29   ` Logan Gunthorpe
2020-09-02  0:39     ` Chaitanya Kulkarni
2020-09-02 15:41       ` Logan Gunthorpe
2020-09-02 21:04         ` Chaitanya Kulkarni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200908085734.GA17982@lst.de \
    --to=hch@lst.de \
    --cc=Chaitanya.Kulkarni@wdc.com \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=logang@deltatee.com \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.