From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Martin Willi <martin@strongswan.org>
Cc: netfilter-devel@vger.kernel.org, netdev@vger.kernel.org,
Florent Fourcot <florent.fourcot@wifirst.fr>,
Romain Bellan <romain.bellan@wifirst.fr>
Subject: Re: [PATCH nf] netfilter: ctnetlink: fix mark based dump filtering regression
Date: Tue, 8 Sep 2020 11:56:16 +0200 [thread overview]
Message-ID: <20200908095616.GA3446@salvia> (raw)
In-Reply-To: <20200901065619.4484-1-martin@strongswan.org>
On Tue, Sep 01, 2020 at 08:56:19AM +0200, Martin Willi wrote:
> conntrack mark based dump filtering may falsely skip entries if a mask
> is given: If the mask-based check does not filter out the entry, the
> else-if check is always true and compares the mark without considering
> the mask. The if/else-if logic seems wrong.
>
> Given that the mask during filter setup is implicitly set to 0xffffffff
> if not specified explicitly, the mark filtering flags seem to just
> complicate things. Restore the previously used approach by always
> matching against a zero mask is no filter mark is given.
Applied, thanks.
prev parent reply other threads:[~2020-09-08 9:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 6:56 [PATCH nf] netfilter: ctnetlink: fix mark based dump filtering regression Martin Willi
2020-09-08 9:56 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200908095616.GA3446@salvia \
--to=pablo@netfilter.org \
--cc=florent.fourcot@wifirst.fr \
--cc=martin@strongswan.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=romain.bellan@wifirst.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.