Re: [PATCH] 9pfs: disable msize warning for synth driver

[Greg Kurz <groug@kaod.org>]

On Mon, 7 Sep 2020 14:27:19 +0200
Greg Kurz <groug@kaod.org> wrote:

> On Mon, 07 Sep 2020 13:55:52 +0200
> Christian Schoenebeck <qemu_oss@crudebyte.com> wrote:
> 
> > On Montag, 7. September 2020 11:57:58 CEST Greg Kurz wrote:
> > > On Sun, 6 Sep 2020 18:50:32 +0200
> > > 
> > > Christian Schoenebeck <qemu_oss@crudebyte.com> wrote:
> > > > Previous patch introduced a performance warning being logged on host
> > > > side if client connected with an 'msize' <= 8192. Disable this
> > > > performance warning for the synth driver to prevent that warning from
> > > > being printed whenever the 9pfs (qtest) test cases are running.
> > > > 
> > > > Introduce a new export flag V9FS_NO_PERF_WARN for that purpose, which
> > > > might also be used to disable such warnings from the CLI in future.
> > > > 
> > > > We could have also prevented the warning by simply raising P9_MAX_SIZE
> > > > in virtio-9p-test.c to any value larger than 8192, however in the
> > > > context of test cases it makes sense running for edge cases, which
> > > > includes the lowest 'msize' value supported by the server which is
> > > > 4096, hence we want to preserve an msize of 4096 for the test client.
> > > > 
> > > > Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
> > > > ---
> > > 
> > > Heh, yes I guess it makes sense :)
> > > 
> > > I guess you could maybe queue this patch before the other one.
> > > 
> > > Reviewed-by: Greg Kurz <groug@kaod.org>
> > 
> > Thanks!
> > 
> > BTW, have you ever tried dealing with patchwork client's 'state' feature for 
> > already transmited patches on the list (new, rejected, etc.)?
> > 
> 
> Nope, never used patchwork's state at all and I've no idea on how it
> works... but I can ask to my former IBM colleagues at Ozlabs.
> 

It seems that you need to be a "maintainer" from a patchwork standpoint
to manipulate patch states.

https://patchwork.readthedocs.io/en/latest/usage/overview/#maintainers

===========
Maintainers

Maintainers are a special type of user that with permissions to do
certain operations that regular Patchwork users can’t. Patchwork
maintainers usually have a 1:1 mapping with a project’s code
maintainers though this is not necessary.

The operations that a maintainer can invoke include:

    Change the state of a patch
    Archive a patch
    Delegate a patch, or be delegated a patch
===========

No clue how to upgrade to maintainer though...

> > Not that there were many 9p patches for actually needing that; just curious if 
> > that's an LKML only feature.
> > 
> > Best regards,
> > Christian Schoenebeck
> > 
> > 
>