All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Carstens <hca@linux.ibm.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Vasily Gorbik <gor@linux.ibm.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Harald Freudenberger <freude@linux.ibm.com>,
	linux-s390@vger.kernel.org
Subject: Re: set_fs removal for s390
Date: Tue, 8 Sep 2020 14:26:37 +0200	[thread overview]
Message-ID: <20200908122637.GB14136@osiris> (raw)
In-Reply-To: <20200908063133.GA14217@lst.de>

On Tue, Sep 08, 2020 at 08:31:33AM +0200, Christoph Hellwig wrote:
> Hi s390 maintainers,
> 
> the base work to remove address space overrides using set_fs() has
> landed in linux-next through this tree:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git/log/?h=base.set_fs
> 
> and in addition to x86 and powerpc converted there, we have arm, arm64
> and RISC-V conversion in progress.  That means s390 is the only "tier 1"
> architecture still missing.  Due to the special instructions for
> accessing the user space address space I don't really feel like doing
> the conversion myself, but it would be great if we could get s390 done
> for 5.10 as well.
> 
> The rought TODO list is:
>  (1) actually stop using set_fs in the zrcypt driver.  I could prepare
>      a crude untested patch for that if it helps.

Hmm.. Harald's initial implementation years ago was without set_fs(),
if I remember correctly, and then he was talked into using set_fs() ;)

Harald, can you take care of this part?

>  (2) implement the __get_user_nofault and __put_user_nofault helpers to
>      safely access kernel memory.  These should behave like
>      get_user/put_user under set_fs(KERNEL_DS), but not actually
>      manipulate any task state to do so
>  (3) unselect CONFIG_SET_FS and remove all the code related to overriding
>      the address space(3) unselect CONFIG_SET_FS and remove all the code
>      related to overriding the address space limit

Ok, I guess everything will have to land in vfs.git then.

  reply	other threads:[~2020-09-08 15:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-08  6:31 set_fs removal for s390 Christoph Hellwig
2020-09-08 12:26 ` Heiko Carstens [this message]
2020-09-08 12:28   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200908122637.GB14136@osiris \
    --to=hca@linux.ibm.com \
    --cc=borntraeger@de.ibm.com \
    --cc=freude@linux.ibm.com \
    --cc=gor@linux.ibm.com \
    --cc=hch@lst.de \
    --cc=linux-s390@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.